Reader View for Pale Moon

[jars_]

Huh, I just installed this add-on to try it out, and all but one of the add-on buttons in my navigation toolbar disappeared

same thing with me oh-oh-oh...

[Isengrim]

Version 1.0.1 removed from the site until this gets resolved. Sorry for the trouble, folks! Please revert to 1.0.0 for the time being.

[gracious1]

I did some further testing in a clean profile (called "test04").

1. Create custom toolbar Foo Bar.
2. Place several buttons from Customize dialog box into Foo Bar.
3. Restart Pale Moon.
4. Foo Bar with buttons is still there.
5. Install Reader View 1.0.1
6. Restart Pale Moon.
7. Foo Bar is gone; buttons are back in Customize dialog box.
   
   Now here is the interesting bit…
8. Open Add-ons Manager and hit Reader View's "Remove" button.
9. Restart Pale Moon.
10. Voila! Foo Bar is back with all its buttons!

This did not work in the working profile (called SEPTIMUS) that I had been using however, because I had used Clean Uninstall to remove preferences, as stated in my previous post. So maybe that was overkill and further damage was done. Also re-installing 1.0.0 seemed not work either. (I have not tested that yet in profile "test04".) And now, SEPTIMUS can't keep any custom toolbars after restart, so something is quite wrong.

UPDATE: I removed RV 1.0.0 from SEPTIMUS, and now it retains custom toolbars after restart. So it look likes even version 1.0.0 of RV is the culprit. Whoops. So it's doing the same thing that 1.0.1 does.
UPDATE_2: Verified that same behavior as occurred in test above occurs also in with Reader View 1.0.0 (disappearing custom toolbar).

Ubuntu 14.04 | PM 27.7.0a2 (64-bit) (2017-11-23)

[Isengrim]

I have done some testing with various add-ons as well as my own on both my Windows 7 machine and my Linux partition with regards to the aforementioned issues, and have had pretty mixed results. Please see my comments on the repository here and here. (Feel free to reply on this thread, I just don't want to post the same information twice in two places.)

In summary, I think some of these issues are simply beyond my control. For other toolbar buttons moving or being removed, that should at least be a one-time deal. There's now a first_run preference in about:config for this extension that is set to "false" automatically the first time you install the extension. So, even if you remove it and reinstall it, it won't try to add or move its button anywhere unless you reset the preference. If this still concerns you, I've outlined a step you can follow in that comment.

For custom toolbars being hidden... I wish I had an answer. I'll keep playing with my code to see if I can determine what's causing it, but I don't have a good response for that issue just yet. Thank you for your efforts, gracious1. As I mentioned, I was able to trigger this behavior with other add-ons besides Reader View, and what add-ons trigger it seem to be somewhat random.

I'll probably be releasing v1.0.2 tomorrow. It will contain most of the fixes and requests that were in v1.0.1, and should fix at least some of the issues around toolbar buttons. Thanks for the feedback, everyone!

[SpockFan02]

...custom toolbar Foo Bar. ...

Hehehe...

[Isengrim]

Reader View 1.0.2 is now up. The Pale Moon addons page and the github repository have both been updated. Please see the release notes for details.

This should fix some of the issues with add-on buttons being moved on first install (where the first_run preference is set to true or does not exist) as well as with custom toolbars disappearing.

Thank you everyone for the feedback, and happy reading!

[[DarKwiN]]

I found another problem related to toolbar: when installing Reader View, the refresh/stop button I've got on the right end of URL box gets thrown out of the URL box and divided in two split buttons (the refresh one and the stop one).
Disabling Reader View fixes the problem. Attached to the post you'll find a screenshot describing the situation.
Thanx!!

[gracious1]

I found another problem related to toolbar: when installing Reader View, the refresh/stop button I've got on the right end of URL box gets thrown out of the URL box and divided in two split buttons (the refresh one and the stop one).
Disabling Reader View fixes the problem. Attached to the post you'll find a screenshot describing the situation.
Thanx!!

So your toolbar looks like this…


Now try this:

1. Right-click in the toolbar and select "Customize…"
   
2. While the Customize dialog is open, move the Reader button to the right of Reload button.
   
   In other words, the order of the buttons is now Reader View, Reload, and Stop.
3. Click the "Done" button in the Customize dialog.
4. Now observe that the Stop and Reload buttons are no longer separate but unified again.
   

Whenever the Stop button is placed to the right of the Reload, they will unify. When the Stop button is to the left of Reload, or when a button is placed between them, they will remain separate.

[[DarKwiN]]

Nice tip, thank you!
I further examined the issue, and I could pin down the problem to simply not putting Reader View (or any other) button between Reload and Stop. Anything between them not only cause them to split, but also prevent the Reload button to be nicely put in the URL box. No problem putting anything to the left of the Reload button.
Thanx again!

[gracious1]

Nice tip, thank you!
I further examined the issue, and I could pin down the problem to simply not putting Reader View (or any other) button between Reload and Stop.

I think I said that in the post above....

Anything between them not only cause them to split, but also prevent the Reload button to be nicely put in the URL box. No problem putting anything to the left of the Reload button.

Anything but the stop button (if you want them to be unified)!

Thanx again!

You're welcome.

[fatboy]

This is probably my most favourite add-on and feature. However, I am observing "problems" with the add-on: I have to frequently reload pages for a page to become readable by the add-on.

[jars_]

have to frequently reload pages for a page to become readable by the add-on.]

yes, the extension does not work for pages loaded in background, and because of this I made a separate button:

Code: Select all

ReaderParent.toggleReaderMode(event);

Url-button with icon

Code: Select all

custombutton://%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF-8%22%3F%3E%0D%0A%3Ccustombutton%20xmlns%3Acb%3D%22http%3A//xsms.nm.ru/custombuttons/%22%3E%0A%20%20%3Cname%3EReader%20View%20%28%u043E%u0442%u0434%u0435%u043B%u044C%u043D%u0430%u044F%20%u043A%u043D%u043E%u043F%u043A%u0430%29%3C/name%3E%0A%20%20%3Cimage%3E%3C%21%5BCDATA%5Bdata%3Aimage/svg+xml%3Bbase64%2CPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4NCjwhLS0gVGhpcyBTb3VyY2UgQ29kZSBGb3JtIGlzIHN1YmplY3QgdG8gdGhlIHRlcm1zIG9mIHRoZSBNb3ppbGxhIFB1YmxpYw0KICAgLSBMaWNlbnNlLCB2LiAyLjAuIElmIGEgY29weSBvZiB0aGUgTVBMIHdhcyBub3QgZGlzdHJpYnV0ZWQgd2l0aCB0aGlzDQogICAtIGZpbGUsIFlvdSBjYW4gb2J0YWluIG9uZSBhdCBodHRwOi8vbW96aWxsYS5vcmcvTVBMLzIuMC8uIC0tPg0KPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMTgiIGhlaWdodD0iMTgiIHZpZXdCb3g9IjAgMCAxNiAxNiI+DQogIDxkZWZzPg0KICAgIDxwYXRoIGlkPSJnbHlwaFNoYXBlLXJlYWRlck1vZGUtYm9vayIgZD0iTTUuNSw1aC0yQzMuMiw1LDMsNS4yLDMsNS41UzMuMiw2LDMuNSw2aDIgQzUuOCw2LDYsNS44LDYsNS41UzUuOCw1LDUuNSw1eiBNNS41LDdoLTJDMy4yLDcsMyw3LjIsMyw3LjVTMy4yLDgsMy41LDhoMkM1LjgsOCw2LDcuOCw2LDcuNVM1LjgsNyw1LjUsN3ogTTUuNSw5aC0yIEMzLjIsOSwzLDkuMiwzLDkuNVMzLjIsMTAsMy41LDEwaDJDNS44LDEwLDYsOS44LDYsOS41UzUuOCw5LDUuNSw5eiBNMTUuNCwyYzAsMC0zLjEsMC00LjQsMFM4LjEsMi41LDgsNC4zQzcuOSwyLjUsNi4zLDIsNSwyIFMwLjYsMiwwLjYsMkMwLjMsMiwwLDIuMywwLDIuN3Y5LjZDMCwxMi42LDAuMywxMywwLjYsMTNjMCwwLDIuNiwwLDQuNCwwYzEuNiwwLDIuOCwxLDMsMi4zQzguMiwxNCw5LjQsMTMsMTEsMTMgYzEuOCwwLDQuNCwwLDQuNCwwYzAuNCwwLDAuNi0wLjQsMC42LTAuOFYyLjdDMTYsMi4zLDE1LjcsMiwxNS40LDJ6IE0xNCwxMUwxNCwxMWMtMC4yLDAtMS42LDAtMywwYy0xLjYsMC0yLjksMC44LTMsMi4yIEM3LjksMTEuOCw2LjYsMTEsNSwxMWMtMS40LDAtMi44LDAtMywwbDAsMGwwLDBWNGMwLDAsMi43LDAsMy41LDBDNi42LDQsOCw1LjUsOCw2LjhDOCw1LjUsOS40LDQsMTAuNSw0QzExLjMsNCwxNCw0LDE0LDRWMTEgTDE0LDExeiIvPg0KICAgIDxsaW5lYXJHcmFkaWVudCBpZD0iZ3JhZGllbnQtc3RhdGUtcHJlc3NlZCIgeDE9IjAlIiB5MT0iMCUiIHgyPSIwIiB5Mj0iMTAwJSI+DQogICAgICA8c3RvcCBzdG9wLWNvbG9yPSIjNmY2ZmZmIiBvZmZzZXQ9IjAlIi8+DQogICAgICA8c3RvcCBzdG9wLWNvbG9yPSIjMjQyNGZmIiBvZmZzZXQ9IjEwMCUiLz4NCiAgICA8L2xpbmVhckdyYWRpZW50Pg0KICAgIDxzdHlsZT4NCiAgICAgIC5pY29uLXN0YXRlLXByZXNzZWQgeyBmaWxsOiB1cmwoI2dyYWRpZW50LXN0YXRlLXByZXNzZWQpOyB9DQogICAgPC9zdHlsZT4NCiAgPC9kZWZzPg0KICA8dXNlIHhsaW5rOmhyZWY9IiNnbHlwaFNoYXBlLXJlYWRlck1vZGUtYm9vayIgY2xhc3M9Imljb24tc3RhdGUtcHJlc3NlZCIvPg0KPC9zdmc+DQo%3D%5D%5D%3E%3C/image%3E%0A%20%20%3Cmode%3E0%3C/mode%3E%0A%20%20%3Cinitcode%3E%3C%21%5BCDATA%5B/*Initialization%20Code*/%5D%5D%3E%3C/initcode%3E%0A%20%20%3Ccode%3E%3C%21%5BCDATA%5BReaderParent.toggleReaderMode%28event%29%3B%5D%5D%3E%3C/code%3E%0A%20%20%3Caccelkey%3E%3C%21%5BCDATA%5B%5D%5D%3E%3C/accelkey%3E%0A%20%20%3Chelp%3E%3C%21%5BCDATA%5B%5D%5D%3E%3C/help%3E%0A%20%20%3Cattributes/%3E%0A%3C/custombutton%3E

[gracious1]

yes, the extension does not work for pages loaded in background, and because of this I made a separate button:

Code: Select all

ReaderParent.toggleReaderMode(event);

Where exactly do you put the code?

[jars_]

gracious1
Custom Buttons – the only and indispensable extension

[Isengrim]

I am currently working on a fix for this. It has to do with some of the code I borrowed from the original browser's codebase working differently in the context of an extension. I have a tentative fix in place in my development environment, but I want to do some more testing to make sure it's ready.

For now, selecting a background-loaded tab and refreshing it should cause the button to update correctly. Force-toggling Reader Mode also works I guess, but it should not be necessary after the next update.

Edit: The issue is also on the Github repo, #15.

[fatboy]

I am currently working on a fix for this. It has to do with some of the code I borrowed from the original browser's codebase working differently in the context of an extension. I have a tentative fix in place in my development environment, but I want to do some more testing to make sure it's ready.

For now, selecting a background-loaded tab and refreshing it should cause the button to update correctly. Force-toggling Reader Mode also works I guess, but it should not be necessary after the next update.

Edit: The issue is also on the Github repo, #15.

Wow, thank you for the quick reply and quick fix!

[Isengrim]

Reader View 1.1.0 is now up. The Pale Moon addons page and the github repository have both been updated. Please see the release notes for details.

Most of the changes are under-the-hood updates from the upstream mozilla-central code. I've also added localization files pulled from l10n-central. Most of these will be incomplete, but they're still applicable enough that I went ahead and included them.

As a side note, I've also added xpi files to the github release pages so you can download them directly if you wish.

Feliz lectura! Joyeuse lecture! Buona lettura!

[f-117]

So, what will you be working on next in the github "Issues" list?

Scott.

[Isengrim]

So, what will you be working on next in the "Issues" list?

Well, I just realized that all of the localizations are incomplete, which will cause some breakage... so I'm roughing in some missing translations first.

The next highest priority is #15. It's going to take a bit of rework and plenty of testing, so that one may be a little while.

Beyond that, #7 if it's feasible, or else I'll probably look at #16.

[Isengrim]

Reader View 1.1.1 is now up. The Pale Moon addons page and the github repository have both been updated. Please see the release notes for details.

This is an update/fix for several of the previously included localizations. The locale files were missing translations for a string property I added to the fork, which would cause the add-on to not function correctly if you were using any locale other than en-US. I've added some very rough translations for this text to at least fix functionality, but they probably need some additional work - see #21.

Happy reading!