Add Bookmark Here ² not working?

This board is for discussions, bug reports, etc. for pre-releases of the v27 milestone codenamed "Tycho".

Since the beta phase is over, this board is closed for new posts/topics.

Moderator: satrow

kizo07

Add Bookmark Here ² not working?

Unread post by kizo07 » 2016-10-28, 00:55

It seems that Add Bookmark Here ² (Version 23.0.20140225.1) not working in 27b3

User avatar
Shadeclan
Lunatic
Lunatic
Posts: 294
Joined: 2014-06-05, 17:27
Location: Albany, NY

Re: Add Bookmark Here ² not working?

Unread post by Shadeclan » 2016-10-28, 16:50

I verified this using the latest version of this add-on that still works with Pale Moon - 23.0.20140225.1
Image

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24457
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Add Bookmark Here ² not working?

Unread post by Moonchild » 2016-10-29, 09:00

The extension will have to be updated to work with the changes to the places API. Very likely it will have to target Pale Moon specifically from this point forward.

Code: Select all

Error: TypeError: PlacesUtils.nodeIsReadOnly is not a function
Source File: chrome://abhere2/content/browserOverlay.js
Line: 480
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

kizo07

Re: Add Bookmark Here ² not working?

Unread post by kizo07 » 2016-10-29, 19:40

Thanks for your reply. It was nice add-on for the easiest and fastest bookmarking. I know that is not a priority but it should be considered to be finally interpreted/coded into the future PM .. just like in Opera or Maxthon. Something like 'Bookmark Current Page' or 'Add Here' in every bookmarks folder.
Otherwise I have for years been a user of Maxthon, until ver.4. After that 'fox' for a few months and the last two years I use PM. The best browser to date.. and I already see that PM 27 gonna be even better. Thanks again.

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1780
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: Add Bookmark Here ² not working?

Unread post by JustOff » 2016-10-30, 10:26

Moonchild wrote:The extension will have to be updated to work with the changes to the places API.
The fix for PM27+ is simple (actually taken from abh2 31.0.20150313):

Code: Select all

--- browserOverlay.js.orig	Mon Feb 24 01:28:10 2014
+++ browserOverlay.js	Sun Oct 30 12:23:11 2016
@@ -299,0 +300,4 @@
+	nodeIsReadOnly: function(node) {
+		return PlacesUtils.nodeIsFolder(node) && PlacesUIUtils.isContentsReadOnly(node); // Firefox36+
+	},
+
@@ -355 +359 @@
-		if (PlacesUtils.nodeIsReadOnly(node)) return;
+		if (abHere2.nodeIsReadOnly(node)) return;
@@ -480 +484 @@
-			if (ip && ip.node && !PlacesUtils.nodeIsReadOnly(ip.node)) {
+			if (ip && ip.node && !abHere2.nodeIsReadOnly(ip.node)) {
I can share patched xpi (verified, works for me), but I'm not sure how to do it in most acceptable way.
Here are the add-ons I made in a spare time. That was fun!

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 5884
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Add Bookmark Here ² not working?

Unread post by New Tobin Paradigm » 2016-10-30, 11:10

We do have an Add-ons Site for a reason.

In fact we are prepping a major update to the Add-ons Site with all new software written by my self over the past week to make somewhat easier for everyone and to get a few things that have been requested.

In any event, you can always rebrand, change the author and id, and make it a fork. Unless you can get upstream to accept a patch. Forking is likely the better option as long as the license allows it.

User avatar
Shadeclan
Lunatic
Lunatic
Posts: 294
Joined: 2014-06-05, 17:27
Location: Albany, NY

Re: Add Bookmark Here ² not working?

Unread post by Shadeclan » 2016-10-31, 17:48

Sounds like a plan. Why not make a fork - especially if you already have the fix.
Image

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1780
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: Add Bookmark Here ² not working?

Unread post by JustOff » 2016-11-04, 18:45

Until I figured out with addons.palemoon.org, here is the fix.
Here are the add-ons I made in a spare time. That was fun!

User avatar
Doelli
Apollo supporter
Apollo supporter
Posts: 47
Joined: 2014-10-11, 15:25
Location: Germany

Re: Add Bookmark Here ² not working?

Unread post by Doelli » 2016-11-05, 09:11

This seems like almost the same issue like in this post:
https://forum.palemoon.org/viewtopic.php?p=94355#p94355

Does anyone know, how to fix it (without removing code from "AddBookmarkHere.uc.js ", as i did)?

kizo07

Re: Add Bookmark Here ² not working?

Unread post by kizo07 » 2016-11-06, 01:47

Works flawlessly! Many thanks JustOff

Locked