Bug with PM's download manager through the use of extensions?
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Bug with PM's download manager through the use of extensions?
This might very well be a result of Pale Moon moving further away from the Firefox/Gecko code of course.
..but since there's obviously been some major changes in regards to how the Tycho builds handles downloads, I suspect that it might be caused by a bug.
I'm still using a modified build of the 'Flash and Video Download' extension, which I've posted a link to here:
viewtopic.php?f=46&t=10849&start=40#p78672
This is a very handy extension, particularly because it works on a generic level, and not only for YouTube videos.
Up until now, the modified build has worked just fine with Pale Moon.
But now, with the release of the v27 Alpha/Beta builds, it doesn't work anymore!
The extension detects flash videos just fine, but when I click on the extension's icon, it doesn't display the size of the video file like before.
When I click on the file that I want to download, the file still gets trasfered to PM's download window, but it doesn't handle it properly..
The progress bar shows green all the way (100%), it says "Unknown time remaining - 0 bytes", and nothing happens!
Like I pointed out above, I understand if this simply is a result of PM's/Goanna's ongoing development.
..but it would be nice if someone could rule out the possibility of a bug in PM 27's download manager.
..but since there's obviously been some major changes in regards to how the Tycho builds handles downloads, I suspect that it might be caused by a bug.
I'm still using a modified build of the 'Flash and Video Download' extension, which I've posted a link to here:
viewtopic.php?f=46&t=10849&start=40#p78672
This is a very handy extension, particularly because it works on a generic level, and not only for YouTube videos.
Up until now, the modified build has worked just fine with Pale Moon.
But now, with the release of the v27 Alpha/Beta builds, it doesn't work anymore!
The extension detects flash videos just fine, but when I click on the extension's icon, it doesn't display the size of the video file like before.
When I click on the file that I want to download, the file still gets trasfered to PM's download window, but it doesn't handle it properly..
The progress bar shows green all the way (100%), it says "Unknown time remaining - 0 bytes", and nothing happens!
Like I pointed out above, I understand if this simply is a result of PM's/Goanna's ongoing development.
..but it would be nice if someone could rule out the possibility of a bug in PM 27's download manager.
-
- Pale Moon guru
- Posts: 35649
- Joined: 2011-08-28, 17:27
- Location: Motala, SE
Re: Bug with PM's download manager through the use of extensions?
Downloads are handled completely differently in Tycho -- downloads are handled via the JSTransfer API now. "Downloaders" and managers using the old API simply won't work and will have to be updated/rewritten.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
I just noticed something..
Like I wrote before, when using the 'Flash and Video Download' extension wih Pale Moon v27, the files DOES get transfered to PM's download window, like before.
..but the downloads simply doesn't start.
However, after I canceled the downloads and restarted the browser a few times, the downloads remained in PM27's download list, and suddely they all kicked in and finished just fine!!
I wonder, could this indicate that there really IS a minor bug with PM27's new download management?
This might be worth looking into.
It's probably just a very minor detail that prevents this extension, and others like it, from functioning 100% with PM27!
Like I wrote before, when using the 'Flash and Video Download' extension wih Pale Moon v27, the files DOES get transfered to PM's download window, like before.
..but the downloads simply doesn't start.
However, after I canceled the downloads and restarted the browser a few times, the downloads remained in PM27's download list, and suddely they all kicked in and finished just fine!!
I wonder, could this indicate that there really IS a minor bug with PM27's new download management?
This might be worth looking into.
It's probably just a very minor detail that prevents this extension, and others like it, from functioning 100% with PM27!
Re: Bug with PM's download manager through the use of extensions?
The new version (2.02) seems to work fine.
Ad "the wrong icon in the toolbar": (replace all) "toolbarbutton-1" => "toolbarbutton-fnvfox"
Ad "the wrong icon in the toolbar": (replace all) "toolbarbutton-1" => "toolbarbutton-fnvfox"
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
Sounds good, but you'll have to specify some more, cuz I really don't know anything about coding this stuff.GMforker wrote:The new version (2.02) seems to work fine.
Ad "the wrong icon in the toolbar": (replace all) "toolbarbutton-1" => "toolbarbutton-fnvfox"
Which file, which lines, and where to place them exactly?
And how to make v2.02 compatible with PM in the first place?
Re: Bug with PM's download manager through the use of extensions?
1) "/install.rdf" - an additional target application entry:Tomaso wrote:Sounds good, but you'll have to specify some more, cuz I really don't know anything about coding this stuff.GMforker wrote:The new version (2.02) seems to work fine.
Ad "the wrong icon in the toolbar": (replace all) "toolbarbutton-1" => "toolbarbutton-fnvfox"
Which file, which lines, and where to place them exactly?
And how to make v2.02 compatible with PM in the first place?
Code: Select all
<!-- Pale Moon -->
<em:targetApplication>
<Description>
<em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
<em:minVersion>27.0.0b2</em:minVersion>
<em:maxVersion>27.*</em:maxVersion>
</Description>
</em:targetApplication>
"/chrome/content/overlay.xul" - line 14
"/modules/ToolbarButton.js" - line 189
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
Thanks a lot!GMforker wrote:1) "/install.rdf" - an additional target application entry:2) Replace strings: "toolbarbutton-1" => "toolbarbutton-fnvfox":Code: Select all
<!-- Pale Moon --> <em:targetApplication> <Description> <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id> <em:minVersion>27.0.0b2</em:minVersion> <em:maxVersion>27.*</em:maxVersion> </Description> </em:targetApplication>
"/chrome/content/overlay.xul" - line 14
"/modules/ToolbarButton.js" - line 189
That did the trick!!
I've posted a modified build here:
viewtopic.php?f=46&t=10849&p=95026#p95026
:)
Re: Bug with PM's download manager through the use of extensions?
And when the Add-ons Manager checks for updates? It will get overwritten. You guys need to learn to properly fork.. Change the GUID and branding.. Assuming the license is agreeable. Also, stop posting rogue edited extensions on the forums.. Submit forks to the Add-ons Site..
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
No.Matt A Tobin wrote:And when the Add-ons Manager checks for updates? It will get overwritten.
I've got that feature disabled!:
extensions.update.autoUpdateDefault = false
extensions.update.enabled = false
--
OKMatt A Tobin wrote:stop posting rogue edited extensions on the forums.
-
- Pale Moon guru
- Posts: 35649
- Joined: 2011-08-28, 17:27
- Location: Motala, SE
Re: Bug with PM's download manager through the use of extensions?
So the world consists of only you?Tomaso wrote:No.
I've got that feature disabled!:
You may have, but someone else who follows these instructions or downloads your hacked version will run into this.
Think a little larger
Seriously though, for open/permissive licenses, if you want to share what works and you can't get the original author to make it Pale Moon compatible themselves, please take the extra half hour it needs (assuming you properly create original identifying graphics) to fork and re-brand the extension, then get it over to addons.palemoon.org.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
Well, we have discussed to auto-update "issue" before (briefly at least):Moonchild wrote:You may have, but someone else who follows these instructions or downloads your hacked version will run into this.
viewtopic.php?f=46&t=10849&start=60#p81936
--
Like I've already pointed out, I don't know anything about coding, so providing official forks is not for me:Moonchild wrote:for open/permissive licenses, if you want to share what works and you can't get the original author to make it Pale Moon compatible themselves, please take the extra half hour it needs (assuming you properly create original identifying graphics) to fork and re-brand the extension, then get it over to addons.palemoon.org.
viewtopic.php?f=46&t=10849&start=40#p79681
Also, getting in contact with the developer(s) of this extension seems to be impossible!:
viewtopic.php?f=46&t=10849&start=60#p87367
-
- Pale Moon guru
- Posts: 35649
- Joined: 2011-08-28, 17:27
- Location: Motala, SE
Re: Bug with PM's download manager through the use of extensions?
The edits you made are all the coding involved for your minimal fork. You've already done this; what more coding do you think is needed?Tomaso wrote:Like I've already pointed out, I don't know anything about coding, so providing official forks is not for me:
The rest of the work involved is changing the name, ID (in install.rdf) and replacing identifying graphics (if needed), which is metadata. Then zipping it all up under your new name. And you're done. It really isn't that involved for extensions.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
-
- Board Warrior
- Posts: 1622
- Joined: 2015-07-23, 16:09
- Location: Norway
Re: Bug with PM's download manager through the use of extensions?
My point is that I didn't figure out that stuff by myself.Moonchild wrote:The edits you made are all the coding involved for your minimal fork. You've already done this; what more coding do you think is needed?
Other people did, and I simply zipped it all up, as you say.
IMO, an extension maintainer should be able to figure out those things for themselves.
Perhaps GMforker feels up to the task? :)
Re: Bug with PM's download manager through the use of extensions?
I only advised I have other priorities at the moment... Anyone who wants can take it - the license does not prohibit it...Tomaso wrote:Perhaps GMforker feels up to the task?