Download Flash and Video download problem

[Cogito Ergo Sum]

Nope I'm saying that Download Flash and Video download extension works everywhere, but in Palemoon 26 download not working correctly .

Ok, i like http://www.fnvfox.com/ and it sucks that it no longer works in Pale Moon.

[SGvagon]

It works when you copy URL and paste to the address bar.

[Cogito Ergo Sum]

It works when you copy URL and paste to the address bar.

That works for Youtube, but not for SOME other sites.

[SGvagon]

Yes it works anywhere.

[Tomaso]

Version 1.68.1 adds a check using VersionInfo.isVersionBiggerOrEqual("26") and tries to use the incompatible Downloads.jsm api with Pale Moon.

Actually, in the latest version (v1,79, which still doesn't work with PM26), this value seems to be "29".

[jumba]

Actually, in the latest version (v1,79, which still doesn't work with PM26), this value seems to be "29".

Did the latest version work with Pale Moon 25?

[Tomaso]

Did the latest version work with Pale Moon 25?

Yes.

[jumba]

Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.

[Tomaso]

Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.

Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here (v1.80):
http://www.mediafire.com/download/uurn7 ... MOD%29.zip

Thanks to jumba, for pointing out the problem! :)

[Cogito Ergo Sum]

Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.

Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here:
http://www.mediafire.com/download/tcn93 ... MOD%29.zip

Thanks to jumba, for pointing out the problem!

Thanks, your mod works.

[SGvagon]

Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.

Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here:
http://www.mediafire.com/download/tcn93 ... MOD%29.zip

Thanks to jumba, for pointing out the problem!

Super It WORKS!! Thank you .

[dark_moon]

Maybe you should contact Tobin to upload the addon to Pale Moon addon site, if here no copyrights are violated

[Tomaso]

Maybe you should contact Tobin to upload the addon to Pale Moon addon site, if here no copyrights are violated

Let's wait and see if the author responds to my mail first.

[Tomaso]

Download Flash & Video v1.80 released.
Changelog:

* Fixed dailymotion.com video detection

--

I've uploaded the new modified version here:
viewtopic.php?f=46&t=10849&p=78672#p78672
As long as this simple hack works, I'll keep on updating that post, without bumping the thread.

[jumba]

You should consider creating a fork and release it under Pale Moon's addons site.

[Tomaso]

You should consider creating a fork and release it under Pale Moon's addons site.

Nah, this is just a brutal hack.
I've got no real understanding about programming. :)

[DoctorM]

Edit: Thanks works fine.
I like FlashGot a bit better and it seems a similar fix works for that.

[Tomaso]

JFYI:

I uploaded a modified build of v1.81 earlier, but I've removed it now.

While it worked just fine with YouTube, it completely failed to detect videos on some other sites.
Don't know if this is a general bug with this version, or if it's yet another compatibility issue with Pale Moon.

For now, I've put v1.80 back up.
I'll try out our hack on future releases too of course.
If the current issue seems to have been resolved, I'll upload new mods..
If not, we'll just have to stay with v1.80. :(

[SGvagon]

Hmm, on version 1.80 youtube doesn't work anymore .

[Tomaso]

Hmm, on version 1.80 youtube doesn't work anymore :( .

The one that I modified still works just fine for me.
Try this:
1) Uninstall whatever version you're currently using ('Tools' > 'Add-ons' > 'Extensions' > 'Flash and Video Download' > 'Remove').
2) IMPORTANT: Restart Pale Moon.
3) Install the modified v1.80 build.