"ac_add_options --enable-av1" in my mozconfig?

[stevenpusser]

Should I remove these for my 29.1.0 package builds, or is the AV1 decoder also disabled by default, or are both true?

Thanks!

I notice that it's not on the approved options for mozconfig on the packager's page, so I would guess it needs to go.

[New Tobin Paradigm]

It should be built but returned to pref-disabled.

[stevenpusser]

Shouldn't it be in the mozconfig on the packager's guide?

# Standard build options for Pale Moon
ac_add_options --enable-application=palemoon
ac_add_options --enable-optimize="-O2 -w"
ac_add_options --enable-default-toolkit=cairo-gtk$_GTK_VERSION
ac_add_options --enable-jemalloc
ac_add_options --enable-strip
ac_add_options --enable-devtools
ac_add_options --disable-eme
ac_add_options --disable-webrtc
ac_add_options --disable-gamepad
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-necko-wifi
ac_add_options --disable-updater
ac_add_options --with-pthreads

[New Tobin Paradigm]

Yes it should. Feel free to update the various build pages. We all tend to forget about av1 except when we don't.. can't really explain why.

[tarakbumba]

I think I really don't understand well what's going on here. Should we add

Code: Select all

ac_add_options --enable-av1

in our mozconfigs or not ? Besides, while it is not in build instructions page, is it allowed to use this option?

[vannilla]

Yes, you should add it so that users can enable or disable the decoder at runtime.
However, make sure that the final binary on first start on a new and uncustomized profile, defaults the relative setting to disabled at runtime.

[tarakbumba]

Yes, you should add it so that users can enable or disable the decoder at runtime.
However, make sure that the final binary on first start on a new and uncustomized profile, defaults the relative setting to disabled at runtime.

Thank you for clarification. I' ll update my config according to this.