Menu icon for extension doesn't display in my daily use profile, only in a fresh one

[moonbat]

For both my extensions, Pure URL and PMPlayer - the icon for the tools menu entry and the context menu (for PMPlayer) work fine on my barebones development profile, but not in my regular daily profile. I've seen this with Basilisk and Borealis as well. Even if I switch to the default theme it persists, and I don't see this problem with other extensions whose menu icons display fine. I'm using CSS to set the icon, and it works fine in a fresh/empty profile. The active attribute is set at startup.

Overlay code -

Code: Select all

	<menupopup id="menu_ToolsPopup">
		<menuitem id="menu-pureurl4pm-options" class="menu-iconic"
			label="&pureurl_toolsmenu_caption;" accesskey="&pureurl_accelerator;"
			insertafter="appmenu_addons" command="CmdPureURL4PMOptions" />
	</menupopup>

CSS entry for menu -

Code: Select all

#menu-pureurl4pm-options[active="false"] {
		list-style-image:url('chrome://pureurl4pm/skin/icon-red.png');
}
#menu-pureurl4pm-options[active="true"] {
		list-style-image:url('chrome://pureurl4pm/skin/icon-green.png');
}

[Moonchild]

In your definition you neither set the active attribute to false nor true so it will be undefined and not hit either css rule to display the icon.
Menus are cached (for obvious reasons) in GUI rendering. If something else causes the menu to be altered before your extension init sets it, it'll be cached in its initial state (in your case undefined, meaning without an icon).

[moonbat]

Menus are cached (for obvious reasons) in GUI rendering. If something else causes the menu to be altered before your extension init sets it, it'll be cached in its initial state (in your case undefined, meaning without an icon).

But the menu loads and shows the icon fine on a fresh profile, just not on my everyday profile. I do the menu init at the very end of my extension init.

[moonbat]

Turns out my icons don't play well with themes. If I revert to the default theme as I have on my development profile, then they show up. Other extension icons continue to work. What am I doing wrong?

[Moonchild]

Well, maybe I was wrong then -- unfortunately I'm not the theming guru here so I'll hand this one over to Lootyhoof to answer.

[opus_27]

I'd suggest you try removing [active="false"] from the first CSS rule, leaving the second as is:

#menu-pureurl4pm-options {
list-style-image:url('chrome://pureurl4pm/skin/icon-red.png');
}
#menu-pureurl4pm-options[active="true"] {
list-style-image:url('chrome://pureurl4pm/skin/icon-green.png');
}

[Lootyhoof]

I'd agree with @opus_27. By default show the red inactive icon, and if it does become active at any point change to the active icon.

[moonbat]

Ok but why does it only not work when I change the theme from the default? If I don't use any themes then the icons display correctly.

[Lootyhoof]

Does it happen with any theme, or only specific ones?

[moonbat]

I guess it isn't theme specific. Tested with Moonscape, Australium and XMoon.
I use Moonscape on my usual profile, and just now added Australium to my development profile which doesn't have any extensions to test - and the icons have disappeared after a restart.