Pale Moon 28.9.0

[dbsoft]

Here is the new Pale Moon version 28.9.0, same build environment new release. Popup window fix made it into this release:

Download

Personas should be disabled as Tobin suggested in this build.

Hope it works well for you.

Brian

[KlarkKentThe3rd]

Everything works as expected, yet still unable to log in Citibank Online. Will have to keep using Waterfox for that.

[Kasane]

Thanks for the new build. The popup windows work as expected, but the problem with the windows controls in private mode still persist.

[dbsoft]

Thanks for the new build. The popup windows work as expected, but the problem with the windows controls in private mode still persist.

I included the --disable-personas in the config settings, but wasn't sure how to test it. I am not sure that the private browsing titlebar is the same thing or not... But that was the next thing on my todo-list since the private browsing window on my screen at least is missing the window title text. I did not notice issue with the buttons, but I'll look into it in depth soon.

[dbsoft]

Not sure if it is necessary but there was a point release, 28.9.0.1 so here is an updated build:

Download

[New Tobin Paradigm]

Yeah it was. Also come back to the irc.

[dbsoft]

Yeah it was. Also come back to the irc.

Yeah I will, was IRCing from my server and in the middle of an upgrade, will be back when the upgrade is finished.

[dbsoft]

Another minor update to 28.9.0.2:

Download

[KlarkKentThe3rd]

Great stuff. Still cannot log into Citibank Online.

As an aside, I experimented with the Otter browser today, and could log in no problem (despite the browser being a buggy testing alpha mess).

[dbsoft]

Great stuff. Still cannot log into Citibank Online.

Was looking at the error you posted earlier:

Error: ReferenceError: event is not defined
Source File: https://online.citi.com/GFC/branding/re ... js/main.js

I think this error is saying the "event" object is not defined, but from what I can see it should be a global scope object that is an alias for window.event

https://stackoverflow.com/questions/642 ... llback-cha

I am not sure what code is triggering it since it is compressed into a single line of javascript code, but after beautifying the code I see at least two javascript functions in that file that access the event object:

Code: Select all

function mobileDropdown() {
    event.preventDefault(), event.stopPropagation(), $("#mobileNav").removeAttr("style").css("display", "none"), $("#mobileNav").css("display", "block"), document.getElementById("mobileDrop").classList.contains("show") && hideMobileDrop(), document.getElementById("mobileDrop").classList.toggle("show"), document.getElementById("icon").classList.toggle("expanded"), document.getElementById("icon").classList.toggle("collapsed")
}
$("#main-nav > li > a").each(function() {
    ids_dropbtn.push($(this).attr("id"))
}), window.addEventListener("keydown", function(e) {
    var n = document.activeElement.id,
        s = document.activeElement.parentElement.id;
    if (null != s) var a = document.activeElement.getAttribute("data-menu");
    if (-1 == $.inArray(n, ids_dropbtn) && null == a) var t = ids_dropbtn.indexOf(s);
    else t = -1 == $.inArray(s, ids_dropbtn) && null == a ? ids_dropbtn.indexOf(n) : $.inArray(a, ids_dropbtn);
    var i = event.keyCode || event.which,
        o = ids_menu.indexOf(s);

((I only included enough of the second function to show the event object use for brevity))
Does anyone more versed in the javascript subsystem have any ideas?

[Moonchild]

it should be a global scope object that is an alias for window.event

We don't have window.event -- global event handlers are per-document for us, not per window (it's more logical on documents). This is an open enhancement issue. See Issue #595 (UXP) -- it's bounty material, by the way so if you want to tackle this, you'll get paid for it.

[KlarkKentThe3rd]

I wish I was already a real programmer so I could get paid for helping myself.

[dbsoft]

I wish I was already a real programmer so I could get paid for helping myself.

I took a quick look at this, and it is a major project... due to some serious code drift. I got the patches mostly applied, with major changes due to a split nsGlobalWindow into two separate classes. It also looks like this huge patch may need to be applied, or need to convert from nsIDOMEvent to mozilla::dom::Event in a particular location. The huge patch seems to unify the two types.

https://bugzilla.mozilla.org/show_bug.cgi?id=1455055

[KlarkKentThe3rd]

Well, I'll keep waiting patiently.

[gracious1]

Is there a setting in about:config to restore personas, or has that functionality been completely removed in 28.9.x?

[New Tobin Paradigm]

It is hard-disabled at build time as a workaround to issues with custom window frames across multiple OS X versions. Personas specifically use custom frames on Macintosh so as a consequence they are also disabled.

EITHER we fix custom frames and everything goes back to the way it was OR we disable them permanently but re-enable personas to just be on the toolbars (like how personas work on Windows when the menubar is visible). The third option is to fix them but severely limit the versions of MacOS X that Pale Moon can run on being limited to some of the most recent versions only. That is something we want to avoid unless absolutely necessary.

[dbsoft]

It is hard-disabled at build time as a workaround to issues with custom window frames across multiple OS X versions. Personas specifically use custom frames on Macintosh so as a consequence they are also disabled.

How do I reproduce the issue that is being worked around by disabling personas anyway? Reenable them and install a particular persona from the site or any one? Does it only affect certain versions?

[New Tobin Paradigm]

Previous discussion indicated it affects newer OSX when compiled targeting older OSX. Or something. Go read the issues and search the forum and channel logs.

[dbsoft]

Previous discussion indicated it affects newer OSX when compiled targeting older OSX. Or something. Go read the issues and search the forum and channel logs.

https://github.com/MoonchildProductions/UXP/issues/491
https://github.com/MoonchildProductions/UXP/issues/584
https://github.com/MoonchildProductions/UXP/issues/740

Guessing these are the issues? Posting them here for reference.

Are we sure we need to disable personas? Even with personas disabled I see issues with the private browsing window titlebar.

[KlarkKentThe3rd]

This might be relevant, but recently I went on my first (and last) theme binge. I got about 8 of them now, and none caused any problems. Mac OS = High Sierra.