uBlock Origin getting a bit old?

General discussion, compatibility and contributed extensions.

Moderators: FranklinDM, Lootyhoof

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1935
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: uBlock Origin getting a bit old?

Post by JustOff » 2019-12-17, 19:47

Moonchild wrote:
2019-12-17, 19:16
A few clicks, taking less than a minute of your time to release an update.
I just can't put these few clicks in crontab ;)
opening the door to the inherent issues an exposed web API would bring with it?
I don't think that an API neatly implemented by an experienced developer like Tobin could lead to any such issues.
Here are the add-ons I made in a spare time. That was fun!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26153
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: uBlock Origin getting a bit old?

Post by Moonchild » 2019-12-17, 20:05

JustOff wrote:
2019-12-17, 19:47
I just can't put these few clicks in crontab
That's a good thing :)
JustOff wrote:
2019-12-17, 19:47
I don't think that an API neatly implemented by an experienced developer like Tobin could lead to any such issues.
It doesn't matter how it's implemented. Any public-facing API like that inherently:
  • opens up the site/panel to abuse or misuse from automated processes
  • provides an attack surface for crackers
  • promotes "release version diarrhea" (releasing a new version with every miniscule change) -- this is also a server bandwidth/load nightmare
  • unbalances the workload -- vetting is done by people, so submitting should also be done by people, not automated processes
by its very nature of being an API.

It isn't worth the investment for implementation and maintenance; if extension devs find it too much work to click a few times to publish on their dedicated distribution platform, they are likely not very invested in long-term extension development and maintenance, so who are we doing it for in that case?...
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1935
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: uBlock Origin getting a bit old?

Post by JustOff » 2019-12-17, 20:42

Moonchild wrote:
2019-12-17, 20:05
if extension devs find it too much work to click a few times to publish on their dedicated distribution platform, they are likely not very invested in long-term extension development and maintenance
Sorry, but I see it exactly the opposite, and looks like it will be difficult to re-convince each other. So I'd suggest postponing this topic for now, if you don't mind.
Here are the add-ons I made in a spare time. That was fun!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26153
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: uBlock Origin getting a bit old?

Post by Moonchild » 2019-12-17, 21:58

Sure, fine, whatever.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
moonbat
Board Warrior
Board Warrior
Posts: 1093
Joined: 2015-12-09, 15:45
Location: Australia

Re: uBlock Origin getting a bit old?

Post by moonbat » 2019-12-18, 01:40

Moonchild wrote:
2019-12-17, 20:05
so submitting should also be done by people, not automated processes
Off-topic:
Looks like that's what Mozilla has more of these days (automation), given that there are tons more malicious extensions now than there ever were before they brought in WebExtensions.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Linux Mint 19.3 Xfce x64 on HP i5 laptop with 4 GB RAM, always latest versions of PM & Basilisk unless specified.

User avatar
gepus
Lunatic
Lunatic
Posts: 428
Joined: 2017-12-14, 12:59

Re: uBlock Origin getting a bit old?

Post by gepus » 2019-12-18, 15:03

JustOff wrote:
2019-12-16, 18:55
Meanwhile, the nested "!#include" issue has been fixed in uBlock 1.16.4.12 :coffee:
Many thanks JustOff!

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-11, 23:53

Important information, regarding uBlock Origin!:

A couple of days ago, most rules that used the old uBO syntaxes were removed from 'uBlock filters':
https://github.com/DandelionSprout/adfi ... -572937742

But now, thanks to the amazing work of DandelionSprout and JustOff, there is now a new beta version out for testing!
JustOff's beta build automatically converts new uBO syntaxes (not compatible with uBO Legacy) into old ones!
This has been made possible thanks to a custom Python script, created by DandelionSprout (*), which JustOff has modified to work directly/automatically in uBO:
https://github.com/uBlockOrigin/uAssets/pull/6808/
So, give the new beta version a try, and report any bugs that you might find! (Download here: https://github.com/DandelionSprout/adfi ... -573341191)

(*) Being a die hard Google Chrome user himself, DandelionSprout only made this script as a gesture of good will.
He will also be maintaining the 'uBlock filters - Legacy' list, updating it regularly with certain special rules that might need manual convertion.
Therefore, be sure to place your thumbs up, hearts and hooray emojis accordingly at GitHub! :)

List of old vs new uBO syntaxes (provided by okiehsch):
https://github.com/DandelionSprout/adfi ... -573217954

User avatar
moonbat
Board Warrior
Board Warrior
Posts: 1093
Joined: 2015-12-09, 15:45
Location: Australia

Re: uBlock Origin getting a bit old?

Post by moonbat » 2020-01-12, 02:58

I have noticed that the logger of uBO doesn't show hidden elements anymore (I noticed this only now so possibly been a problem for a lot longer) - when you click the </> icon.

Is this a bug, or some configuration problem?
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Linux Mint 19.3 Xfce x64 on HP i5 laptop with 4 GB RAM, always latest versions of PM & Basilisk unless specified.

User avatar
back2themoon
Board Warrior
Board Warrior
Posts: 1628
Joined: 2012-08-19, 20:32

Re: uBlock Origin getting a bit old?

Post by back2themoon » 2020-01-12, 09:56

Many thanks for your work, guys. Haven't noticed any issues with 1.16.4.14b1.
Safe Mode / clean profile info: Help/Restart in Safe Mode
Information to include when asking for support - How to apply user agent overrides
How to download videos

Windows 10 Pro • Pale Moon x64 • Interlink x64 • Emsisoft Anti-Malware

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-12, 10:58

moonbat wrote:
2020-01-12, 02:58
I have noticed that the logger of uBO doesn't show hidden elements anymore (I noticed this only now so possibly been a problem for a lot longer) - when you click the </> icon.

Is this a bug, or some configuration problem?
I can confirm this issue.
But indeed, it's an older bug, and not related to anything in JustOff's new beta version.

User avatar
moonbat
Board Warrior
Board Warrior
Posts: 1093
Joined: 2015-12-09, 15:45
Location: Australia

Re: uBlock Origin getting a bit old?

Post by moonbat » 2020-01-12, 11:01

Tomaso wrote:
2020-01-12, 10:58
I can confirm this issue.
But indeed, it's an older bug, and not related to anything in JustOff's new beta version.
I was afraid of that..given that this is the legacy version it's probably not going to get fixed.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Linux Mint 19.3 Xfce x64 on HP i5 laptop with 4 GB RAM, always latest versions of PM & Basilisk unless specified.

User avatar
Moonraker
Board Warrior
Board Warrior
Posts: 1262
Joined: 2015-09-30, 23:02
Location: uk.

Re: uBlock Origin getting a bit old?

Post by Moonraker » 2020-01-12, 11:32

moonbat wrote:
2020-01-12, 11:01
Tomaso wrote:
2020-01-12, 10:58
I can confirm this issue.
But indeed, it's an older bug, and not related to anything in JustOff's new beta version.
I was afraid of that..given that this is the legacy version it's probably not going to get fixed.
Judging on how google intend to thwart adblocking in its browser with manifest 3 and no doubt mozilla will follow just to conform,the legacy version might be the only one left standing.
Xenial puppy linux 32-bit.
Tahrpup 6.0.5.32 bit.
Pale moon 28.8.1.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-12, 11:46

Moonraker wrote:
2020-01-12, 11:32
Judging on how google intend to thwart adblocking in its browser with manifest 3 and no doubt mozilla will follow just to conform,the legacy version might be the only one left standing.
Well, Mozilla have been holding their ground, so far:
https://www.ghacks.net/2019/09/03/mozil ... nifest-v3/
..but I suspect Google will come up with some really cunning ploys, which eventually will be forcing them to give in!

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2122
Joined: 2015-09-26, 04:51
Location: U.S.

Re: uBlock Origin getting a bit old?

Post by coffeebreak » 2020-01-12, 12:05

Great thanks to all involved for doing this. So far 1.16.4.14b1 seems to be working fine.


moonbat wrote:
2020-01-12, 02:58
the logger ... - when you click the </> icon.
The DOM Inspector hasn't been available since release of 1.14.20. See 2nd paragraph, under 'Changes'.

User avatar
90Obadiah
Apollo supporter
Apollo supporter
Posts: 30
Joined: 2018-09-22, 08:55

Re: uBlock Origin getting a bit old?

Post by 90Obadiah » 2020-01-12, 14:01

Tomaso wrote:
2020-01-12, 10:58
moonbat wrote:
2020-01-12, 02:58
I have noticed that the logger of uBO doesn't show hidden elements anymore (I noticed this only now so possibly been a problem for a lot longer) - when you click the </> icon.

Is this a bug, or some configuration problem?
I can confirm this issue.
But indeed, it's an older bug, and not related to anything in JustOff's new beta version.
Hopefully someone with a github account would open a new issue here https://github.com/uBlockOrigin/uBlock- ... fox-legacy
Regardless if gorhill want to spend time on this or not, i think it's better if the issue is there open and visible to everyone.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-12, 20:36


User avatar
Konrad
Fanatic
Fanatic
Posts: 113
Joined: 2018-11-17, 18:19

Re: uBlock Origin getting a bit old?

Post by Konrad » 2020-01-13, 04:11

Hats off to JustOff and Tomaso! Thanks a lot for your efforts!

1. JustOff, you say that the converter should exclude rules with a certain syntax. Does it mean that some filters will be canceled/deleted and new filters as substitutions are to be written by a user?

2. AdGuard Russian filter is missing in the regions/languages list. Is it simply an oversight?

3. When opening General filter chit-chat on GitHub with uBO Legacy 1.16.4.14b2 active, github.com is blocked according to the information in the overview panel of the popup UI. The status changes after a couple of minutes or after reloading the page (ctrl + F5). This happens with either EasyPrivacy list or AdGuard Tracking Protection filter being in effect.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-13, 07:29

Konrad wrote:
2020-01-13, 04:11
AdGuard Russian filter is missing in the regions/languages list. Is it simply an oversight?
https://github.com/gorhill/uBlock/commi ... 99d22430ac
Remove "RUS: AdGuard Russian" from stock filter list

As per feedback from maintainers, AdGuard Russian
and RU AdList are incompatible and web site breakage
can occur when both are used together.
--
Konrad wrote:
2020-01-13, 04:11
github.com is blocked according to the information in the overview panel of the popup UI.
Because of the following rules:

Code: Select all

AdGuard Tracking Protection filter:
||api.github.com/_private/browser/stats$important

EasyPrivacy:
||github.com/_private/browser/stats
I don't see this changing.

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1935
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: uBlock Origin getting a bit old?

Post by JustOff » 2020-01-13, 12:08

Konrad wrote:
2020-01-13, 04:11
Does it mean that some filters will be canceled/deleted and new filters as substitutions are to be written by a user?
There are two scriptlets that were recently added to uBlock that are not fully supported by the XUL/legacy version. Currently, there is only one rule that uses their new syntax and the number of such rules is unlikely to increase significantly in the future.
Here are the add-ons I made in a spare time. That was fun!

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin getting a bit old?

Post by Tomaso » 2020-01-14, 13:54

uBO Legacy v1.16.4.14:
https://github.com/gorhill/uBlock/relea ... 1.16.4.14/
Change:
Convert new shorthands back to legacy syntax when fetching filter lists using firefox-legacy (pull request by JustOff)
Of course, for those of you using uBlock Origin Updater, the update should happen automagically! :)

Again, huuuge thanks to DandelionSprout and JustOff!! :clap:

Post Reply