Clear history window sometimes opens incorrectly

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

[bug] Clear History Dialog

Unread post by fatboy » 2019-10-02, 06:36

Good Day Community,

I have come across this bug quite a few times, and it happens at random, and happens when I click on the show history button and select clear recent history. See below. This happens mostly on Windows and occasionally on Linux.
Basilisk_Clear_History.JPG
Systemd Free - MX Linux, Antix Linux & Artix Linux

Nixal

Clear history window sometimes opens incorrectly

Unread post by Nixal » 2019-10-02, 19:21

This is on Pale Moon 28.7.1 32-bit but I have experienced it on several prior versions, on Windows 7 Professional 64-bit.

Sometimes when trying to clear history the window opens like this. It opens correctly most of the time, but occasionally does this. It's a minor issue, as all I have to do is simply close the window and try to open it again, and it will open correctly. Weird behavior anyway. Maybe it's because of the theme I'm using.
Clear history.jpg

User avatar
Nigaikaze
Board Warrior
Board Warrior
Posts: 1322
Joined: 2014-02-02, 22:15
Location: Chicagoland

Re: Clear history window sometimes opens incorrectly

Unread post by Nigaikaze » 2019-10-02, 19:55

Nixal wrote:
2019-10-02, 19:21
Maybe it's because of the theme I'm using.
Which is ... ?
Nichi nichi kore ko jitsu = Every day is a good day.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: [bug] Clear History Dialog

Unread post by coffeebreak » 2019-10-02, 20:59

Someone just reported a similar problem with Pale Moon.

What happens in safe mode?
What theme do you use when this occurs, and does the issue persist if it's disabled?

User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

Re: [bug] Clear History Dialog

Unread post by fatboy » 2019-10-03, 06:38

Using the default theme in Basilisk. This just happened again.

I'll launch safe mode later and see if the issue persists. This bug generally appears randomly, so far as I can tell.
Systemd Free - MX Linux, Antix Linux & Artix Linux

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Clear history window sometimes opens incorrectly

Unread post by Moonchild » 2019-10-03, 11:38

Also check the browser/error console when this happens.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: [bug] Clear History Dialog

Unread post by Moonchild » 2019-10-03, 11:40

Check the browser's error console when this occurs.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Clear history window sometimes opens incorrectly

Unread post by loxodont » 2019-10-09, 11:00

Happened a very few times for me, mostly on my old Linux/Win7 notebook and just after launching the browser. I couldn't check it in the error console yet, as it actually didn't happen again. My guess is rather a micro hang, as it seemed to occur in a rather "busy state" of the OS or browser getting other things done. On that slow notebook it takes, for example, a few milliseconds to load the custom theme created with Theme Maker, so standard GUI elements sometimes pop up in a row; may be this affects opening the full Clear History window as well.
Anyway, it opened always correctly on 2nd try, like OP said.

User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

Re: Clear history window sometimes opens incorrectly

Unread post by fatboy » 2019-10-10, 06:36

I also reported this issue

viewtopic.php?f=61&t=23045
Systemd Free - MX Linux, Antix Linux & Artix Linux

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Clear history window sometimes opens incorrectly

Unread post by loxodont » 2019-10-10, 11:43

Luckily it now happened on my big machine (Win7-x32, Pale Moon 28.7.1) so I could take a look in the error console.
I don't understand it, but this is what it said.
pm2871-clearhistory-snap7988-10-10-2019 12-30c.jpg
edit: The exact same result was shown in the "All" view - nothing else.
Last edited by loxodont on 2019-10-10, 11:48, edited 1 time in total.

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 4942
Joined: 2015-12-09, 15:45
Contact:

Re: Clear history window sometimes opens incorrectly

Unread post by moonbat » 2019-10-10, 11:47

loxodont wrote:
2019-10-10, 11:43
Luckily it now happened on my big machine (Win7-x32, Pale Moon 28.7.1) so I could take a look in the error console.
I don't understand it, but this is what it said.

pm2871-clearhistory-snap7988-10-10-2019 12-30c.jpg
Seems to be from an extension called Listit or List it.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 21 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Clear history window sometimes opens incorrectly

Unread post by loxodont » 2019-10-10, 11:57

I use the "List This!"extension, but its icon lives right down in the Status Bar. I could disable it, but this "bug" is so rare, how and when would I know if it's caused by this extension :scratch head:

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 4942
Joined: 2015-12-09, 15:45
Contact:

Re: Clear history window sometimes opens incorrectly

Unread post by moonbat » 2019-10-10, 12:14

I mean, those console messages are to do with List this and not the problem you're facing. Besides, it's a deprecation warning asking the developer to code in a different way, doesn't mean it doesn't work currently.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 21 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Clear history window sometimes opens incorrectly

Unread post by loxodont » 2019-10-10, 12:17

OK, thx ... couldn't imagine it has something to do with "List This!" anyway

User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

Re: [bug] Clear History Dialog

Unread post by fatboy » 2019-10-12, 19:08

Experienced this bug on Linux as well.
Screenshot from 2019-10-12 21-05-08.png
Screenshot from 2019-10-12 21-05-34.png

Code: Select all


        Components.utils.reportError("Warning: unrecognized command line flag " + curarg + "\n");
        // To emulate the pre-nsICommandLine behavior, we ignore
        // the argument after an unrecognized flag.
        ++i;
      } else {
        try {
          urilist.push(resolveURIInternal(cmdLine, curarg));
        }
        catch (e) {
          Components.utils.reportError("Error opening URI '" + curarg + "' from the command line: " + e + "\n");
        }
      }
    }

    if (urilist.length) {
      if (cmdLine.state != nsICommandLine.STATE_INITIAL_LAUNCH &&
          urilist.length == 1) {
        // Try to find an existing window and load our URI into the
        // current tab, new tab, or new window as prefs determine.
        try {
          handURIToExistingBrowser(urilist[0], nsIBrowserDOMWindow.OPEN_DEFAULTWINDOW, cmdLine);
          return;
        }
        catch (e) {
        }
      }

      var URLlist = urilist.filter(shouldLoadURI).map(function (u) u.spec);
      if (URLlist.length) {
        openWindow(null, gBrowserContentHandler.chromeURL, "_blank",
                   "chrome,dialog=no,all" + gBrowserContentHandler.getFeatures(cmdLine),
                   URLlist);
      }

    }
    else if (!cmdLine.preventDefault) {
      // Passing defaultArgs, so use NO_EXTERNAL_URIS
      openWindow(null, gBrowserContentHandler.chromeURL, "_blank",
                 "chrome,dialog=no,all" + gBrowserContentHandler.getFeatures(cmdLine),
                 gBrowserContentHandler.defaultArgs, NO_EXTERNAL_URIS);
    }
  },

  helpInfo : "",
};

var components = [nsBrowserContentHandler, nsDefaultCommandLineHandler];
this.NSGetFactory = XPCOMUtils.generateNSGetFactory(components);

Systemd Free - MX Linux, Antix Linux & Artix Linux

User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

Re: [bug] Clear History Dialog

Unread post by fatboy » 2019-10-15, 18:10

Got the same error in Palemoon
Palemoon_Bug.png
palemoon_error_2.png
Systemd Free - MX Linux, Antix Linux & Artix Linux

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: [bug] Clear History Dialog

Unread post by Moonchild » 2019-10-15, 23:51

Well the console output doesn't show anything directly related at least in the visible part. The error you pointed out is because you're using a wrong command-line option (probably in your shortcut).

I also haven't been able to reproduce it, at all, on my system. I've tried calling up the dialog as quickly as possible after start (since it was said that it was especially a problem on slow hardware) but even that always presented me with the proper and populated dialog. This makes troubleshooting hard to do.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Clear history window sometimes opens incorrectly

Unread post by Moonchild » 2019-10-15, 23:56

Merged both threads here since it's clearly about one and the same issue.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
fatboy
Astronaut
Astronaut
Posts: 556
Joined: 2017-12-19, 08:03
Location: Canada

Re: Clear history window sometimes opens incorrectly

Unread post by fatboy » 2019-10-16, 10:07

U get this error if I use the keybinding and also the show your history icon. On both Palemoon and Basilisk, on Linux and Windows.
Could it be that an addon is inducing this error? One that is suppose to clear history? nMatrix or Cookies Autodelete?
Systemd Free - MX Linux, Antix Linux & Artix Linux

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Clear history window sometimes opens incorrectly

Unread post by Moonchild » 2019-10-16, 10:25

fatboy wrote:
2019-10-16, 10:07
U get this error if I use the keybinding and also the show your history icon. On both Palemoon and Basilisk, on Linux and Windows.
Could it be that an addon is inducing this error? One that is suppose to clear history? nMatrix or Cookies Autodelete?
I've been using the keybind, Can't reproduce.
And it's quite possible an add-on is interfering, yes. A dialog coming up blank like that is usually because there are definitions mission for the XUL (e.g. strings/labels). If something injects itself there, and its initialization of strings is too slow or lazy-loaded, then it can cause an issue making the XUL invalid and not rendering. That would also be the kind of situation where it would come up just fine a second time.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked