Need help to fix the uBlock Origin logger
Moderators: FranklinDM, Lootyhoof
Need help to fix the uBlock Origin logger
gorhill has declined to fix this issue in uBO Legacy:
https://github.com/uBlockOrigin/uBlock- ... ssues/385/
..but points out that "pull requests are welcomed".
Anyone feel up to the task?
https://github.com/uBlockOrigin/uBlock- ... ssues/385/
..but points out that "pull requests are welcomed".
Anyone feel up to the task?
Last edited by Moonchild on 2019-01-20, 06:49, edited 2 times in total.
Reason: Topic clarification
Reason: Topic clarification
Re: uBlock Origin
Off-topic:
Please use more specific topic titles, i.e. "Need help to fix the uBlock Origin logger" instead of just "uBlock Origin".
Please use more specific topic titles, i.e. "Need help to fix the uBlock Origin logger" instead of just "uBlock Origin".
Re: uBlock Origin
I want to help.
checked with rule ##iframe[src*="annonse"]
https://www.dagbladet.no/annonse/70179055/
And did not get what that rule do actually, see no difference.
Me was used only || and @@ type rules.
checked with rule ##iframe[src*="annonse"]
https://www.dagbladet.no/annonse/70179055/
And did not get what that rule do actually, see no difference.
Me was used only || and @@ type rules.
Re: uBlock Origin
The other generic "uBlock Origin" thread has been locked, so I figured it would be a good idea to start a new one.JustOff wrote:Off-topic:
Please use more specific topic titles, i.e. "Need help to fix the uBlock Origin logger" instead of just "uBlock Origin".
--
Try this one instead then:Fedor2 wrote:checked with rule ##iframe[src*="annonse"]
https://www.dagbladet.no/annonse/70179055/
And did not get what that rule do actually, see no difference.
Code: Select all
###cookie:not(body):not(html):not([href*="cookieclicker"])
Perhaps it's more apparent, at your end.
Re: Need help to fix the uBlock Origin logger
See no difference either, so i consider that type rules maybe for newer ublock only.
Can you just tell what is it to change or block?
update:
According https://kb.adguard.com/en/general/how-t ... les-syntax
### is hiding an element, does it mean that it hide the cookie and all? what is the point?
update2:
Made test page with test div id element but the rule hides nothing... but do hide on the basilisk with ublock 17.4.
Conclusion:
To show in the logger at first the rule handler is to be ported from the newer version.
Can you just tell what is it to change or block?
update:
According https://kb.adguard.com/en/general/how-t ... les-syntax
### is hiding an element, does it mean that it hide the cookie and all? what is the point?
update2:
Made test page with test div id element but the rule hides nothing... but do hide on the basilisk with ublock 17.4.
Conclusion:
To show in the logger at first the rule handler is to be ported from the newer version.
Re: Need help to fix the uBlock Origin logger
Don't know why you aren't seeing it, because both of them should be very easy to spot!
Example #1:
At https://www.acronis.com/en-us/support/contact-us/, the following rule blocks the support modules:
Screenshot:
Example #2:
At https://www.dagbladet.no/annonse/70179055/, the following rule blocks the embeded video:
Screenshot:
Neither one of these rules shows up in uBO Legacy's logger.
Example #1:
At https://www.acronis.com/en-us/support/contact-us/, the following rule blocks the support modules:
Code: Select all
###cookie:not(body):not(html):not([href*="cookieclicker"])
Example #2:
At https://www.dagbladet.no/annonse/70179055/, the following rule blocks the embeded video:
Code: Select all
##iframe[src*="annonse"]
Neither one of these rules shows up in uBO Legacy's logger.
Re: Need help to fix the uBlock Origin logger
This i get already, rule must hide those things, but it does not work, nothing is hidden, even with all other addons disabled. Does it works for you?
Re: Need help to fix the uBlock Origin logger
Yes, it works just fine.
Pehaps you've accidentally disabled cosmetic filtering or something?
('Dashboard' > 'Settings' > 'Default behavior' > "Disable cosmetic filtering")
Pehaps you've accidentally disabled cosmetic filtering or something?
('Dashboard' > 'Settings' > 'Default behavior' > "Disable cosmetic filtering")
Re: Need help to fix the uBlock Origin logger
Well i got this fixed, your rules both show properly and nothing wrong is happens.
But i do not fully understand that stuff, and shall be making request to gorhill.
But i do not fully understand that stuff, and shall be making request to gorhill.
Re: Need help to fix the uBlock Origin logger
Yes, I noticed your post @ GitHub.
Great work! :)
Awaiting gorhill's response.
Great work! :)
Awaiting gorhill's response.
Re: Need help to fix the uBlock Origin logger
Somehow I doubt Gorhill will be wanting to do anything specific for us at this point, especially considering he's painting us black on Reddit apparently about "not giving credit for Mozilla patches" -- while the truth of the matter is that our patches are merely based on the work Mozilla does, and code is kept similar on purpose (e.g. variable names) for future code comparisons, but they are written specifically for UXP (and if not, patches applied will have the Mozilla authorship data on them).
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: Need help to fix the uBlock Origin logger
Are we *gulp* stealing code from Mozilla again? Oh no, we must stop at once!
Re: Need help to fix the uBlock Origin logger
Off-topic:
I have a hard time believing that Moonchild would have made such an egregious mistake in fulfilling the obligations of the MPL 2.0 license (or any other license), or that if such a mistake had been made, that it would not be properly rectified in a timely fashion.
I have a hard time believing that Moonchild would have made such an egregious mistake in fulfilling the obligations of the MPL 2.0 license (or any other license), or that if such a mistake had been made, that it would not be properly rectified in a timely fashion.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story
-
- Moon Magic practitioner
- Posts: 2986
- Joined: 2015-09-26, 04:51
- Location: U.S.
Re: Need help to fix the uBlock Origin logger
Off-topic:
Link to gorhill's Reddit post, so people can read it directly:
https://www.reddit.com/r/firefox/comments/ai95us/basilisk_browser_drops_webextension_support/een8fr0/
Respectfully, there is no basis to connect gorhill's opinions on Pale Moon patch attribution with his response to an issue a user raises in the legacy branch of uBO. I have never seen a sign that he makes decisions in that manner, but rather decides based on particulars of each issue.
If you want to respond to what was posted, why not do that directly in Reddit?
Or in the alternative, make a blog post?
But in any case, please consider to leave this support thread in peace to deal purely with the logger issue raised.
Moonchild wrote:Somehow I doubt Gorhill will be wanting to do anything specific for us at this point, especially considering he's painting us black on Reddit apparently about "not giving credit for Mozilla patches"
Link to gorhill's Reddit post, so people can read it directly:
https://www.reddit.com/r/firefox/comments/ai95us/basilisk_browser_drops_webextension_support/een8fr0/
Respectfully, there is no basis to connect gorhill's opinions on Pale Moon patch attribution with his response to an issue a user raises in the legacy branch of uBO. I have never seen a sign that he makes decisions in that manner, but rather decides based on particulars of each issue.
If you want to respond to what was posted, why not do that directly in Reddit?
Or in the alternative, make a blog post?
But in any case, please consider to leave this support thread in peace to deal purely with the logger issue raised.
Re: Need help to fix the uBlock Origin logger
If someone does, please stick to facts, and avoid flaming the situation.coffeebreak wrote:If you want to respond to what was posted, why not do that directly in Reddit?
I fear that a heated discussion only will serve to hurt us so-called "legacy" users even further.
Re: Need help to fix the uBlock Origin logger
Off-topic:
If patches would apply directly, I have to the best of my knowledge also always retained the original authorship mention of those patches. See the smattering of names mentioned on github as commit contributors.
As always, too, if someone wants to be credited who isn't yet credited as a contributor, they only have to ask.
I think what some people are disgruntled about is that I don't tend to retain Bugzilla bug numbers since they do not apply to our own bug tracking, and in the case of sec bugs I additionally don't see a reason to paint a bulls-eye on a potential problem either if linked to a bug that requires sec authorization to view.
For the record, there is no attribution clause in the MPL 2.0 that requires all sources of research for patches written OR for patches themselves be credited. I'm also pretty sure that everyone committing the patches to Mozilla that were used to create our patches are already mentioned as authors to the Mozilla code (also in our tree, see the authors file).Isengrim wrote:I have a hard time believing that Moonchild would have made such an egregious mistake in fulfilling the obligations of the MPL 2.0 license (or any other license), or that if such a mistake had been made, that it would not be properly rectified in a timely fashion.
If patches would apply directly, I have to the best of my knowledge also always retained the original authorship mention of those patches. See the smattering of names mentioned on github as commit contributors.
As always, too, if someone wants to be credited who isn't yet credited as a contributor, they only have to ask.
I think what some people are disgruntled about is that I don't tend to retain Bugzilla bug numbers since they do not apply to our own bug tracking, and in the case of sec bugs I additionally don't see a reason to paint a bulls-eye on a potential problem either if linked to a bug that requires sec authorization to view.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: Need help to fix the uBlock Origin logger
Why are you cross-posting.. This isn't a thing that is allowed since Mozillazine.. Please stop.
MODERATOR: Please clean this up.
MODERATOR: Please clean this up.
Re: Need help to fix the uBlock Origin logger
Crossposts removed, warning issued.
Did you know that moral outrage triggers the pleasure centers of the brain? It's unlikely you can actually get addicted to outrage, but there is plausible evidence that you can become strongly predisposed to it.
Source: https://www.bbc.co.uk/programmes/p002w557/episodes/downloads - "The cooperative species" and "Behaving better online"
Source: https://www.bbc.co.uk/programmes/p002w557/episodes/downloads - "The cooperative species" and "Behaving better online"