When flex-box full support is planned?

Board for discussions around the Basilisk web browser.

Moderator: Basilisk-Dev

bitairy

When flex-box full support is planned?

Unread post by bitairy » 2018-09-26, 19:41

Hello,
I found that the latest 2018.09.05 (64-bit) Basilisk browser does not show the part of the html page in which the flex-box is used. (flex-wrap: wrap;)
I would like to know when you plan to do support flex-box in the browser
Thanks.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35477
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: When flex-box full support is planned?

Unread post by Moonchild » 2018-09-26, 21:25

Flexboxes are (and have been) fully supported in Basilisk.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

bitairy

Re: When flex-box full support is planned?

Unread post by bitairy » 2018-09-27, 04:27

Please compare how the same code is displayed by different browsers https://jsfiddle.net/to73wyfs/
Chrome and the latest Firefox show the flexboxes on the page under the text "Flexbox below" and Basilisk no.
Thanks.

adisib
Lunatic
Lunatic
Posts: 380
Joined: 2015-06-13, 03:34
Location: KY

Re: When flex-box full support is planned?

Unread post by adisib » 2018-09-27, 05:08

It isn't a flexbox issue. It is a javascript issue with that website.

The website throws a syntax error for the following snippet:

Code: Select all

ChoosedPlan.prototype.emit = function({title, ...data}) {
        this.title.innerHTML = `<span style="color: #2196f3">You chose </span>${title}`;
        this.data = data;
        this.render(data);
    }
UXP doesn't support spread properties for object literals, which is part of a proposal. See:
https://github.com/tc39/proposal-object-rest-spread
(Edit: This was added in Firefox 55)
Last edited by adisib on 2018-09-27, 05:11, edited 3 times in total.

bitairy

Re: When flex-box full support is planned?

Unread post by bitairy » 2018-09-27, 05:26

Most likely this is the problem of only one site, but still I would like Basilisk to remain the best and show any pages if this possible.
Perhaps in the next Basilisk builds, there will not be such a problem.

Thank you for your explanations. :thumbup:

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35477
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: When flex-box full support is planned?

Unread post by Moonchild » 2018-09-27, 06:17

It is a draft proposal. We will stick to standards first, and so should websites.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Sajadi
Board Warrior
Board Warrior
Posts: 1226
Joined: 2013-04-19, 00:46

Re: When flex-box full support is planned?

Unread post by Sajadi » 2018-09-27, 08:45

bitairy wrote:Most likely this is the problem of only one site, but still I would like Basilisk to remain the best and show any pages if this possible.
Perhaps in the next Basilisk builds, there will not be such a problem.

Thank you for your explanations. :thumbup:
Something which should not be forgotten - As this is partly a community based browser project, i am pretty sure Moonchild would be happy about people who submit patches for features they want. So, if you want to have that in Basilisk - either create a pach on your own or find someone who can implement it for you!

For example - you could visit some coding related boards on the web and get some help/hints there which pushes you on the right track for where to start :)
Last edited by Sajadi on 2018-09-27, 08:57, edited 6 times in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35477
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: When flex-box full support is planned?

Unread post by Moonchild » 2018-10-01, 08:38

Created Issue #802 (UXP) to track this enhancement. Patches are indeed welcome; it doesn't seem to have too many dependencies on other code so should be fairly straightforward to implement.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked