Greetings,
I finally got around finding a little time to compile and try PM 28. Among all the extensions I am using, one (a pure little jewel that I could simply not do without so much I use it) is totally broken: Custom Buttons.
The issue seems to be related with the __defineGetter__ JavaScript function.
Here is what shows in the console:
PM 28.0.0b2 breaks CustomButtons Topic is solved
PM 28.0.0b2 breaks CustomButtons
Last edited by dinosaur on 2018-07-05, 15:15, edited 1 time in total.
Re: PM 28.0.0b2 breaks CustomButtons
__defineGetter__ vs. this.__defineGetter__
__defineSetter__ vs. this.__defineSetter__
See also viewtopic.php?f=63&p=142327#p142327
__defineSetter__ vs. this.__defineSetter__
See also viewtopic.php?f=63&p=142327#p142327
Re: PM 28.0.0b2 breaks CustomButtons
Try to install custom_buttons-0.0.5.8.9-fixed8.xpi (or earlier "fixed" versions from the linked forum), and don't forget that the buttons you are using with it must also be compatible.
Last edited by JustOff on 2018-07-05, 16:18, edited 1 time in total.
Re: PM 28.0.0b2 breaks CustomButtons
To quote the relevant tidbit for extension devs:
"Previously, the __defineGetter__ and __defineSetter__ methods could be called at the global scope without any object, because the global object was automatically used in such cases. As part of ECMAScript 2016 compliance, Pale Moon 28 and later no longer support the legacy behavior and throw a TypeError instead. The workaround here is to explicitly use the this keyword, like this.__defineGetter__ or this.__defineSetter__."
"Previously, the __defineGetter__ and __defineSetter__ methods could be called at the global scope without any object, because the global object was automatically used in such cases. As part of ECMAScript 2016 compliance, Pale Moon 28 and later no longer support the legacy behavior and throw a TypeError instead. The workaround here is to explicitly use the this keyword, like this.__defineGetter__ or this.__defineSetter__."
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: PM 28.0.0b2 breaks CustomButtons
Or, you can try CB3 by srazzano with some improvements(GUI tabs).
Re: PM 28.0.0b2 breaks CustomButtons
Thank you folks ! The fixed versions do work fine.
(posted with PM 28.0.0b2)
(posted with PM 28.0.0b2)