Wrong positioning of Private window indicator
Moderator: dbsoft
Forum rules
Important note:
The old Mac OS versions of Pale Moon were provided by various people and not official or in any way organized. Please make sure you check the date of topic threads to know if the topic is current or relevant! We are using this board for both old discussions and new development of Pale Moon on Mac.
Any specific bugs you find that don't have their own topic yet: please make a new topic; one bug per topic please to keep things organized.
Important note:
The old Mac OS versions of Pale Moon were provided by various people and not official or in any way organized. Please make sure you check the date of topic threads to know if the topic is current or relevant! We are using this board for both old discussions and new development of Pale Moon on Mac.
Any specific bugs you find that don't have their own topic yet: please make a new topic; one bug per topic please to keep things organized.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Wrong positioning of Private window indicator
On Mac OS, positioning of private window icon is where a website's favicon is normally displayed alongside page title in a tab. If I open a website in this tab, obviously private window icon gets replaced with the site icon and now there is no indication of the private browsing in the browser window.
You do not have the required permissions to view the files attached to this post.
Last edited by adesh on 2018-03-29, 09:28, edited 1 time in total.
Re: Wrong positioning of Private window indicator
Where did this build come from.. There are NO authorized branded builds for macintosh.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
I created this build myself to test how Pale Moon behaves on a Mac.
Tried it with sugis' build (yes, unofficial) also and result is the same.
Tried it with sugis' build (yes, unofficial) also and result is the same.
-
- Fanatic
- Posts: 173
- Joined: 2018-03-26, 04:47
- Location: Wisconsin, USA
Re: Wrong positioning of Private window indicator
Hmm, i have an indicator on 10.6.8 if i open a private window. FYI i'm using the XMoon theme just in case its a default theme issue.
You do not have the required permissions to view the files attached to this post.
Last edited by wicknix on 2018-04-02, 03:43, edited 1 time in total.
Silence is golden, but duct tape is silver...
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
I tried hacking some files in "browser" directory and a rebuild but could not get it to display like on Windows and Linux.
Thanks wicknix for your report! This is indeed a default theme issue. I get the same result as you when using XMoon theme.
Now, I probably need to look at XMoon theme code and port the fix to the default one.
Thanks wicknix for your report! This is indeed a default theme issue. I get the same result as you when using XMoon theme.
Now, I probably need to look at XMoon theme code and port the fix to the default one.
Last edited by adesh on 2018-04-02, 08:15, edited 1 time in total.
-
- Astronaut
- Posts: 535
- Joined: 2017-09-24, 16:35
- Location: Mak pupulusšum, California
Re: Wrong positioning of Private window indicator
For the record, Issue #553 (UXP) was opened for this, and fixed for Pale Moon 28.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
Sadly it still does not show it for me. Below is the private window, launched with ./mach run (did clobber first). "Private Browsing" is in window title, but NO icon.
One improvement is that now caption buttons are available in private window.
UPDATE:
Caption buttons are only available in non-maximized window. No PB mode indicator. I am using latest mac os. High Sierra fully updated.
Caption buttons are only available in non-maximized window. No PB mode indicator. I am using latest mac os. High Sierra fully updated.
You do not have the required permissions to view the files attached to this post.
Last edited by adesh on 2018-08-02, 11:07, edited 2 times in total.
-
- Astronaut
- Posts: 535
- Joined: 2017-09-24, 16:35
- Location: Mak pupulusšum, California
Re: Wrong positioning of Private window indicator
o_0adesh wrote:Sadly it still does not show it for me. Below is the private window, launched with ./mach run (did clobber first). "Private Browsing" is in window title, but NO icon.
Screen Shot 2018-08-02 at 12.06.28 PM.png
One improvement is that now caption buttons are available in private window.
Screen Shot 2018-08-02 at 12.26.31 PM.png
I'm a little confused, because I'm sure it was fixed, and also neither of your screenshots show the caption buttons you say are there (as they should be).
I just pulled the latest commit from the UXP repo, clobbered, and built to check again. I am on macOS "Sierra" 10.12.6.
You do not have the required permissions to view the files attached to this post.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
Just updated my previous post - caption buttons are not available in maximized window. No PB indicator, whatever the window size.
-
- Astronaut
- Posts: 535
- Joined: 2017-09-24, 16:35
- Location: Mak pupulusšum, California
Re: Wrong positioning of Private window indicator
I also just built on 10.9, the Private Browsing indicator is still there. Interestingly, though, on my 10.9 machine, maximizing the window makes the caption buttons disappear, and the resizing arrows at the top-right of the window (no longer exist in more recent macOS versions) seems to shift up so only the bottom of one arrow is visible. Perhaps on certain computers, a maximized window shifts things in the titlebar up and out of view....
In the middle of your now three screenshots, what is that mysterious blurry purple blob that seems to be right where the purple indicator should be?
And in your other screenshots, it looks like the titlebar has -moz-appearance: -moz-window-titlebar, which it shouldn't.
In the middle of your now three screenshots, what is that mysterious blurry purple blob that seems to be right where the purple indicator should be?
And in your other screenshots, it looks like the titlebar has -moz-appearance: -moz-window-titlebar, which it shouldn't.
-
- Astronaut
- Posts: 535
- Joined: 2017-09-24, 16:35
- Location: Mak pupulusšum, California
Re: Wrong positioning of Private window indicator
Correction/clarification:
On OS X 10.9, clicking the green caption button expands the window to take up the full width and height that it could be resized to (not overlapping the dock and keeping visible the toolbar along the top of the screen and the window titlebar), and clicking the arrows in the top-right corner of the window puts it in fullscreen. In proper fullscreen, there are no caption buttons (fullscreen can be exited by moving the mouse to the top of the screen and then clicking the arrows in the top-right). This is expected on this version of OS X and in line with e.g. Safari. In more recent versions of macOS, including 10.12, the fullscreen arrows are not present and clicking the green caption button enters fullscreen, wherein placing the mouse at the top of the window brings down a titlebar with caption buttons.
What is not expected, but I notice happening, is that when a Private Browsing window is expanded to full size (but not fullscreen), either by dragging its edges or pressing the green caption button on 10.9, the caption buttons disappear. On 10.9 I can see the bottom edge of the fullscreen arrows, and on 10.12 I can see the very bottoms of the caption buttons. So when the window is expanded to full size, these items are shifted up and mostly out of view. With a lightweight theme installed (Private window or not), expanding the window like this does the same thing.
I also noticed that in fullscreen, the Private Browsing indicator is missing. In pre-Australis Firefox, it is present (though farther towards the edge of the screen than when not in fullscreen), so I must have overlooked something when I restored it. EDIT: With tabs on the bottom, toolbar items take up the space the indicator would be in in fullscreen. I just chatted with Moonchild and Tobin and found out that other platforms don't indicate Private Browsing while in fullscreen, so this will not be fixed.
Thank you for getting me to look at this again, because thereare someis at least one problems that I apparently overlookedwas not aware of. However, I still do not understand why the Private Browsing indicator apparently always fails to appear for you, or why your titlebar looks the way it does in a Private window. Maybe the CSS just isn't applying on High Sierra?
On OS X 10.9, clicking the green caption button expands the window to take up the full width and height that it could be resized to (not overlapping the dock and keeping visible the toolbar along the top of the screen and the window titlebar), and clicking the arrows in the top-right corner of the window puts it in fullscreen. In proper fullscreen, there are no caption buttons (fullscreen can be exited by moving the mouse to the top of the screen and then clicking the arrows in the top-right). This is expected on this version of OS X and in line with e.g. Safari. In more recent versions of macOS, including 10.12, the fullscreen arrows are not present and clicking the green caption button enters fullscreen, wherein placing the mouse at the top of the window brings down a titlebar with caption buttons.
What is not expected, but I notice happening, is that when a Private Browsing window is expanded to full size (but not fullscreen), either by dragging its edges or pressing the green caption button on 10.9, the caption buttons disappear. On 10.9 I can see the bottom edge of the fullscreen arrows, and on 10.12 I can see the very bottoms of the caption buttons. So when the window is expanded to full size, these items are shifted up and mostly out of view. With a lightweight theme installed (Private window or not), expanding the window like this does the same thing.
I also noticed that in fullscreen, the Private Browsing indicator is missing. In pre-Australis Firefox, it is present (though farther towards the edge of the screen than when not in fullscreen), so I must have overlooked something when I restored it. EDIT: With tabs on the bottom, toolbar items take up the space the indicator would be in in fullscreen. I just chatted with Moonchild and Tobin and found out that other platforms don't indicate Private Browsing while in fullscreen, so this will not be fixed.
Thank you for getting me to look at this again, because there
Last edited by SpockFan02 on 2018-08-03, 09:21, edited 1 time in total.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
Just an update to say that private window indicator is visible after building my NewMoon with 10.12 sdk. This issue is now resolved for me.
It seems 10.13 (high sierra) sdk does not play well with Pale Moon codebase. So I'd suggest that if ever there is an official release of Pale Moon for Mac, it should be built with 10.12 sdk (or lower).
It seems 10.13 (high sierra) sdk does not play well with Pale Moon codebase. So I'd suggest that if ever there is an official release of Pale Moon for Mac, it should be built with 10.12 sdk (or lower).
Last edited by adesh on 2018-12-21, 17:20, edited 2 times in total.
-
- Fanatic
- Posts: 173
- Joined: 2018-03-26, 04:47
- Location: Wisconsin, USA
Re: Wrong positioning of Private window indicator
Good to know. I had a suspicion that the newer macosx/sdk's might be problematic eventually as macos gears itself more towards iOS.
Cheers.
Cheers.
Silence is golden, but duct tape is silver...
Re: Wrong positioning of Private window indicator
Which SDK is used currently to make the macOS builds? I still have this issue on Mojave, although the controls are slightly visible.
You do not have the required permissions to view the files attached to this post.
-
- Board Warrior
- Posts: 1277
- Joined: 2017-06-06, 07:38
Re: Wrong positioning of Private window indicator
There are no official Mac builds available. Which build are you talking about?
For fixing issue with your own build see my post above. ^^
For fixing issue with your own build see my post above. ^^
Re: Wrong positioning of Private window indicator
I'm talking about the unofficial macOS builds kindly provided by wicknix:
viewtopic.php?f=41&t=21770
If only the SDK update can solve this, then never mind
viewtopic.php?f=41&t=21770
If only the SDK update can solve this, then never mind
-
- Fanatic
- Posts: 173
- Joined: 2018-03-26, 04:47
- Location: Wisconsin, USA
Re: Wrong positioning of Private window indicator
Try resizing the window just a hair and see if they come back. There is a small glitch yet when the window is maximized where they disappear. Making the window 1/8th inch smaller makes them come back. Let me know if this is the case for you as well.
Cheers
Cheers
Silence is golden, but duct tape is silver...
Re: Wrong positioning of Private window indicator
I can't try this right now, but from the top of my head making the window smaller did bring the controls back. Double clicking the title to de-maximize it definitely made the controls visible again.