Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Dedicated board for extension releases/support threads

Moderators: FranklinDM, Lootyhoof

Forum rules
Please do not create new topics here unless you are an extension author in need of a dedicated releases&support thread!
User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-04-10, 23:49

Restore Tabs Button allows you to restore closed tabs via a toolbar button or the right-click context menu. This add-on is forked from Undo Closed Tabs Button Firefox extension.

All of code and files here are licensed under Mozilla Public License (MPL) version 2.0 like original code. Icons used in this add-on are derived and modified by me from Nuvola Icon Set used in this extension is a creation of David Vignoni and GNU LGPLv.2.1 licensed.

Source code and released 1.0 version can be found here: Github Page

After users test, I'll add it to Pale Moon Add-ons site.

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-04-11, 08:23

I had to change code license to MPLv2.0 because original source code is licensed under MPLv2.0. I updated released xpi according to this change and added relevant license text into add-on.

User avatar
billmcct
Keeps coming back
Keeps coming back
Posts: 951
Joined: 2012-09-04, 15:19
Location: Costa Rica & Union City Georgia USA

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by billmcct » 2021-04-12, 11:38

This function is also built into "Tab Utilities Phoenix 2.1.0".
I would also assume that it may be in "Tab Mix" too since they are very similar.
Undo closed.jpg
--------------------------------------------------------------------------------------------------------------
The difference between the Impossible and the Possible lies in a man's Determination.
Tommy Lasorda

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 4942
Joined: 2015-12-09, 15:45
Contact:

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by moonbat » 2021-04-12, 11:52

Tab Mix Plus has everything you could think of with regard to tabs and then some, better to use that than a dozen separate extensions for every tab related function you want to do. Better check its abilities first before looking at any other tab related extension.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 21 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

New Tobin Paradigm

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by New Tobin Paradigm » 2021-04-12, 12:00

TabMixPlus is also known since its creation to cause minor UI glitches and not play well with other extensions. That is just the nature of the beast and boy howdy is it a beast. Perhaps one of the earliest complex Firefox extensions and certainly one of the oldest to be sure with its original AMO ID of 1122.

I offer no judgement to some of the snags that can happen with it.

On another topic.. billmcct you seem to be quite the scumbag criminal given all the torrents of copyrighted intellectual property. I am gonna harass you now about it on a regular basis. Just so you know. I might even contact the authorities. Fun times Atlanta boy!

User avatar
billmcct
Keeps coming back
Keeps coming back
Posts: 951
Joined: 2012-09-04, 15:19
Location: Costa Rica & Union City Georgia USA

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by billmcct » 2021-04-12, 12:09

Hey it's easier for me to find things I want to see by reading the info on those sites and IMDB. Afterwards I can find them on my ROKU with voice commands and watch them. At my age, I need easier.
--------------------------------------------------------------------------------------------------------------
The difference between the Impossible and the Possible lies in a man's Determination.
Tommy Lasorda

New Tobin Paradigm

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by New Tobin Paradigm » 2021-04-12, 12:13

I am gonna have to call bullshit on that, scumbag.

User avatar
billmcct
Keeps coming back
Keeps coming back
Posts: 951
Joined: 2012-09-04, 15:19
Location: Costa Rica & Union City Georgia USA

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by billmcct » 2021-04-12, 12:34

You can call it what you want, but it is what it is.
--------------------------------------------------------------------------------------------------------------
The difference between the Impossible and the Possible lies in a man's Determination.
Tommy Lasorda

User avatar
billmcct
Keeps coming back
Keeps coming back
Posts: 951
Joined: 2012-09-04, 15:19
Location: Costa Rica & Union City Georgia USA

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by billmcct » 2021-04-12, 13:22

Off-topic:
I wonder where this would have led if all the sites in the history were porno sites.
Last edited by Admin on 2021-04-20, 10:35, edited 1 time in total.
Reason: tagged properly.
--------------------------------------------------------------------------------------------------------------
The difference between the Impossible and the Possible lies in a man's Determination.
Tommy Lasorda

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-04-12, 16:05

Guys, I don't understand what's going on here. But while there are other tab related add-ons which have same function, did you think that not everyone want to use those more complex add-ons? This add-on only does what it's name suggests, nothing more. Do you think that it's harmful for Pale Moon or community to working on this?

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 4942
Joined: 2015-12-09, 15:45
Contact:

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by moonbat » 2021-04-12, 16:14

tarakbumba wrote:
2021-04-12, 16:05
Do you think that it's harmful for Pale Moon or community to working on this?
No, not at all. It should be easy to fork given the simple function it performs. If anything, Pale Moon is about choice and there's nothing wrong if there are different extensions offering different combinations of the same features :)
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 21 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

vannilla
Moon Magic practitioner
Moon Magic practitioner
Posts: 2181
Joined: 2018-05-05, 13:29

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by vannilla » 2021-04-12, 20:56

tarakbumba wrote:
2021-04-12, 16:05
Do you think that it's harmful for Pale Moon or community to working on this?
Not everyone wants to install Tab Mix Plus (or similar) just to get a small feature, so even though I'm not (currently) using this extension I'm in favour of having multiple extensions doing a small thing and on the side a giant doing everything together, for those that want to have only one tool at the cost of an increased complexity.

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-04-13, 13:19

Thank you for your support. I released 1.2 version which fixes a harmless warning caused by unneeded function.

New Tobin Paradigm

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by New Tobin Paradigm » 2021-05-02, 01:33

billmcct wrote:
2021-04-12, 12:09
Hey it's easier for me to find things I want to see by reading the info on those sites and IMDB. Afterwards I can find them on my ROKU with voice commands and watch them. At my age, I need easier.
I was right to call bullshit on that. I did some checking and you are all over the torrent scene mostly at that YIFY site commenting on quality, bitching about broken downloads not being pubic and more. But video piracy isn't the only thing you have been up to lately is it Billyboy?

So have you always been a liar and a thief or is it something you picked up in your old age to pass the time before you finally kick off, hmm?

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-05-18, 22:51

I need help to test a new version. There is a reported bug on github page. Upon browser start or new window start, restore tabs button should be disabled if there are no closed tabs. But it is not as of now. This new 1.3beta1 version should fix it and button should disabled upon browser start when there are no closed tabs. Please install restore-tabs-button-1.3beta1.xpi from github relesase page, test and report back here or relevant github issue. Thanks.

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-05-19, 22:25

I released a new 1.3beta3 release today. This release should also fix a left-over issue from original code and re-introduced by previous beta that extension tries to open non-existent welcoming web page upon extension install/upgrade. Please install restore-tabs-button-1.3beta3.xpi from github relesase page, test and report back here or relevant github issue. Thanks.

User avatar
H Seldon
Hobby Astronomer
Hobby Astronomer
Posts: 23
Joined: 2021-05-21, 01:30

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by H Seldon » 2021-05-21, 04:31

Hi! Thank you for this extension. I tried version 1.3beta3 and I believe it is actually 1.2 release version. I downloaded twice to be certain. I tried version 1.3beta1 and it does fix the reported issue. I did not try beta2. I did notice that when browser history is cleared, including recently closed tabs, the button is still enabled. Is it possible to disable the button in this instance, so that the disabled state would always indicate that there are no closed tabs to reopen? If not, thanks anyway and thanks again for the extension.

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-05-21, 10:26

H Seldon wrote:
2021-05-21, 04:31
Hi! Thank you for this extension. I tried version 1.3beta3 and I believe it is actually 1.2 release version. I downloaded twice to be certain. I tried version 1.3beta1 and it does fix the reported issue. I did not try beta2. I did notice that when browser history is cleared, including recently closed tabs, the button is still enabled. Is it possible to disable the button in this instance, so that the disabled state would always indicate that there are no closed tabs to reopen? If not, thanks anyway and thanks again for the extension.
Thank you very much for your testing. About your request, unfortunately for now it works in this way. Extension doesn't read browser history but it memorizes only recently closed tabs. I' ll look into it though. Would you mind opening an issue about your request on GitHub, so we don't forget and keep track of it?

User avatar
H Seldon
Hobby Astronomer
Hobby Astronomer
Posts: 23
Joined: 2021-05-21, 01:30

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by H Seldon » 2021-05-21, 17:10

Thank you for your reply. I'm not sure I've made myself clear. When I clear browser history, the extension recognizes that there are no closed tabs, and indicates this when I right-click on the button. So, if it knows there are no closed tabs, can it not also disable the button, or does it only know this as a result of right-clicking the button?

User avatar
tarakbumba
Moonbather
Moonbather
Posts: 54
Joined: 2021-01-18, 14:26

Re: Forking Undo Closed Tabs Button: Restore Tabs Button Add-on

Unread post by tarakbumba » 2021-05-21, 19:14

tarakbumba wrote:
2021-05-18, 22:51
I need help to test a new version. There is a reported bug on github page. Upon browser start or new window start, restore tabs button should be disabled if there are no closed tabs. But it is not as of now. This new 1.3beta1 version should fix it and button should disabled upon browser start when there are no closed tabs. Please install restore-tabs-button-1.3beta1.xpi from github relesase page, test and report back here or relevant github issue. Thanks.
I have released restore-tabs-button-1.3 version today. This release fixes bug mentioned above. My internal testing and feedback from @H.Seldon shows no further issues and extension is stable. Soon I'll upload it to addons page. Thanks.

Locked