Page 13 of 17

Re: Pure URL for Palemoon

Posted: 2020-12-08, 01:02
by KlarkKentThe3rd
moonbat wrote:
2020-12-07, 23:15
It goes by what's in the garbage field list - so by comparing the original and filtered URL in the log you can see what fields were removed.
It intercepted a request, as I told it.

Re: Pure URL for Palemoon

Posted: 2020-12-26, 14:39
by wavymoon
moonbat

PureURL seems like a useful extension thanks for your efforts.
Just a note searching the Extension site with "PureURL" does not yield a result. "Pure URL" does. Would it not be a good idea to make BOTH search terms yield the location of the Pure URL/PureURL page. Pure URL is often refered to as PureURL, even in your own comments https://forum.palemoon.org/viewtopic.php?f=70&t=24887&p=202663&hilit=PureURL#p202663. This not the first time I have been caught by this.
If there is no way to do have both terms return a good result from your end as a developer, perhaps the site needs to use a Google site search ("PureURL" site:palemoon.org) as a extension page default.

Have a Happy, Healthy and Prosperous New Year

Re: Pure URL for Palemoon

Posted: 2020-12-26, 15:05
by Moonchild
wavymoon wrote:
2020-12-26, 14:39
perhaps the site needs to use a Google site search
Hell no.

Re: Pure URL for Palemoon

Posted: 2020-12-26, 17:49
by New Tobin Paradigm
An add-on in Phoebus can have as many search terms up to what 255 chars total in a space seperated list but we prefer no more than 10. So the exact term isn't a problem to add. But no.. not gonna use Google Site Search.

Do remember that one can search from the Add-ons Manager as well from the site so we HAVE to have our own results.

Re: Pure URL for Palemoon

Posted: 2020-12-26, 19:03
by coffeebreak
wavymoon wrote:
2020-12-26, 14:39
searching the Extension site with "PureURL" does not yield a result. "Pure URL" does.
Pure URL (two words) IS in fact the extension's name.
So naturally that is what the developer used for a search term. ;)
pureurl.png

Re: Pure URL for Palemoon

Posted: 2020-12-26, 19:10
by New Tobin Paradigm
There I added it for em. A-anything else?

Re: Pure URL for Palemoon

Posted: 2020-12-27, 00:03
by moonbat
New Tobin Paradigm wrote:
2020-12-26, 19:10
There I added it for em. A-anything else?
Thanks Tobin! :thumbup:

Re: Pure URL for Palemoon

Posted: 2021-01-10, 16:14
by wavymoon
Thank you tobin

Re: Pure URL for Palemoon

Posted: 2021-01-23, 04:28
by moonbat
Changelog for 3.3
  • Fix dead object reference error on Twitter.
  • Fix cleaning expanded links.
  • Add support for dlvr.it,ow.ly and soo.gd expansion.

Re: Pure URL for Palemoon

Posted: 2021-02-14, 08:08
by Attronarch
How can I set up Pure URL so it cleans Amazon links?

For example, if I click on http://amzn.to/2Az3sLU it will take me it to https://www.amazon.com/Strategies-War-J ... 084246f95b.

Even if the previous link is not expanded, I'd expect that it gets intercepted and cleaned.

Re: Pure URL for Palemoon

Posted: 2021-02-14, 08:38
by Moonchild
Please be careful cleaning Amazon (and eBay, etc.) links. You'd not want to "clean" links and remove affiliate revenue in the process, because then you're actively hurting people financially (and that's not the idea behind this extension, I think)

Re: Pure URL for Palemoon

Posted: 2021-02-20, 10:36
by Attronarch
Ah I see; the extension is intended to clean tracking links, and not affiliate links.

Moonbat, is it possible to have extension options (the ones that you have when clicking the icon) appear in the "Tools" as well?

Right now there is a "Pure URL Options" entry, and it'd be great if it'd have a drop down menu with the same options as when clicking the icon.

Re: Pure URL for Palemoon

Posted: 2021-02-20, 11:08
by moonbat
Attronarch wrote:
2021-02-20, 10:36
Ah I see; the extension is intended to clean tracking links, and not affiliate links.
They're not technically different AFAIK, if you have an example of one, you can figure out what parameter is used to identify an affiliate and not filter that.
Adding the same options to the tools menu entry should be doable.

Re: Pure URL for Palemoon

Posted: 2021-02-20, 11:57
by Moonchild
They're not technically different AFAIK
Yes, they are. Affiliate links don't include user-specific arguments. Tracking links do.
moonbat wrote:
2021-02-20, 11:08
if you have an example of one, you can figure out what parameter is used to identify an affiliate and not filter that.
Here's an example of a link with affiliate identifiers for eBay's partner programme:

Code: Select all

https://www.ebay.com/?mkcid=1&mkrid=711-53200-19255-0&siteid=0&campid=5338203677&customid=&toolid=10001&mkevt=1
That is an affiliate link - none of the parameters in there are used for tracking individual users, they are just there for affiliate/campaign/link identification, and should not be filtered. Filtering any of those arguments will invalidate the link and kill revenue for the affiliate/partner (making eBay itself claim the full margin instead).

Re: Pure URL for Palemoon

Posted: 2021-02-21, 23:39
by moonbat
I mean they are URL parameters like any other and it takes a conscious choice to filter them. The ones I filter on Amazon are on the site itself and meant to track the user across the site. Helps clean the links so they're more concise when sharing as well.

Re: Pure URL for Palemoon

Posted: 2021-02-22, 01:30
by Moonchild
moonbat wrote:
2021-02-21, 23:39
it takes a conscious choice to filter them
Of course it does, but my point was "be careful what you filter". It's easy to filter too much and as a result cause unintended harm to partners.

Re: Pure URL for Palemoon

Posted: 2021-02-22, 02:10
by moonbat
Yep, agreed.

As an example, here's a couple of decluttered links from the Amazon main page -

Code: Select all

[PureURL:]Original link: https://www.amazon.com.au/deal/d535c341/?_encoding=UTF8&showVariations=true&smid=ANEGB3WVEVKZB&pd_rd_w=GCzpP&pf_rd_p=107059b1-f077-4dc4-965a-bdd4c154a744&pf_rd_r=H0MRQ2003YNEFV7DTFXY&pd_rd_r=2355bd3e-36db-400a-ba9e-72175d6cec68&pd_rd_wg=A2LIJ&ref_=pd_gw_unk
Cleaned link:https://www.amazon.com.au/deal/d535c341/?_encoding=UTF8&showVariations=true&smid=ANEGB3WVEVKZB
[PureURL:]Original link: https://www.amazon.com.au/Fujifilm-Instax-Mini-Twin-Instant/dp/B0000C73CQ/?_encoding=UTF8&pd_rd_w=9INEN&pf_rd_p=3e050de6-3ab5-43a2-b873-0be17675f3f0&pf_rd_r=H0MRQ2003YNEFV7DTFXY&pd_rd_r=2355bd3e-36db-400a-ba9e-72175d6cec68&pd_rd_wg=A2LIJ&ref_=pd_gw_crs_zg_bs_4851799051
Cleaned link:https://www.amazon.com.au/Fujifilm-Instax-Mini-Twin-Instant/dp/B0000C73CQ/?_encoding=UTF8
The other thing I wanted to clarify for Attronarch is that the extension doesn't need either the toolbar button or menu item to function - you can hide both and it will do its job in the background. In fact the original extension I forked it from provided no UI, and being restartless provided nothing more than a comma separated list of garbage parameters in a text field so you couldn't even see them. Irritation with the non existent configuration UI and lack of logging (took a long time to figure out why some sites broke) was what prompted me to fork it.
But if you want less toolbar and tools menu clutter, you can totally hide the UI. The options aren't meant to be constantly fiddled with anyhow. I made the toolbar button a quick on/off toggle to make it easy to troubleshoot in case it was removing parameters that are required.

For others following the thread - the whole point of the garbage field list in options is to let you add your own. I have retained a minimal set of defaults such as the utm_* ones that are known to be for tracking, the rest can be added based on what sites you frequent. (This is in response to requests to filter this or that site that were asked before).

Re: Pure URL for Palemoon

Posted: 2021-02-22, 14:33
by Attronarch
moonbat wrote:
2021-02-22, 02:10
But if you want less toolbar and tools menu clutter, you can totally hide the UI. The options aren't meant to be constantly fiddled with anyhow. I made the toolbar button a quick on/off toggle to make it easy to troubleshoot in case it was removing parameters that are required.
The challenge for my use case with the on/off toolbar button is that it flips everything on and off.

I don't want the links to be rewritten; I want to see if they have additional parameters or not, and I want them intercepted and purified if I click on them.

True, I don't click it so often, hence why I'd like to remove it from the toolbar and be able to see at glance (in the Tools menu) if intercept is on or off.

Since you have two icons - green for rewriting and intercepting on, and red for off - perhaps there could be a third icon for when rewriting is off and intercepting is on?

Re: Pure URL for Palemoon

Posted: 2021-02-23, 00:11
by moonbat
Attronarch wrote:
2021-02-22, 14:33
I don't want the links to be rewritten; I want to see if they have additional parameters or not, and I want them intercepted and purified if I click on them.
That's not how it works - everything is done when a page is loaded (fix links) or a URL is fetched(intercept requests). If you want to see the unaltered page, turn it off from the toolbar button, enable logging, clear the console and reload the page. Once you've seen the links and figured out what parameters to remove, add them to the garbage fields list, re-enable filtering and reload the page. Now you can see what URLs were fixed in the error console by filtering the console with the [PureURL:] prefix.
Attronarch wrote:
2021-02-22, 14:33
True, I don't click it so often, hence why I'd like to remove it from the toolbar and be able to see at glance (in the Tools menu) if intercept is on or off.
The tooltip for the button will show you at a glance what all features are on/off, as well as how many links were cleaned on the last page that was loaded.

Re: Pure URL for Palemoon

Posted: 2021-08-10, 08:51
by wickedsp1d3r
Could it be possible to allow customization of the highlight on cleaned links? Dotted underline is a bit too unseen to my taste... and I would prefer a yellow background like CleanLinks2 does.

Also I have started to see console errors on Google, like this:

Code: Select all

[PureURL error:] URI= https://www.google.com/gen_204?atyp=i&ei=njwSYejQONaC9u8Pi_e8kAI&dt19=2&zx=1628585120228
modified path=/gen_204?atyp=i&dt19=2&zx=1628585120228
[Exception... "Component returned failure code: 0x80004004 (NS_ERROR_ABORT) [nsIURI.path]"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: chrome://pureurl4pm/content/common.jsm :: observe :: line 292"  data: no]

Code: Select all

[PureURL error:] URI= https://www.google.com/gen_204?atyp=i&ei=njwSYejQONaC9u8Pi_e8kAI&ct=slh&v=t1&m=HV&pv=0.5335816555422387&me=1:1628585119904,x:2,V,0,0,1920,889:0,B,1715:0,N,1,njwSYejQONaC9u8Pi_e8kAI:0,R,1,8,24,36,92,34:0,R,1,CAEQAw,252,85,106,45:0,R,1,CAEQBA,360,85,83,45:0,R,1,CAEQBQ,445,85,81,45:0,R,1,CAEQBg,528,85,92,45:0,R,1,CAEQNw,180,257,652,1209:0,R,1,CAwQAA,180,257,600,121:0,R,1,CAYQAA,180,408,600,99:0,R,1,CA8QAA,180,537,600,99:0,R,1,CA4QAA,180,665,600,121:0,R,1,CAoQAA,180,816,600,99:2652,e,B&zx=1628585122560
modified path=/gen_204?atyp=i&ct=slh&v=t1&m=HV&pv=0.5335816555422387&me=1:1628585119904,x:2,V,0,0,1920,889:0,B,1715:0,N,1,njwSYejQONaC9u8Pi_e8kAI:0,R,1,8,24,36,92,34:0,R,1,CAEQAw,252,85,106,45:0,R,1,CAEQBA,360,85,83,45:0,R,1,CAEQBQ,445,85,81,45:0,R,1,CAEQBg,528,85,92,45:0,R,1,CAEQNw,180,257,652,1209:0,R,1,CAwQAA,180,257,600,121:0,R,1,CAYQAA,180,408,600,99:0,R,1,CA8QAA,180,537,600,99:0,R,1,CA4QAA,180,665,600,121:0,R,1,CAoQAA,180,816,600,99:2652,e,B&zx=1628585122560
[Exception... "Component returned failure code: 0x80004004 (NS_ERROR_ABORT) [nsIURI.path]"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: chrome://pureurl4pm/content/common.jsm :: observe :: line 292"  data: no]
What do they mean? What is wrong?

I have also a question concerning on links like this:

Code: Select all

https://example.com/one/two/?shared%3D1956140-913eaeca-1
I would like to have "shared" part stripped out. Is this currently possible with Pure URL?