GetemAll! - Fork of DownthemAll!

[moonbat]

Changelog for 1.2.1
This release has a few fixes and new features courtesy RealityRipple

• Add "Select file extension on rename" preference
• Rename "Remove completed downloads immediately" preference
• Convert Binary Hash to Hex String

[moonbat]

Changelog for 1.2.2

• Added Polish localization by forum user Piotrek Ślusarz

Please feel free to contact me for adding other localizations for this or my other extensions (in my signature).

[vchuubacabra]

Hi. Let's see if this thread of forum is different or business as usual.
Which of feature requests listed below you could implement in this extension?

- Add "Go to referring page" in right-click menu of the download.
- Menu to group downloads by the values of Estimated Time column and/or Progress column to have all failed/skipped/complete/paused etc. downloads close to each other at the moment of sorting
(having Running/Waiting downloads as a constant group would be problematic as they may change their status without user's interference)
- Option to automatically remove Skipped for the reason of identical names downloads from the list like it is done for complete downloads.
- Add new downloads on the top of the list instead of on the bottom.

[RealityRipple]

Hi. Let's see if this thread of forum is different or business as usual.
Which of feature requests listed below you could implement in this extension?

- Add "Go to referring page" in right-click menu of the download.
- Menu to group downloads by the values of Estimated Time column and/or Progress column to have all failed/skipped/complete/paused etc. downloads close to each other at the moment of sorting
(having Running/Waiting downloads as a constant group would be problematic as they may change their status without user's interference)
- Option to automatically remove Skipped for the reason of identical names downloads from the list like it is done for complete downloads.
- Add new downloads on the top of the list instead of on the bottom.

Referring page context menu item:
Doable - Here's the commit to achieve it: https://gitlab.com/RealityRipple-xul/getemall/-/compare/master...open-referrer?from_project_id=25676375&straight=false

Grouping:
Unfortunately, when this extension was developed, the developer had a different methodology in mind - rather than sorting and groups, this extension filters. If you click the "Download/Name", "Size", "Est. Time", and "Save Path" column headers, you get dropdowns to filter which downloads should be visible: "Download/Name" lets you filter by file type and origin URL; "Size" by various file size ranges; "Est. Time" provides ranges of remaining time as well as the current download state.

Remove identical names:
There's a context menu sub-item that's literally called "Remove Duplicates" under the "Remove Downloads" menu. There's also a setting under general: "When a file of the same name already exists:" with the options "Rename", "Overwrite", "Skip", or "Ask".

Add new downloads:
This could cause some undesired behavior when a Concurrent Downloads limit is reached, since the order in the list is used for the queue order, older downloads would be interrupted/paused to allow the new one to start. It would be possible to invert absolutely everything, so that the bottom of the list is the top of the queue, but I don't think many users would like this, as it's counter-intuitive.

[vchuubacabra]

Understood.

Remove identical names:
There's a context menu sub-item that's literally called "Remove Duplicates" under the "Remove Downloads" menu. There's also a setting under general: "When a file of the same name already exists:" with the options "Rename", "Overwrite", "Skip", or "Ask".

Yes, may happen it's link added for download for the second time in the same download session or with list saved from previous session, but I mean situation when file queued for download already exist on the storage but is not listed in downloads, and option for already existing files is set to Ask. Then GtA creates downloads list entry, asks what to do, gets answer "Skip" and sets status of download entry to Skipped. If this is exactly what Remove Duplicates is for, then OK (but needs clarifying imo). And if this looks like insignificant improvement, then just an option "Go to referring page" is good too.

[RealityRipple]

Ah, I see the use-case you're referring to. I believe that's a matter of order-of-operations - the download is appended to the list, the row is added to the treeview, the download is started, the existing file is detected, the prompt is shown, the row is marked as skipped. Only a limited amount of data is passed from the first operation to the last one, and it changes with every step. I can see if there's a good spot in code to check for the file existence and abort before the sequence gets through the first step.

Edit: Looked into it. There is a place where a check would be ideal, but it's not a good spot to show the "rename/override/cancel" prompt, due to the prompt being asynchronous and the ideal spot being synchronous. I wrote a patch that will achieve this, but it's not exactly the best:
https://gitlab.com/RealityRipple-xul/getemall/-/compare/master...check-exists?from_project_id=25676375&straight=false

[vchuubacabra]

How getting new functions in extension works?
Do I must to be able to compile my own version myself?
Or you as a group of developers carefully consider if they should be included in some release and sooner or later they may appear afer extension update?
Currently I have version 1.2.4 from July 10 and it has no option to open referring page via context menu.

[RealityRipple]

I roll my own fork. Moonbat imports changes if they're desired or relevant to the main fork.

[moonbat]

The original DownThemAll was one of the most popular classic Firefox extensions; I decided to fork it for Pale Moon in case the original XUL one went away (the current Firefox version is a web extension and lacks features that this one does). It is mostly feature complete as a download manager, RealityRipple has made patches for small fixes now and then.

[vchuubacabra]

The original DownThemAll was one of the most popular classic Firefox extensions; I decided to fork it for Pale Moon in case the original XUL one went away (the current Firefox version is a web extension and lacks features that this one does). It is mostly feature complete as a download manager, RealityRipple has made patches for small fixes now and then.

Was this answer helpful? : [Yes] [No]

Ok, let me ask directly: will you add to extension some improvements from RealityRipple's fork which I asked for few posts above?

[moonbat]

Ok, let me ask directly: will you add to extension some improvements from RealityRipple's fork which I asked for few posts above?

Read again:

RealityRipple has made patches for small fixes now and then.

and then read the changelog in this very thread before your first comments.

[vchuubacabra]

Last changelog before my post is for version 1.2.2.
I currently have installed version 1.2.4.
What have you changed?

[moonbat]

MInor Polish translation fixes from the translator.

[vchuubacabra]

So your historical digression translates into you DON'T ADD NEW FEATURES and if I want some, I need to find a way to do it MYSELF, like in my inqury.

[moonbat]

So your historical digression translates into you DON'T ADD NEW FEATURES and if I want some, I need to find a way to do it MYSELF, like in my inqury.

What the fuck are you talking about?

[vchuubacabra]

What the fuck are you talking about?

About the story you told of how great original Firefox extension was and why you decided to fork it and blah blah blah.
I'm not interested in history, I am interested in referring page of download being open via command from context menu and yet something.
RealityRipple made those patches in his own fork. I thought all changes are centralized and automatically added to main extension, but no, it's LEGO for developers as always.
So someone not familiar with xul building won't be able to get extension version rich with features that someone desires.

[moonbat]

RealityRipple made those patches in his own fork. I thought all changes are centralized and automatically added to main extension, but no, it's LEGO for developers as always.

Then you need to understand how open source projects and forks work; or do you expect new features in Firefox to automatically be added to Pale Moon as well, based on both codebases having had a common ancestor? RealityRipple has often contributed patches to integrate here and I've always added them.

[vchuubacabra]

I don't care for new features in Firefox as my main browser is Opera and I'm simple Windows user who doesn't build software from the sources on his own.

[Moonchild]

Can you, just... not throw a tantrum and attack someone who is creating a browser extension just because you can't get the feature you want?
I mean, come on. If you want it that much, you can create your own fork and add it yourself (and maybe contribute it back as an enhancement if it's generally acceptable). Creating and maintaining extensions isn't rocket science. Tens of thousands of ordinary users have done so.

[vchuubacabra]

Tantrums and attacks are in your head.
I asked for features, RealityRipple said it's done, but didn't explain it is done only in his repository.
When extension got an update, I didn't see them and asked if I have to do everything myself and I got lecture about days long gone in response.
Is it that hard to give direct answer to concrete question?