Area on Amazon UK Digital Music pages causes crash on 32.2.0 Topic is solved

For support with specific websites

Moderator: trava90

Forum rules
Please always mention the name/domain of the website in question in your topic title.
Please one website per topic thread (to help keep things organized). While behavior on different sites might at first glance seem similar, they are not necessarily caused by the same.

Please try to include any relevant output from the Toolkit Error Console or the Developer Tools Web Console using the following procedure:
  1. Clear any current output
  2. Navigate or refresh the page in question
  3. Copy and paste Errors or seemingly relevant Warnings into a single [ code ] block.
Pause
Apollo supporter
Apollo supporter
Posts: 41
Joined: 2021-08-19, 10:05

Area on Amazon UK Digital Music pages causes crash on 32.2.0

Unread post by Pause » 2023-05-20, 07:31

Not sure whether it actually counts as a Web Compatibility issue rather than being something that should be in the Browser Support section instead, but as it's something that specifically happens on this type of page on the site in question, I thought it might fit better here.

Using https://www.amazon.co.uk/dp/B0022W59IC/ as an example of the type of page it happens on, with no need to be logged in, trying to hover over 'Purchase options' or the surrounding row causes Pale Moon (Windows 10, 64-bit) to crash and immediately close.

It's definitely not a profile issue, as it also happens on a clean profile with no addons.

32.1.1 doesn't crash but has all the same errors EXCEPT for the CWR ones, with the 'Purchase options' and surrounding area actually being usable (or at least as far as I know, as I only really tried the 'Purchase options' in the past to buy MP3s - successfully - while ignoring the other things in the same row).

Whether the CWR errors have any actual relation to the cause of the crash I obviously have no idea though.

The errors are what are present in the consoles BEFORE attempting to hover over the problem row of course, it's only when actually trying to hover the mouse over the area that the crash and immediate closure happens.

Error Console:

Code: Select all

Error: The Components object is deprecated. It will soon be removed.
Source File: https://www.amazon.co.uk/dp/B0022W59IC/
Line: 1895

Error: Error: 
Source File: https://d5fx445wy2wpk.cloudfront.net/release/WebSF/app.modern.d1b499d45a790162cae2.js
Line: 41

Error: Error: CWR: Failed to retrieve Cognito identity
Source File: https://client.rum.us-east-1.amazonaws.com/1.10.0/cwr.js
Line: 2

Warning: Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.
Source File: https://m.media-amazon.com/images/I/61ZS63EQSsL.js?AUIClients/AmazonUIjQuery
Line: 91
Web Console:

Code: Select all

The Components object is deprecated. It will soon be removed.  
B0022W59IC:1895:148
Error:   
app.modern.d1b499d45a790162cae2.js:41:3652

Error: CWR: Failed to retrieve Cognito identity  
cwr.js:2:35106

Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.  
61ZS63EQSsL.js:91:427

Error logged with the Track&Report JS errors API(http://tiny/1covqr6l8/wamazindeClieUserJava): {"m":"A copy of P has already been loaded on this page.","csm":"v5 ueLogError callee","logLevel":"FATAL","pageURL":"https://www.amazon.co.uk/dp/B0022W59IC/","s":["function(){if(c.ue_err.erl){var a=c.ue_err.erl.length,g;for(g=0;g<a;g++){var b=c.ue_err.erl[g];B(b.ex,\nb.info)}ue_err.erl=[]}}","function(c,m){function y(a){if(a)return a.replace(/^\\s+|\\s+$/g,\"\")}function x(a,g){if(!a)return{};var b=\"INFO\"===g.logLevel;a.m&&a.m.message&&(a=a.m);var f=g.m||g.message||\"\";f=a.m&&a.m.message?f+a.m.message:a.m&&a.m.target&&a.m.target.tagName?f+(\"Error handler invoked by \"+a.m.target.tagName+\" tag\"):a.m?f+a.m:a.message?f+a.message:f+\"Unknown error\";f={m:f,name:a.name,type:a.type,csm:N+\" \"+(a.fromOnError?\"onerror\":\"ueLogError\")};var h,l=0;f.logLevel=g.logLevel||A;g.adb&&(f.adb=g.adb);if(h=g.attribution)f.at"],"t":2128,"fcsmln":5,"cinfo":{"1":"<!-- sp:feature:head-start --><head><script async=\"\" src=\"https://images-eu.ssl-images-amazon.com/images/I/31bJewCvY-L.js\" crossorigin=\"anonymous\"></script><script async=\"\" src=\"https://client.rum.us-east-1.amazonaws.com/1.10.0/cwr.js\"></script><script>var aPageStart = (new Date()).getTime();</script><meta charset=\"utf-8\"><style data-styles=\"\">music-text-row,music-barker,music-image-row,music-playback-container-item,music-shoveler,music-vertical-item,music-detail-header,music-track-list-row,music-grid-block,music-hinted-button,music-list-item,music-notification-ribbon,music-tooltip,music-context-menu-header,music-app,music-context-menu,music-divider,music-flexible-text-container,music-thumbnail-item,music-toggle,circular-progress-bar,music-popularity-bar,music-star-rating,music-horizontal-item,music-checkbox,music-tag-group,music-playback-button,music-tag,music-link,music-button,music-image,music-icon,music-episode-row-item,music-carousel,music-featured-play,music-refinement-bar,podcast-featured-play,music-checkbox-group,music-button-group-item,music-notification-toast,music-pill-item,music-color-options,music-container,music-flexible-text,music-list-item-header,music-radio-button,music-radio-button-group,music-selection-item,music-text-input{visibility:hidden}.hydrated{visibility:inherit}</style>","2":"<!-- sp:end-feature:head-start -->","3":"<!-- sp:feature:csm:head-open-part1 -->","4":""}} Object { m: "A copy of P has already been loaded…", name: undefined, type: undefined, csm: "v5 ueLogError callee", logLevel: "FATAL", pageURL: "https://www.amazon.co.uk/dp/B0022W5…", f: undefined, l: undefined, c: undefined, s: Array[2], 3 more… }

dbsoft
Project Contributor
Project Contributor
Posts: 407
Joined: 2020-02-21, 17:35

Re: Area on Amazon UK Digital Music pages causes crash on 32.2.0

Unread post by dbsoft » 2023-05-20, 07:54

Replicated this crash on Windows... looks a lot like a MOZ_CRASH I got on reddit.com with a debug build.

Actually looks like the code was introduced here: https://repo.palemoon.org/MoonchildProd ... 1c14267f53

targetElement is NULL

A simple null check prevents the crash, but I am not sure if that is how this should be handled...

Code: Select all

diff --git a/layout/style/nsCSSRuleProcessor.cpp b/layout/style/nsCSSRuleProcessor.cpp
index da25732d37..d6ec93b7f6 100644
--- a/layout/style/nsCSSRuleProcessor.cpp
+++ b/layout/style/nsCSSRuleProcessor.cpp
@@ -1716,7 +1716,7 @@ static bool SelectorMatches(Element* aElement,

   // namespace/tag match
   // optimization : bail out early if we can
-  if ((kNameSpaceID_Unknown != aSelector->mNameSpace &&
+  if (!targetElement || (kNameSpaceID_Unknown != aSelector->mNameSpace &&
        targetElement->GetNameSpaceID() != aSelector->mNameSpace))
     return false;
Do we drop out if the slot is NULL or do we use aElement instead?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35478
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Area on Amazon UK Digital Music pages causes crash on 32.2.0

Unread post by Moonchild » 2023-05-20, 09:58

"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked