BBC Sport - missing spacing

For support with specific websites

Moderator: trava90

Forum rules
Please always mention the name/domain of the website in question in your topic title.
Please one website per topic thread (to help keep things organized). While behavior on different sites might at first glance seem similar, they are not necessarily caused by the same.

Please try to include any relevant output from the Toolkit Error Console or the Developer Tools Web Console using the following procedure:
  1. Clear any current output
  2. Navigate or refresh the page in question
  3. Copy and paste Errors or seemingly relevant Warnings into a single [ code ] block.
User avatar
Trippynet
Fanatic
Fanatic
Posts: 238
Joined: 2014-06-03, 20:21
Location: UK

BBC Sport - missing spacing

Unread post by Trippynet » 2022-03-31, 19:27

BBC seem to have tweaked their Sport page recently and the new one isn't rendering correctly in Pale Moon. The spacing between the elements is missing (particularly noticeable is the missing vertical spacing). I've attached two screenshots - one showing the Pale Moon rendering, and another showing how it is supposed to look from Vivaldi.

Quite a number of warnings in the console, I imagine these are the most relevant ones:

Code: Select all

Timestamp: 31/03/2022 20:24:04
Warning: Unexpected value 4.5625rem parsing width attribute.
Source File: https://www.bbc.co.uk/sport
Line: 0

Timestamp: 31/03/2022 20:24:04
Warning: Unexpected value 1.3125rem parsing height attribute.
Source File: https://www.bbc.co.uk/sport
Line: 0

Timestamp: 31/03/2022 20:24:06
Warning: Unexpected value 4.5625rem parsing width attribute.
Source File: https://static.files.bbci.co.uk/core/bundle-defaultVendors.aa634534fba22feb91c8.js
Line: 2

Timestamp: 31/03/2022 20:24:06
Warning: Unexpected value 1.3125rem parsing height attribute.
Source File: https://static.files.bbci.co.uk/core/bundle-defaultVendors.aa634534fba22feb91c8.js
Line: 2
Any ideas?
Attachments
PM.JPG
Vivaldi.JPG

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35402
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: BBC Sport - missing spacing

Unread post by Moonchild » 2022-03-31, 19:51

Trippynet wrote:
2022-03-31, 19:27
Any ideas?
Provide feedback to the BBC?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: BBC Sport - missing spacing

Unread post by Tomaso » 2022-03-31, 20:01

As a workaround, you can use this rule in uBO:

Code: Select all

bbc.com##[class*="-ListItem"]:style(margin: 8px !important;)
Last edited by Tomaso on 2022-04-01, 04:51, edited 1 time in total.

vannilla
Moon Magic practitioner
Moon Magic practitioner
Posts: 2181
Joined: 2018-05-05, 13:29

Re: BBC Sport - missing spacing

Unread post by vannilla » 2022-03-31, 23:19

For those interested in the nature of the problem it's caused by the use of CSS grid (display: grid) with the addition of gap: 1rem to create the spacing.
For this specific website there are alternatives that are a bit more verbose to take care of edge cases, so you can either wait until Pale Moon supports gap, contact BBC to ask them if they can simply use margin: 1rem in the proper places, or give up and use some workaround like what Tomaso proposed (though if we want to be correct it should be margin not padding, there).

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: BBC Sport - missing spacing

Unread post by Tomaso » 2022-04-01, 04:52

vannilla wrote:
2022-03-31, 23:19
if we want to be correct it should be margin not padding, there.
Corrected. :)

User avatar
Trippynet
Fanatic
Fanatic
Posts: 238
Joined: 2014-06-03, 20:21
Location: UK

Re: BBC Sport - missing spacing

Unread post by Trippynet » 2022-04-01, 07:26

Many thanks everyone. I may e-mail the BBC at some point, although I imagine they probably won't do anything given that Chromium and Gecko both render the site correctly. For now though, that uBO rule works a treat - many thanks!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35402
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: BBC Sport - missing spacing

Unread post by Moonchild » 2022-04-01, 08:16

Trippynet wrote:
2022-04-01, 07:26
I imagine they probably won't do anything given that Chromium and Gecko both render the site correctly.
If you don't let them know you can be sure they won't do anything.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
FranklinDM
Add-ons Team
Add-ons Team
Posts: 570
Joined: 2017-01-14, 02:40
Location: Philippines
Contact:

Re: BBC Sport - missing spacing

Unread post by FranklinDM » 2022-04-02, 14:23

I've filed Issue #1838 (UXP) for this.

User avatar
andkrau
Moongazer
Moongazer
Posts: 8
Joined: 2020-09-07, 23:02
Location: Chicago, US

Re: BBC Sport - missing spacing

Unread post by andkrau » 2022-04-02, 19:06

Your commits worked perfectly. I couldn't get flexboxes to play nice when I gave it a shot.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: BBC Sport - missing spacing

Unread post by Tomaso » 2022-05-06, 22:12

Same problem @ https://itch.io/ now, it seems.

User avatar
andkrau
Moongazer
Moongazer
Posts: 8
Joined: 2020-09-07, 23:02
Location: Chicago, US

Re: BBC Sport - missing spacing

Unread post by andkrau » 2022-05-06, 23:01

Tomaso wrote:
2022-05-06, 22:12
Same problem @ https://itch.io/ now, it seems.
Since this commit, it has been fixed within UXP: https://repo.palemoon.org/MoonchildProductions/UXP/commit/78d1f68932

I'm sure you'll be seeing the improvement in a future release.

compare.jpg

Locked