tcgplayer.org -- invalid regex syntax

meatloaf · Unread post by **meatloaf** » 2020-08-30, 18:24

TCGPlayer's card searching webpage seems to have stopped working on Pale Moon since they've updated to a "new and improved" version of the site.
Here is a sample link:
https://www.tcgplayer.com/search/all/product?q=ezuri
In the console, it complains about something used as a regex (SyntaxError: invalid regexp group) in their minified javascript. It complains here (at line 1 , column 38574 of this file):
...Oe="help-dismissed",Pe="||",Le=/^(?<qu...
.........................^

I tested with the latest ungoogled chromium also (v83.0.4103.97-1.1) and it works properly there.
Thanks for any help.

Unread post by **vannilla** » 2020-08-30, 18:45

Try reporting it to the website developers.

meatloaf · Unread post by **meatloaf** » 2020-08-30, 18:55

vannilla wrote: ↑
2020-08-30, 18:45
Try reporting it to the website developers.

I suppose I could do that. I did fail to mention it works in other browsers in my original post, however (I've edited it). I tested with the latest ungoogled chromium build.

howdyhamster · Unread post by **howdyhamster** » 2020-09-03, 06:42

I've been having this issue as well since 8/21. And this isn't just Pale Moon, it's also an issue with Firefox for Android. The homepage is just a white screen as well as any search function:
https://www.tcgplayer.com/
https://www.tcgplayer.com/search/

A workaround for now has been to use the price guide, but searching still doesn't work from this page:
https://shop.tcgplayer.com/price-guide/pokemon

I did send tcgplayer this feedback:

Your homepage no longer works on Firefox for android version 68.11 and just shows a white screen. Subdomains such as store.tcgplayer.com sometimes will load, but searching for anything will redirect to www.tcgplayer.com which is blank.

to which they replied with:

Thank you for contacting us with your feedback! If you aren't using Chrome, we would recommend giving that a try as it is a free, easy to download browser that is fully supported by our site. In the meantime, I will share your feedback with our Technology and Management teams, we're always working on new tools and initiatives to make the site better so we really appreciate your suggestion and your patience!

which to me reads as "We don't plan to fix it, use Chrome"

athenian200 · Unread post by **athenian200** » 2020-09-03, 07:04

I believe this could be related to RegExp Lookbehind functionality, which was not added to Firefox until version 78. We tried to implement that once before, but the implementation was quite buggy and caused crashes. I believe the crashes were related to feeding a negative value into the RegExp compiler somewhere, which is kind of a problem given what Lookbehind functionality is supposed to do. I'm guessing that we had a function somewhere that only had proper stack guards in one direction, or something like that. I don't know enough about the details.

viewtopic.php?f=3&t=23646

But this is basically the reason we don't have RegExp lookbehind. The implementation we had was trying to access invalid memory locations (at least on Windows), so it had to be backed out and we haven't really found a better implementation since. Mozilla eventually did it by simply writing a shim that let them import the latest Irregexp from Chromium as they please.

https://hacks.mozilla.org/2020/06/a-new ... dermonkey/

Off-topic:
I don't know if this piece of trivia interests anyone else, but it means that Mozilla doesn't have an independent RegExp implementation, while WebKit actually does have a different RegExp called Yarr (which Mozilla used to use). So it is an area where the assumption that Mozilla's engine is more distinct from Google's than WebKit is actually breaks down.

New Tobin Paradigm · Unread post by **New Tobin Paradigm** » 2020-09-03, 14:18

Why can't we look into using Yarr once again?

KlarkKentThe3rd · Unread post by **KlarkKentThe3rd** » 2020-09-13, 01:30

Interesting, I tried gamejolt, another site that now gives you a blank page, in both Classic and Current Waterfox (the latter has WebRTC support), and both do not work! This is strange.

KlarkKentThe3rd · Unread post by **KlarkKentThe3rd** » 2020-09-13, 07:32

Tried Gamejolt on Safari on Mac, it worked. Waterfox Current does not work.

Unread post by **Moonchild** » 2020-09-13, 07:57

For the record, this seems to be related to something called "named capture groups", a method to use names instead of number references inside regex for capture groups. Not related to lookbehind/lookaround.
As if regex should be so long and complex that you need to start doing this

I don't know if we could go back to yarr. It'd be a hell of a lot of work to do if so, and would likely all be up to little old me to do it, because it's JS and nobody else dares even look at that monkey let alone shovel its shit.

KlarkKentThe3rd · Unread post by **KlarkKentThe3rd** » 2020-09-13, 11:08

Is there any other way?

Unread post by **Moonchild** » 2020-09-13, 11:30

KlarkKentThe3rd wrote: ↑
2020-09-13, 11:08
Is there any other way?

Appeal to the webmasters and ask them kindly not to use chrome-specific regex?

Pale Moon forum

tcgplayer.org -- invalid regex syntax

tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax

Re: tcgplayer.org -- invalid regex syntax