Switching tabs on GitHub PRs doesn't work

[OPNA2608]

PM28.11.0, Ubuntu 18.04 & NixOS.

GitHub recently updated their UI, since then switching between "tabs" on PRs gets the page stuck in a loading screen. Popping open the console shows it's a problem regarding the use of Shadow DOM?

Code: Select all

ReferenceError: ShadowRoot is not defined

You can work around it by hitting reload, but it's still bothersome ofc.

[Moonchild]

Yup

Code: Select all

09:01:46.776 ReferenceError: ShadowRoot is not defined 1 vendor-c0375c83.js:120:56177
	get field https://github.githubassets.com/assets/vendor-c0375c83.js:120:56177
	disconnectedCallback https://github.githubassets.com/assets/vendor-c0375c83.js:120:55928
	a.prototype.disconnectedCallback https://github.githubassets.com/assets/compat-bootstrap-6e7ff7ac.js:1:3554
	set https://github.githubassets.com/assets/compat-bootstrap-6e7ff7ac.js:1:11641
	vt https://github.githubassets.com/assets/frameworks-0e2d57cb.js:1:22707
	execute/< https://github.githubassets.com/assets/frameworks-0e2d57cb.js:1:24113
	execute/< https://github.githubassets.com/assets/github-bootstrap-db5bed9d.js:16:225263
	K https://github.githubassets.com/assets/vendor-c0375c83.js:120:5038
	rt https://github.githubassets.com/assets/frameworks-0e2d57cb.js:1:18432
	T https://github.githubassets.com/assets/frameworks-0e2d57cb.js:1:3050
	execute/< https://github.githubassets.com/assets/github-bootstrap-db5bed9d.js:1:60546
	K https://github.githubassets.com/assets/vendor-c0375c83.js:120:5038

Nothing we can do about that at the moment because Google WebComponents is still a work in progress in development, and if GitHub insists on redefining the way they use the web every 2 weeks based on the lastest Chromium shinies then there's really nothing we can do. You may try to contact github support about it but since they stopped responding to my requests or having a normal dialogue with me when I give them feedback, I'm not sure if they will still listen or if it's a "use Edge because we're Microsoft now" matter.

[adesh]

Works fine here. I do not get the error and I'm not logged in.

[New Tobin Paradigm]

Works fine here. I do not get the error and I'm not logged in.

You won't get it unless you are logged in.. Don't ask why.. I dunno except Googlesoft.

HOWEVER

I have created a userscript that MAY help with some of the ajax loading issues when navigating around github. Well, what it does is bypasses ajax loading and thus as a side effect, the ShadowRoot call during ajax loading.

It is only a temporary workaround and may not work in the future but least for today.. it does. Check out: https://greasyfork.org/en/scripts/407745-bypass-github-ajax/code.

[Moonchild]

As an aside, GitHub has been notified of this and of the cause of this particular trouble -- let's hope this time they don't take 2 months to respond to my ticket.

[Tharthan]

Moonchild, rest assured that they would probably tell you that 'Your business is very important to us, and someone will be on the line to speak with you shortly. Thank you for choosing GitHub".

[JustOff]

As an alternative to the userscript above, you can use the following rule for uBlock Origin:

Code: Select all

github.com##+js(remove-attr.js, data-pjax)

In this case, you will also need to use the Scriptlet Doctor to bypass GitHub's strict content security policy.

[Moonchild]

Moderation notice: removed a series of really unnecessary posts from everyone involved (including myself).

For clarification, JustOff's alternative is a copy of Tobin's solution, but then converted to another method of page manipulation for those who for some reason or another would prefer to use uBO for this purpose instead of a dedicated script engine, and are comfortable with breaking CSP in the browser for it and increasing the risk of XSS as the Scriptlet Doctor extension's homepage warns (please know what you install).