Page 2 of 2
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-18, 16:55
by gull5
I installed ABPrime v3.1.7770 on a brand new portable version downloaded to make sure there is not a conflict with another addon, then I downgraded to v1.0.7 in order to make the screenshots but unfortunately it also did not work so I had to install Adblock Latitude to make them, for the test I used the 64bit portable version on a computers running W10 20H2 with all avialable updates.
Right now with only ABPrime & EHPrime installed on startup in the Error console I see:
Code: Select all
Warning: Warning: ‘nsIOService::NewChannelFromURI()’ deprecated, please use ‘nsIOService::NewChannelFromURI2()’
Source File: resource://adblocker/modules/IO.jsm
Line: 71
Warning: Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”
Source File: chrome://browser/content/browser.xul
Line: 0
When I click on ABPrime v3.1.7770 Advanced view button I get:
Code: Select all
Error: ReferenceError: advancedMode is not defined
Source File: chrome://global/content/bindings/dialog.xml line 381 > Function
Line: 2
P.S. On my installed version with other addons in the profile I sometimes see:
Code: Select all
Error: NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsICacheService.createSession]
Source File: chrome://adblocker/content/sidebar.js
Line: 282
I can run tests on the portable version if need me to.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-18, 17:00
by New Tobin Paradigm
Well I still can't reproduce any issue with any combination of the LATEST versions of any of it. It is all fully operational on Pale Moon and Basilisk with either ABPrime or ABL and of course Borealis with ABPrime.
Also, not all those are actual problems. I think in the end, you should just switch to something else.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-18, 17:28
by gull5
The reported errors are from ABPrime v3.1.7770 & EHPrime v1.5.7795.
Can you suggest anything else I could check/test because I have ran the scenario on 3 different computers (download PM v29.2.0 64bit portable, install ABPrime v3.1.7770 & EHPrime v1.5.7795, restart, test) and got the exact same error when I click on the "Advanced view" button?
P.S. I can repeat the tests for Basilisk & Borealis if they have portable versions you can point me to.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-18, 17:42
by New Tobin Paradigm
They do not.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-20, 06:39
by gull5
Same problem in Ubuntu v20.04 LTS:
Screenshot Ubuntu.png
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-20, 15:20
by New Tobin Paradigm
Okay, this has nothing to do with EHPrime and it seems to affect ABPrime's image block filter creation window.. You say it also affects ABL as well?
That complicates matters BUT it may require the same sort of fix. For now, use EHPrime to hide images (or any other element) until more can be found why that SPECIFIC bit in both Adblockers is failing. BTW, that is where the confusion was because that function and dialog belongs to the Adblockers not EHPrime but they are VERY similar.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-20, 16:46
by New Tobin Paradigm
Now I can't attest for ABL but I fixed the issue in ABPrime but another issue is showing up in the console but it may be unresolvable but hardly matters for the function of the dialog. Frankly, I don't really see a point for that function at all if EHPrime is a thing and can block images and every OTHER element. If i can't fix the new error I will just ignore it and ship the version with the let scope issue fixed.
It may simply be easier in the end to just remove that function all together since it is the last vestige or the original EHH code when it was IN the adblocker and seems kinda redundant.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-21, 11:59
by gull5
No ABL is not affected by this problem.
EHPrime was installed to check if it'll somehow fix the problem since you ware not able to reproduce it.
Can you tell me what EHH is, what is the new error and what functionality is not working?
P.S. Thanks.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-21, 12:45
by New Tobin Paradigm
I was not able to reproduce it because of the similarity in function and because you didn't explain the situation properly. How was I supposed to know a piece of ABPrime has been busted for years and never mentioned when I just fixed and released a companion extension that does the same thing with virtually the same dialog.
I am going to solve it by removing the redundant functions from ABPrime because EHPrime can do the same shit only better.
Why fix older and more primitive bits of ABPrime when EHPrime is superior all without being broken-ish.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-22, 11:34
by Moonchild
New Tobin Paradigm wrote: ↑2021-05-21, 12:45
Why fix older and more primitive bits of ABPrime when EHPrime is superior all without being broken-ish.
Because not everyone may want to install EHPrime?
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-22, 11:43
by New Tobin Paradigm
Ok.. let me rephrase, why fail to fix something that is more primitive when EHPrime works.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-22, 19:54
by coffeebreak
New Tobin Paradigm wrote: ↑2021-05-20, 15:20
it seems to affect ABPrime's image block filter creation window
Maybe the same issue that was fixed in ABL last year?
ABL issue#29
& this
thread
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-23, 01:01
by New Tobin Paradigm
No. Not related to anything I am talking about and it is irrelevant anyway since I am removing duplicate functionality covered by EHPrime anyway so THAT problem will be eliminated as well.
No one ever helps me maintain my stuff and everyone always sees fit to bitch about it or ignores it so in my opinion is that in the lack of any sort of community contribution the decisions I make are wholey justified if they result in a better product that isn't somewhat broken.
You see when you don't throw your hat in the game you have very little right to complain about how it is played. In this case in-action sometimes has consequences.
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-25, 18:42
by New Tobin Paradigm
Well.. turns out I do need the composer ui after all for blockable items.. So it all stays.. That's fine.. I will just put a try catch block around the code that is throwing so it shuts up cause it ain't fatal. Also, I am looking into wtf is up with Interlink support. I thought it would just work.. Either way there WILL be an update on the way for ABPrime that actually makes changes soonish.
Novel concept I know but...
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-25, 20:27
by Likestofish
Not terribly urgent on Pale Moon or Basilisk, although the Interlink thing is a bit out of left field...
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-25, 21:02
by New Tobin Paradigm
How is it out of left field?
Re: The Official ABPrime and EHPrime Discussion Thread
Posted: 2021-05-27, 01:29
by Likestofish
Simply unexpected.