palemoon patch,

[frostknight]

Wondering how I could make a patch to reverse this

https://repo.palemoon.org/MoonchildProd ... 1d3b25585c

You know so I don't have to manually change it all the time.


I tried to reverse how the patch works on there, but I was unsuccessful. So meh, idk. I think I did something wrong though.

[jobbautista9]

Have you tried git reverting the relevant commit (1b0fde3e10fa987b1c875ffa3c9fa9d286a56c94) from the merge commit's PR Issue #2716 (UXP)?

I'm not sure why you'd even want to force an earlier GCC version anyway. You're likely going to encounter compilation errors with code that use C++17.

[UCyborg]

How does one generally even maintain local patches with Git? Do you make the branch, commit patches, then when code gets updated, rebase that branch and hope your changes don't conflict with new changes from "upstream"?

[Moonchild]

How does one generally even maintain local patches with Git? Do you make the branch, commit patches, then when code gets updated, rebase that branch and hope your changes don't conflict with new changes from "upstream"?

Pretty much. and if they DO conflict you'll have to amend your changes.

[Moonchild]

You're likely going to encounter compilation errors with code that use C++17.

Exactly. Our dropping support for GCC 7 and 8 in a breaking way was not arbitrary. You should just build with a supported compiler version (and you can build gcc from source as well if it's not immediately available on your flavour of OS)

[frostknight]

Have you tried git reverting the relevant commit (1b0fde3e10fa987b1c875ffa3c9fa9d286a56c94) from the merge commit's PR Issue #2716 (UXP)?

I'm not sure why you'd even want to force an earlier GCC version anyway. You're likely going to encounter compilation errors with code that use C++17.

Would this also revert every patch after that?

I only want to revert that one part after all.

My gcc is too old currently, although I did find something interesting thanks to a Hyperbola dev telling me about it.

./conty.sh

Its basically similar to an archlinux appimage you can run stuff with. Thus, I might not need to anymore use it.

This is conty:

https://github.com/Kron4ek/Conty

[jobbautista9]

Would this also revert every patch after that?

It only reverts that specific commit. It's not git reset

[frostknight]

It only reverts that specific commit. It's not git reset

Fair enough, cool.

[frostknight]

Our dropping support for GCC 7 and 8 in a breaking way was not arbitrary. You should just build with a supported compiler version (and you can build gcc from source as well if it's not immediately available on your flavour of OS)

This puzzles me as I wonder why I can still build with 8 if I revert your changes.

Also not that I expect you to do this, but I feel like it would be better to leave a warning than to disable it all together.

Something like, "You are using an outdated gcc, you are likely to fail building. You would be wise to update to a newer GCC. You are on your own"

[frostknight]

Have you tried git reverting the relevant commit (1b0fde3e10fa987b1c875ffa3c9fa9d286a56c94) from the merge commit's PR Issue #2716 (UXP)?

Tried to do that it said bad revision when I tried.

Not sure why.

But doing in manually seems to work.