Non-Default Theme Issue with Weather Button

This board is for discussions, bug reports, etc. for pre-releases of the v28 milestone building on UXP.

Moderator: satrow

riiis
Lunatic
Lunatic
Posts: 445
Joined: 2014-05-17, 15:51
Location: USA

Non-Default Theme Issue with Weather Button

Unread post by riiis » 2018-08-03, 17:33

In Pale Moon 28, the "Forecast & Weather on the Button" extension's toolbar button works correctly only with the Default theme. And apparently not correctly with any other complete theme. In Pale Moon 27, "Forecast & Weather on the Button" works correctly with all complete themes. "Forecast & Weather on the Button" is an sdk extension using "sdk/ui/button/action" as its toolbar button.

Add-on button appearance (PM28) using default theme:
weather-with-default-theme-PM28.jpg
weather-with-default-theme-PM28.jpg (11.05 KiB) Viewed 335 times
Add-on button appearance (PM28) using other complete themes:
weather-with-aeromoon-theme-PM28.jpg
weather-with-aeromoon-theme-PM28.jpg (10.98 KiB) Viewed 335 times
Can the non-default themes in PM28 be fixed to show this button the same as in the default theme?

User avatar
Lootyhoof
Themeist
Themeist
Posts: 1277
Joined: 2012-02-09, 23:35
Location: United Kingdom

Re: Non-Default Theme Issue with Weather Button

Unread post by Lootyhoof » 2018-08-03, 17:43

I'll look into it.

User avatar
Lootyhoof
Themeist
Themeist
Posts: 1277
Joined: 2012-02-09, 23:35
Location: United Kingdom

Re: Non-Default Theme Issue with Weather Button

Unread post by Lootyhoof » 2018-08-03, 19:39

OK, I've found what's doing this; seems a selector changed. I won't be able to get updates out for all the themes for a little while, but until then you can use this in either userChrome.css or Stylem:

Code: Select all

.toolbarbutton-badge {
  background-color: #d90000;
  font-size: 10px;
  font-weight: bold;
  padding: 0 2px 1px;
  color: #fff;
  border-radius: 2px;
  box-shadow: 0 1px 0 hsla(0, 100%, 100%, .2) inset,
              0 -1px 0 hsla(0, 0%, 0%, .1) inset,
              0 1px 0 hsla(206, 50%, 10%, .2);
  margin: -6px 0 0 !important;
  margin-inline-end: -8px !important;
  min-width: 14px;
  max-width: 28px;
  line-height: 10px;
  text-align: center;
  -moz-stack-sizing: ignore;
}

Locked