PM28 breaks Linky Topic is solved

This board is for discussions, bug reports, etc. for pre-releases of the v28 milestone building on UXP.
dinosaur
Fanatic
Fanatic
Posts: 165
Joined: 2014-06-03, 09:26
Location: France

PM28 breaks Linky

Unread post by dinosaur » 2018-07-13, 00:11

Another addon I am using occasionally but that is extremely useful is Linky.

It works just fine with PM27 but got broken with PM28. All I get when trying to use it is the following (cryptic) message in the error console:

Code: Select all

Error: ReferenceError: linkyContext is not defined
Source File: chrome://browser/content/browser.xul Line: 1
I searched for maintained equivalents of Linky but found none that could even come close to it; the best I could find is "Snap Link Plus" v2.4.3, but it cannot auto extract links from a page and filter them by type (e.g. image links only), neither present you with a list of links with check boxes to select which to keep or remove, neither open all image links in a single tab, etc...
Last edited by dinosaur on 2018-07-13, 00:14, edited 1 time in total.

GMforker

Re: PM28 breaks Linky

Unread post by GMforker » 2018-07-13, 04:30

See Issue #155 (UXP)

You can fix it by manually editing those files:

chrome/linky.jar:context/main.js
Line 841
from:
const linkyContext = new LinkyContext();
to:
var linkyContext = new LinkyContext();

chrome/linky.jar:context/options.js
Line 17
from:
const linkyOption = new LinkyOption;
to:
var linkyOption = new LinkyOption;

chrome/linky.jar:context/select-links.js
Line 407
from:
const linkySelect = new LinkySelect;
to:
var linkySelect = new LinkySelect;

chrome/linky.jar:context/shared.js
Line 44
from:
const linkyShared = new LinkyShared;
to:
var linkyShared = new LinkyShared;

User avatar
therube
Board Warrior
Board Warrior
Posts: 1650
Joined: 2018-06-08, 17:02

Re: PM28 breaks Linky

Unread post by therube » 2018-07-13, 04:49

Looks to work, thanks.

Does PM pay attention to /META-INF/ ?
If so, you'd need to remove that.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: PM28 breaks Linky

Unread post by Moonchild » 2018-07-13, 06:32

If you make any modifications you should remove META-INF (or re-sign it, but nobody ever does that) because signatures will become invalid.
Last edited by Moonchild on 2018-07-13, 06:32, edited 1 time in total.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

dinosaur
Fanatic
Fanatic
Posts: 165
Joined: 2014-06-03, 09:26
Location: France

Re: PM28 breaks Linky

Unread post by dinosaur » 2018-07-13, 07:12

The manual fix works great, thanks ! :thumbup:

Locked