The main branch PerformanceMark.cpp of current Goanna reported an error Topic is solved

Discussions about the development and maturation of the platform code (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, athenian200

User avatar
RTXXBJ
Newbie
Newbie
Posts: 5
Joined: 2023-10-04, 14:37

The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by RTXXBJ » 2023-10-05, 05:06

As mentioned, an error occurred in PerformanceMark.cpp during platform compilation. I tried the platform corresponding to the latest versions of Palemoon and Basilisk. I also tried switching the compilers for VS2022 to VS2019, VS2017, and VS2015. I also tried replacing the C++parallel programming framework. I also tried to fix Visual Studio.At the same time, after each failure, I will delete the "obj x86_64 pc mingw32" folder and start over. but it all ended in failure. :wtf:

I feel that this should be a recent bug. Because I used Visual Studio 2019 on my old computer and successfully compiled it in November 2022 and June 2023. Unfortunately, the old computer broke down and I cannot reproduce whether it is due to a configuration issue with the new computer.

(I am Chinese and this paragraph was translated using Baidu. I apologize for any inconvenience this may have caused to your reading and understanding. :( )

Code: Select all

 2:37.88 Unified_cpp_dom_performance0.cpp
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(32): error C2061: 语法错误: 标识符“ErrorResult”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(33): error C2511: “already_AddRefed<mozilla::dom::PerformanceMark> mozilla::dom::PerformanceMark::Constructor(const mozilla::dom::GlobalObject &,const nsAString_internal &,const mozilla::dom::PerformanceMarkOptions &)”:“mozilla::dom::PerformanceMark”中没有找到重载的成员函数
 2:37.88 c:\skycity\skycity\obj-x86_64-pc-mingw32\dist\include\mozilla/dom/PerformanceMarkBinding.h(16): note: 参见“mozilla::dom::PerformanceMark”的声明
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(37): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(45): error C2061: 语法错误: 标识符“ErrorResult”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(46): error C2511: “already_AddRefed<mozilla::dom::PerformanceMark> mozilla::dom::PerformanceMark::Constructor(JSContext *,nsIGlobalObject *,const nsAString_internal &,const mozilla::dom::PerformanceMarkOptions &)”:“mozilla::dom::PerformanceMark”中没有找到重载的成员函数
 2:37.88 c:\skycity\skycity\obj-x86_64-pc-mingw32\dist\include\mozilla/dom/PerformanceMarkBinding.h(16): note: 参见“mozilla::dom::PerformanceMark”的声明
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2228: “.ThrowTypeError”的左边必须有类/结构/联合
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): note: 类型是“unknown-type”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2059: 语法错误:“)”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): error C2228: “.Throw”的左边必须有类/结构/联合
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): note: 类型是“unknown-type”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2228: “.ThrowTypeError”的左边必须有类/结构/联合
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): note: 类型是“unknown-type”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2059: 语法错误:“)”
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(76): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): error C2065: “aRv”: 未声明的标识符
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): error C2228: “.Failed”的左边必须有类/结构/联合
 2:37.88 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): note: 类型是“unknown-type”
 2:37.88
 2:37.89 In the directory  /c/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance
 2:37.89 The following command failed to execute properly:
 2:37.89 c:/skycity/skycity/obj-x86_64-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl.EXE -FoUnified_cpp_dom_performance0.obj -c -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Ic:/skycity/skycity/platform/dom/performance -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance -Ic:/skycity/skycity/platform/dom/workers -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include/nspr -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include/nss -MD -FI c:/skycity/skycity/obj-x86_64-pc-mingw32/mozilla-config.h -DMOZILLA_CLIENT -TP -nologo -wd5026 -wd5027 -Zc:sizedDealloc- -wd4752 -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -utf-8 -FS -Gw -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4595 -we4553 -GR- -Zi -O2 -GTs -GS- -Qspectre -utf-8 -Oy -Fdgenerated.pdb c:/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance/Unified_cpp_dom_performance0.cpp
 2:37.92 number_scientific.cpp
 2:37.97 mozmake.EXE[5]: *** [c:/skycity/skycity/platform/config/rules.mk;885: Unified_cpp_dom_performance0.obj] Error 1
 2:37.99 mozmake.EXE[4]: *** [c:/skycity/skycity/platform/config/recurse.mk;71: dom/performance/target] Error 2
 2:37.99 mozmake.EXE[4]: *** Waiting for unfinished jobs....
 2:38.55 Unified_cpp_components_protobuf0.cpp
 2:38.55 Warning: C4715 in c:\skycity\skycity\platform\toolkit\components\protobuf\src\google\protobuf\extension_set.cc: “google::protobuf::internal::`anonymous namespace'::is_packable”: 不是所有的控件路径都返回值
 2:38.55 c:\skycity\skycity\platform\toolkit\components\protobuf\src\google\protobuf\extension_set.cc(74) : warning C4715: “google::protobuf::internal::`anonymous namespace'::is_packable”: 不是所有的控件路径都返回值
 ......
 3:06.56 mozmake.EXE[3]: *** [c:/skycity/skycity/platform/config/recurse.mk;33: compile] Error 2
 3:06.56 mozmake.EXE[2]: *** [c:/skycity/skycity/platform/config/rules.mk;493: default] Error 2
 3:06.56 mozmake.EXE[1]: *** [c:/skycity/skycity/client.mk;407: realbuild] Error 2
 3:06.56 mozmake.EXE: *** [client.mk;165: build] Error 2
 3:06.59 49 compiler warnings present.

XXBJ@MSI /c/skycity/skycity
$
 
This is my error prompt, I apologize for not translating the specific instructions regarding the error.

Code: Select all

# Tell the build system if we're building 64-bit.
# Set this to `BUILD_64=1` for 64-bit, leave as-is for 32-bit
BUILD_64=1

# Processor architecture specific build options
if [ -n "$BUILD_64" ]; then
  BUILD_ARCH=x64
  ac_add_options --target=x86_64-pc-mingw32
  ac_add_options --host=x86_64-pc-mingw32
else
  BUILD_ARCH=x86
fi

# Automatically clobber if CLOBBER was touched
mk_add_options AUTOCLOBBER=1

# Application and target
ac_add_options --enable-application=basilisk

# Build options
# Adjust the -j parameter if you need more or fewer parallel build tasks
# Maximum supported without build errors is around 32
mk_add_options MOZ_MAKE_FLAGS="-j32"
ac_add_options --enable-optimize="-O2 -GTs -GS- -Qspectre -utf-8"

# Please see https://www.palemoon.org/redist.shtml for restrictions when using the official branding.
ac_add_options --disable-official-branding
export MC_OFFICIAL=1
export MOZILLA_OFFICIAL=1

# Only enable the internal updater if you supply automatic update infrastructure
# and have configured the relevant preferences in your branding!
ac_add_options --enable-update-channel=release
ac_add_options --disable-updater

# Enabling this only offers marginal benefits on first start and may not work on own builds
ac_add_options --disable-precompiled-startupcache

ac_add_options --enable-jemalloc
ac_add_options --enable-strip

ac_add_options --disable-parental-controls
ac_add_options --disable-accessibility
ac_add_options --disable-gamepad
ac_add_options --disable-eme
ac_add_options --disable-webrtc

ac_add_options --enable-av1
ac_add_options --enable-jxl

WIN32_REDIST_DIR="C:/Program Files/VS/2022/Preview/VC/Redist/MSVC/14.38.33030/$BUILD_ARCH/Microsoft.VC143.MFC"
WIN_UCRT_REDIST_DIR="C:/Program Files (x86)/Windows Kits/10/Redist/10.0.22621.0/ucrt/DLLs/$BUILD_ARCH"
This is my. mozconfig

If it's not a code error, please tell me what I should do

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35652
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Moonchild » 2023-10-05, 08:42

Try reducing your parallel build threads to 8 (mk_add_options MOZ_MAKE_FLAGS="-j8") and see if the error still occurs.
Are you on a 32-core processor with at least 1GB of RAM per build thread? if not, then that can cause compile errors too. I recommend never to increase the parallel build threads to more than your number of cores (and generally recommend cores-2 as a maximum so IO doesn't get bottlenecked on cpu-busy states either)

Unfortunately I can't really make heads or tails of your error log in Chinese, and don't currently have the time to look up the compiler error numbers to see their description.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
RTXXBJ
Newbie
Newbie
Posts: 5
Joined: 2023-10-04, 14:37

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by RTXXBJ » 2023-10-05, 09:40

Moonchild wrote:
2023-10-05, 08:42
Try reducing your parallel build threads to 8 (mk_add_options MOZ_MAKE_FLAGS="-j8") and see if the error still occurs.
Are you on a 32-core processor with at least 1GB of RAM per build thread? if not, then that can cause compile errors too. I recommend never to increase the parallel build threads to more than your number of cores (and generally recommend cores-2 as a maximum so IO doesn't get bottlenecked on cpu-busy states either)

Unfortunately I can't really make heads or tails of your error log in Chinese, and don't currently have the time to look up the compiler error numbers to see their description.
I tried to reduce the number of parallel threads to 8 or even 4. But they didn't solve the problem. It just took a little more time to reproduce this problem. :wtf:

Code: Select all

11:51.40 Unified_cpp_dom_performance0.cpp
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(32): error C2061: Syntax error: Identifier“ErrorResult”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(33): error C2511: “already_AddRefed<mozilla::dom::PerformanceMark> mozilla::dom::PerformanceMark::Constructor(const mozilla::dom::GlobalObject &,const nsAString_internal &,const mozilla::dom::PerformanceMarkOptions &)”:“mozilla::dom::PerformanceMark”Overloaded member function not found in
11:51.40 c:\skycity\skycity\obj-x86_64-pc-mingw32\dist\include\mozilla/dom/PerformanceMarkBinding.h(16): note: See also“mozilla::dom::PerformanceMark”Declaration of
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(37): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(45): error C2061: Syntax error: Identifier“ErrorResult”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(46): error C2511: “already_AddRefed<mozilla::dom::PerformanceMark> mozilla::dom::PerformanceMark::Constructor(JSContext *,nsIGlobalObject *,const nsAString_internal &,const mozilla::dom::PerformanceMarkOptions &)”:“mozilla::dom::PerformanceMark”Overloaded member function not found in
11:51.40 c:\skycity\skycity\obj-x86_64-pc-mingw32\dist\include\mozilla/dom/PerformanceMarkBinding.h(16): note: See also“mozilla::dom::PerformanceMark”Declaration of
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2228: “.ThrowTypeError”The left side of the must have a class/structure/union
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): note: The type is“unknown-type”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(51): error C2059: Syntax error:“)”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): error C2228: “.Throw”The left side of the must have a class/structure/union
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(57): note: The type is“unknown-type”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2228: “.ThrowTypeError”The left side of the must have a class/structure/union
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): note: The type is“unknown-type”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(65): error C2059: Syntax error:“)”
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(76): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): error C2065: “aRv”: undeclared identifier
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): error C2228: “.Failed”The left side of the must have a class/structure/union
11:51.40 c:/skycity/skycity/platform/dom/performance/PerformanceMark.cpp(77): note: The type is“unknown-type”
11:51.40
11:51.40 In the directory  /c/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance
11:51.40 The following command failed to execute properly:
11:51.40 c:/skycity/skycity/obj-x86_64-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl.EXE -FoUnified_cpp_dom_performance0.obj -c -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Ic:/skycity/skycity/platform/dom/performance -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance -Ic:/skycity/skycity/platform/dom/workers -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include/nspr -Ic:/skycity/skycity/obj-x86_64-pc-mingw32/dist/include/nss -MD -FI c:/skycity/skycity/obj-x86_64-pc-mingw32/mozilla-config.h -DMOZILLA_CLIENT -TP -nologo -wd5026 -wd5027 -Zc:sizedDealloc- -wd4752 -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -utf-8 -FS -Gw -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4595 -we4553 -GR- -Zi -O2 -GTs -GS- -Qspectre -utf-8 -Oy -Fdgenerated.pdb c:/skycity/skycity/obj-x86_64-pc-mingw32/dom/performance/Unified_cpp_dom_performance0.cpp
11:51.46 mozmake.EXE[5]: *** [c:/skycity/skycity/platform/config/rules.mk;885: Unified_cpp_dom_performance0.obj] Error 1
11:51.46 mozmake.EXE[4]: *** [c:/skycity/skycity/platform/config/recurse.mk;71: dom/performance/target] Error 2
11:51.46 mozmake.EXE[4]: *** Waiting for unfinished jobs....
11:59.32 UnifiedBindings5.cpp
12:00.01 UnifiedBindings6.cpp
12:06.26 UnifiedBindings7.cpp
12:08.73 UnifiedBindings8.cpp
12:10.34 StructuredClone.cpp
12:14.34 UnifiedBindings9.cpp
12:14.98 Unified_cpp_dom_bindings0.cpp
12:15.03 dom_bindings.lib.desc
12:15.14 mozmake.EXE[3]: *** [c:/skycity/skycity/platform/config/recurse.mk;33: compile] Error 2
12:15.14 mozmake.EXE[2]: *** [c:/skycity/skycity/platform/config/rules.mk;493: default] Error 2
12:15.14 mozmake.EXE[1]: *** [c:/skycity/skycity/client.mk;407: realbuild] Error 2
12:15.14 mozmake.EXE: *** [client.mk;165: build] Error 2
12:15.19 49 compiler warnings present.
I translated the errors expressed in Chinese using machine

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35652
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Moonchild » 2023-10-05, 11:09

Not sure why you run into the error but I don't.

Either way seems like a simple dependency issue -- even with it being built unified, for some reason you aren't getting the files bundled together to make it build.

Edit platform/dom/Performance/PerformanceMark.cpp
and add

Code: Select all

#include "mozilla/ErrorResult.h"
below the other includes at the top of the file (L10 or so)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
RTXXBJ
Newbie
Newbie
Posts: 5
Joined: 2023-10-04, 14:37

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by RTXXBJ » 2023-10-05, 13:08

Moonchild wrote:
2023-10-05, 11:09
Not sure why you run into the error but I don't.

Either way seems like a simple dependency issue -- even with it being built unified, for some reason you aren't getting the files bundled together to make it build.

Edit platform/dom/Performance/PerformanceMark.cpp
and add

Code: Select all

#include "mozilla/ErrorResult.h"
below the other includes at the top of the file (L10 or so)
I opened the platform/dom/Performance/PerformanceMark CPP, but I found in line 17 already contains. :(

Code: Select all

#include "mozilla/ErrorResult.h"

Code: Select all

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "Performance.h"

#include "GeckoProfiler.h"
#include "PerformanceEntry.h"
#include "PerformanceMainThread.h"
#include "PerformanceMark.h"
#include "PerformanceMeasure.h"
#include "PerformanceObserver.h"
#include "PerformanceResourceTiming.h"
#include "PerformanceService.h"
#include "PerformanceWorker.h"
#include "mozilla/ErrorResult.h"
#include "mozilla/dom/PerformanceBinding.h"
#include "mozilla/dom/PerformanceEntryEvent.h"
#include "mozilla/dom/PerformanceNavigationBinding.h"
#include "mozilla/dom/PerformanceObserverBinding.h"
#include "mozilla/dom/PerformanceNavigationTiming.h"
#include "mozilla/dom/MessagePortBinding.h"
#include "mozilla/IntegerPrintfMacros.h"
#include "mozilla/Preferences.h"
#include "mozilla/TimerClamping.h"
#include "WorkerPrivate.h"
#include "WorkerRunnable.h"
#include "WorkerScope.h"
......

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35652
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Moonchild » 2023-10-05, 17:54

I think you opened Performance.cpp, not PerformanceMark.cpp .... :)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
RTXXBJ
Newbie
Newbie
Posts: 5
Joined: 2023-10-04, 14:37

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by RTXXBJ » 2023-10-06, 02:04

Moonchild wrote:
2023-10-05, 17:54
I think you opened Performance.cpp, not PerformanceMark.cpp .... :)
I have also checked the Performance.cpp, which has also been included. :(

Code: Select all

#include "mozilla/ErrorResult.h"

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35652
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Moonchild » 2023-10-06, 08:52

... you didn't understand what I said?

PerformanceMark.cpp's file top looks like this:

Code: Select all

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "PerformanceMark.h"
#include "MainThreadUtils.h"
#include "mozilla/dom/PerformanceMarkBinding.h"
#include "mozilla/dom/MessagePortBinding.h"

using mozilla::dom::StructuredSerializeOptions;
using namespace mozilla::dom;

PerformanceMark::PerformanceMark(nsISupports* aParent,
                                 const nsAString& aName,
[...]
Not what you quoted, which was the top lines of Performance.cpp.
I've now made a commit to master add the line #include "mozilla/ErrorResult.h", resulting in:

Code: Select all

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "PerformanceMark.h"
#include "MainThreadUtils.h"
#include "mozilla/dom/PerformanceMarkBinding.h"
#include "mozilla/dom/MessagePortBinding.h"
#include "mozilla/ErrorResult.h"

using mozilla::dom::StructuredSerializeOptions;
using namespace mozilla::dom;

PerformanceMark::PerformanceMark(nsISupports* aParent,
                                 const nsAString& aName,
[...]
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
RTXXBJ
Newbie
Newbie
Posts: 5
Joined: 2023-10-04, 14:37

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by RTXXBJ » 2023-10-06, 09:38

Moonchild wrote:
2023-10-06, 08:52
... you didn't understand what I said?

PerformanceMark.cpp's file top looks like this:

Code: Select all

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "PerformanceMark.h"
#include "MainThreadUtils.h"
#include "mozilla/dom/PerformanceMarkBinding.h"
#include "mozilla/dom/MessagePortBinding.h"

using mozilla::dom::StructuredSerializeOptions;
using namespace mozilla::dom;

PerformanceMark::PerformanceMark(nsISupports* aParent,
                                 const nsAString& aName,
[...]
Not what you quoted, which was the top lines of Performance.cpp.
I've now made a commit to master add the line #include "mozilla/ErrorResult.h", resulting in:

Code: Select all

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "PerformanceMark.h"
#include "MainThreadUtils.h"
#include "mozilla/dom/PerformanceMarkBinding.h"
#include "mozilla/dom/MessagePortBinding.h"
#include "mozilla/ErrorResult.h"

using mozilla::dom::StructuredSerializeOptions;
using namespace mozilla::dom;

PerformanceMark::PerformanceMark(nsISupports* aParent,
                                 const nsAString& aName,
[...]

Code: Select all

14:51.10 Packaging quitter@mozilla.org.xpi...
14:51.64 218 compiler warnings present.
14:51.89 We know it took a while, but your build finally finished successfully!
To view resource usage of the build, run |mach resource-usage|.
To take your build for a test drive, run: |mach run|

Checking for un-preprocessed files... Done!

XXBJ@MSI /c/skycity/skycity
$
Maybe the translation software didn't translate well.
But there is good news. I just compiled it. I saw today that you updated the code in the repository. I cloned it and it still failed. I also tried the code a few months ago, but all failed. But after I tried to send my Visual Studio Preview (17.8.0 Preview2.0) back to the official version (17.7.4), the compilation went smoothly.
I'm not sure it will work when Microsoft releases 17.8.0.
Finally, thank you very much for your patience to help me solve the problem! :clap: :lol: :thumbup:

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35652
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Moonchild » 2023-10-06, 11:20

Thanks for letting me know of the issues with the preview. Since you've been running the preview of MSVC, maybe you could help everyone and report this to Microsoft? Feel free to refer them to this thread.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Nuck-TH
Project Contributor
Project Contributor
Posts: 204
Joined: 2020-03-02, 16:04

Re: The main branch PerformanceMark.cpp of current Goanna reported an error

Unread post by Nuck-TH » 2023-10-06, 14:41

Off-topic:
That's why you shouldn't run preview/beta/alpha versions of software unless you know what you doing, and ruled out/fixed other issues to avoid ambiguity and need to guess where is the problem.