Building fails with binutils 2.41 (ffvpx)

Discussions about the development and maturation of the platform code (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, athenian200

User avatar
micwoj92
Fanatic
Fanatic
Posts: 175
Joined: 2020-12-22, 20:57

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by micwoj92 » 2023-12-28, 21:11

You only have to patch

Code: Select all

platform/media/ffvpx/libavcodec/x86/mathops.h
Unused libav has been removed https://repo.palemoon.org/MoonchildProd ... ssues/2311

miroR
Fanatic
Fanatic
Posts: 116
Joined: 2016-05-31, 19:22

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by miroR » 2023-12-29, 03:27

micwoj92 wrote:
2023-12-28, 21:11
You only have to patch

Code: Select all

platform/media/ffvpx/libavcodec/x86/mathops.h
Unused libav has been removed https://repo.palemoon.org/MoonchildProd ... ssues/2311
Wasn't that a speedy reply! Glad to see you around!
( It's Europe here, I'va had a nap in the meantime. )

User avatar
micwoj92
Fanatic
Fanatic
Posts: 175
Joined: 2020-12-22, 20:57

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by micwoj92 » 2023-12-29, 04:44

Off-topic:
miroR wrote:
2023-12-29, 03:27
( It's Europe here, I'va had a nap in the meantime. )
Europe here too, I blame holidays on my weird sleeping pattern ;)

miroR
Fanatic
Fanatic
Posts: 116
Joined: 2016-05-31, 19:22

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by miroR » 2023-12-29, 10:22

micwoj92 wrote:
2023-12-29, 04:44
Off-topic:
miroR wrote:
2023-12-29, 03:27
( It's Europe here, I'va had a nap in the meantime. )
Europe here too, I blame holidays on my weird sleeping pattern ;)
Just if anybody else might need the patch, it works just fine.
If I'm allowed to diverge just a little:
Anywhere I can, I use Pale Moon. If I wasn't poor (truly), I would contribute financially to Pale Moon.
Why? Because I trust Pale Moon. I trust, but much less then Pale Moon, also Firefox.
People that understand the core issues today, which is surveillance and the control on people that surveillance is really about, should realize that Pale Moon is truly free libre open source software, the kind that is no friend to big brother's control on them.

dbsoft
Project Contributor
Project Contributor
Posts: 419
Joined: 2020-02-21, 17:35

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by dbsoft » 2023-12-31, 06:00

miroR wrote:
2023-12-28, 21:02
but this file does not:

Code: Select all

platform/media/libav/libavcodec/x86/mathops.h
Just apply it to the existing file. There was a duplicate copy of libavcodec which I believe was removed in a recent update.

dbsoft
Project Contributor
Project Contributor
Posts: 419
Joined: 2020-02-21, 17:35

Re: Building fails with binutils 2.41 (ffvpx)

Unread post by dbsoft » 2024-01-01, 23:15

Edit: Actually the ffvpx update actually pulled in the fix already on master. Nothing will need to be done for version 33.

I'll probably make an update to my repo and put in a pull, since it does not seem like the GCC or binutils team are going to fix this.

I personally feel this is a bug in GCC/binutils but they apparently do not feel the same.... suggesting their old behavior and clang's behavior is incorrect.

I feel the code change to keep this working is an abomination... but what are you going to do.