fieldset[disabled] input -- does it supported in UXP?

Discussions about the development and maturation of the platform code (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, athenian200

fifonik

fieldset[disabled] input -- does it supported in UXP?

Unread post by fifonik » 2020-05-20, 00:09

Code: Select all

<html>
<body>
<form>
<fieldset disabled>
	<input type="text" name="text"/>
	<input type="checkbox" name="checkbox" value="1" />
</fieldset>
</form>
</body>
</html>
Chrome, Fx, Edge -- inputs in disabled fieldset are disabled.
This works for ages: https://caniuse.com/#search=fieldset

Tn Palemoon 28.9.3 -- fields are enabled.

Is it known bug or this is not implemented intentionally?

Thanks.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35477
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by Moonchild » 2020-05-20, 00:50

That seems to be a regression, regressed 28.8.4 -> 28.9.0. Potentially the html parser work we did... ?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

New Tobin Paradigm

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by New Tobin Paradigm » 2020-05-20, 01:03

I am sure I updated the parser codegen so everything was code equal. Only difference was formatting in the generated code when I was done.

New Tobin Paradigm

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by New Tobin Paradigm » 2020-05-20, 01:34


User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by adesh » 2020-05-20, 03:12

Off-topic:
Does it make sense to have tests for such things? Catching regressions on web compatibility/standards breakage.

New Tobin Paradigm

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by New Tobin Paradigm » 2020-05-20, 04:30

We have reftests. Would you like to keep them up to date and run them each cycle? That might help.

User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by adesh » 2020-05-20, 04:57

Sure, I can try. I'll first need to learn how to build and run tests and how the in-tree test suite works in general.

New Tobin Paradigm

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by New Tobin Paradigm » 2020-05-20, 05:20

Welp.. I figured out what the issue is.. Now as for what to do about it.. I dunno. Stay tuned or watch the Issue.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35477
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by Moonchild » 2020-05-20, 09:41

Thanks for looking into this and finding the culprit, Tobin (it was tossed my way right before sleep took me so I couldn't do anything myself; nice to see progress first thing after waking up :) )
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

fifonik

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by fifonik » 2020-06-09, 04:00

Thanks, it is fixed in 28.10.0

New Tobin Paradigm

Re: fieldset[disabled] input -- does it supported in UXP?

Unread post by New Tobin Paradigm » 2020-06-09, 04:55

Obviously, since we fixed it.

Locked