Why two separate ffmpeg

Discussions about the development and maturation of the Unified XUL Platform (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, satrow

User avatar
Fedor2
Astronaut
Astronaut
Posts: 558
Joined: Mon, 11 Apr 2016, 01:26

Why two separate ffmpeg

Unread postby Fedor2 » Tue, 04 Sep 2018, 15:30

I noticed inside UXP code two directories in the media containing ffmpeg code: libav and ffvpx, and they go to the different librarys.
libav though has fewer files.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 4771
Joined: Tue, 09 Oct 2012, 19:37

Re: Why two separate ffmpeg

Unread postby New Tobin Paradigm » Tue, 04 Sep 2018, 16:01

Because that is how it is implemented.
Image

== We got to install microwave ovens / Custom kitchen deliveries / We got to move these refrigerators / We got to move these color TVs ==
http://binaryoutcast.com/ | http://thereisonlyxul.org/

User avatar
Fedor2
Astronaut
Astronaut
Posts: 558
Joined: Mon, 11 Apr 2016, 01:26

Re: Why two separate ffmpeg

Unread postby Fedor2 » Tue, 04 Sep 2018, 18:36

Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22420
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: Why two separate ffmpeg

Unread postby Moonchild » Tue, 04 Sep 2018, 21:15

And as a result you have non-vpx code living in a vpx submodule. Congratulations. I hope you never have to debug this.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

roytam1
Fanatic
Fanatic
Posts: 143
Joined: Wed, 11 Mar 2015, 07:01
Location: Hong Kong

Re: Why two separate ffmpeg

Unread postby roytam1 » Tue, 04 Sep 2018, 23:28

Fedor2 wrote:Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.


quoted from https://github.com/MoonchildProductions ... ME_MOZILLA :

Code: Select all

This directory contains files used in gecko builds from libav
(http://libav.org). The current files are from v11.3 of the library.
All source files match their path from the library's source archive.

Currently, we only use the fft portion of the library, and only on x86
based platforms. If this changes, configuration files will most likely
need to be updated.


and it is linked into lgpllibs.dll, which xul.dll unconditionally linked to.

making it link to mozavcodec.dll is just no good to me, since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 558
Joined: Mon, 11 Apr 2016, 01:26

Re: Why two separate ffmpeg

Unread postby Fedor2 » Wed, 05 Sep 2018, 00:04

since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.


This is reasonable. It is left find where else it is used.


Return to “UXP platform development”

Who is online

Users browsing this forum: No registered users and 1 guest