Page 1 of 1

Why two separate ffmpeg

Posted: 2018-09-04, 15:30
by Fedor2
I noticed inside UXP code two directories in the media containing ffmpeg code: libav and ffvpx, and they go to the different librarys.
libav though has fewer files.

Re: Why two separate ffmpeg

Posted: 2018-09-04, 16:01
by New Tobin Paradigm
Because that is how it is implemented.

Re: Why two separate ffmpeg

Posted: 2018-09-04, 18:36
by Fedor2
Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.

Re: Why two separate ffmpeg

Posted: 2018-09-04, 21:15
by Moonchild
And as a result you have non-vpx code living in a vpx submodule. Congratulations. I hope you never have to debug this.

Re: Why two separate ffmpeg

Posted: 2018-09-04, 23:28
by roytam1
Fedor2 wrote:Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.
quoted from https://github.com/MoonchildProductions ... ME_MOZILLA :

Code: Select all

This directory contains files used in gecko builds from libav
(http://libav.org). The current files are from v11.3 of the library.
All source files match their path from the library's source archive.

Currently, we only use the fft portion of the library, and only on x86
based platforms. If this changes, configuration files will most likely
need to be updated.
and it is linked into lgpllibs.dll, which xul.dll unconditionally linked to.

making it link to mozavcodec.dll is just no good to me, since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.

Re: Why two separate ffmpeg

Posted: 2018-09-05, 00:04
by Fedor2
since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.
This is reasonable. It is left find where else it is used.