Why two separate ffmpeg

Discussions about the development and maturation of the Unified XUL Platform (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, satrow

User avatar
Fedor2
Astronaut
Astronaut
Posts: 667
Joined: 2016-04-11, 01:26

Why two separate ffmpeg

Unread post by Fedor2 » 2018-09-04, 15:30

I noticed inside UXP code two directories in the media containing ffmpeg code: libav and ffvpx, and they go to the different librarys.
libav though has fewer files.

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 6023
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Why two separate ffmpeg

Unread post by New Tobin Paradigm » 2018-09-04, 16:01

Because that is how it is implemented.
Image
- The personal toolbar is the personal toolbar, not the whorebar. -
http://binaryoutcast.com/ | http://thereisonlyxul.org/ | Freenode #binaryoutcast

User avatar
Fedor2
Astronaut
Astronaut
Posts: 667
Joined: 2016-04-11, 01:26

Re: Why two separate ffmpeg

Unread post by Fedor2 » 2018-09-04, 18:36

Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24606
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Why two separate ffmpeg

Unread post by Moonchild » 2018-09-04, 21:15

And as a result you have non-vpx code living in a vpx submodule. Congratulations. I hope you never have to debug this.
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

roytam1
Fanatic
Fanatic
Posts: 161
Joined: 2015-03-11, 07:01
Location: Hong Kong

Re: Why two separate ffmpeg

Unread post by roytam1 » 2018-09-04, 23:28

Fedor2 wrote:Hmm, seems libav is used only for dom\media\webaudio, i moved all stuff into ffvpx, as deleted libav at all.
quoted from https://github.com/MoonchildProductions ... ME_MOZILLA :

Code: Select all

This directory contains files used in gecko builds from libav
(http://libav.org). The current files are from v11.3 of the library.
All source files match their path from the library's source archive.

Currently, we only use the fft portion of the library, and only on x86
based platforms. If this changes, configuration files will most likely
need to be updated.
and it is linked into lgpllibs.dll, which xul.dll unconditionally linked to.

making it link to mozavcodec.dll is just no good to me, since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 667
Joined: 2016-04-11, 01:26

Re: Why two separate ffmpeg

Unread post by Fedor2 » 2018-09-05, 00:04

since FFT/rdft routines are stable and small, while mozavcodec.dll is big, that hurts startup time.
This is reasonable. It is left find where else it is used.

Locked