ARM-related bugfixes

Discussions about the development and maturation of the Unified XUL Platform (UXP).
Warning: may contain highly-technical topics.

Moderators: trava90, satrow

User avatar
dimag0g
Newbie
Newbie
Posts: 4
Joined: 2019-10-04, 19:41

ARM-related bugfixes

Unread post by dimag0g » 2019-10-04, 21:10

Hi,

I've made a couple more fixes in order to build UXP/master for Raspbian Buster. Let me know if any of these warrant a pull request.

1. Replaced calls to undefined functions "isMarkable" and "toMarkablePointer" with calls to "isGCThing" / "toGCThing".

2. Added a missing template definition for type "unsigned char". Without a definition, template functions used in a different compilation unit result in a linker error as explained here. In this case, the call site is in "gfxTextRun::SetSpaceGlyph".

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 6049
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: ARM-related bugfixes

Unread post by New Tobin Paradigm » 2019-10-04, 22:14

We can take the first one, no problem. I don't know about the effect of the second so it may have to be ifdef'd to arm. Moonchild would know.

Please open up a couple of issues and ask. Please don't submit PRs yet, use issues and read the contribution guidelines.
Image
- Get out of bed. Resistance is futile. Wake up and assimilate the day. -
http://binaryoutcast.com/ | http://thereisonlyxul.org/ | Freenode #binaryoutcast

User avatar
dimag0g
Newbie
Newbie
Posts: 4
Joined: 2019-10-04, 19:41

Re: ARM-related bugfixes

Unread post by dimag0g » 2019-10-05, 19:59

Regarding the second change, the usual solution is to put template definition in a header file instead of the .cpp, so that template definitions are available in every compilation unit that uses them. That would be a more substantial change (especially if done for all template functions), but the advantage is that template functions are automatically defined for any type they are used with.

Post Reply