Basilisk fails to build

[stefan11111]

Decided to try building basilisk.

Code: Select all

 6:39.15 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h:110:43:   required from 'RefPtr<T>::RefPtr(T*) [with T = mozilla::dom::FilePickerParent]'
 6:39.15 /home/stefan/Downloads/Basilisk/platform/dom/ipc/FilePickerParent.h:62:9:   required from here
 6:39.15 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h:36:11: error: 'class mozilla::dom::FilePickerParent' has no member named 'AddRef'
 6:39.15    36 |     aPtr->AddRef();
 6:39.15       |     ~~~~~~^~~~~~
 6:39.15 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h: In instantiation of 'static void mozilla::RefPtrTraits<U>::Release(U*) [with U = mozilla::dom::FilePickerParent]':
 6:39.15 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h:398:40:   required from 'static void RefPtr<T>::ConstRemovingRefPtrTraits<U>::Release(U*) [with U = mozilla::dom::FilePickerParent; T = mozilla::dom::FilePickerParent]'
 6:39.15 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h:77:44:   required from 'RefPtr<T>::~RefPtr() [with T = mozilla::dom::FilePickerParent]'
 6:39.16 /home/stefan/Downloads/Basilisk/platform/dom/ipc/FilePickerParent.h:62:9:   required from here
 6:39.16 /home/stefan/Downloads/Basilisk/o/dist/include/mozilla/RefPtr.h:39:11: error: 'class mozilla::dom::FilePickerParent' has no member named 'Release'

.mozconfig

Code: Select all

ac_add_options --enable-application=basilisk
ac_add_options --disable-updater
ac_add_options --disable-accessibility
ac_add_options --disable-gconf
ac_add_options --enable-webrtc
#ac_add_options --enable-strip
#ac_add_options --enable-install-strip
#ac_add_options --enable-system-ffi
ac_add_options --disable-eme
ac_add_options --disable-gamepad
#ac_add_options --enable-optimize="-O2 -msse2 -mfpmath=sse -pipe -march=native -ftree-vectorize -ffast-math -funswitch-loops -fuse-linker-plugin -flto=4 -fdevirtualize-at-ltrans -fno-plt -fno-semantic-interposition -fno-common -falign-fun>
ac_add_options --with-pthreads
ac_add_options --disable-debug
ac_add_options --enable-jemalloc
ac_add_options --disable-dbus
ac_add_options --enable-default-toolkit="cairo-gtk3"
ac_add_options --disable-necko-wifi
ac_add_options --disable-pulseaudio
ac_add_options --disable-precompiled-startupcache
mk_add_options PYTHON=/usr/bin/python2
mk_add_options AUTOCONF=/usr/bin/autoconf-2.13
mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/o

Tried building both with and without the commented lines.

[q160765803]

Maybe some code changes are missed?
Downstream seems to have a fix for this.
https://github.com/roytam1/UXP/commit/d ... 17861c0f4a

[Moonchild]

If you want to build an application, it's always recommended that you build from a release tag. Building from the tip of the master branch is never guaranteed to work.

[stefan11111]

If you want to build an application, it's always recommended that you build from a release tag. Building from the tip of the master branch is never guaranteed to work.

Got it to build. The reason was that I was using UXP newer than the commit pointer.
I had to pass -w to it to disable all warnings because of some -werror=

[Basilisk-Dev]

As Moonchild has already stated, unless you are doing development or want to preview a new (potentially not fully implemented) feature, it is recommended that you build from the latest release tag. Glad you were able to figure it out and get it building.

I'm very surprised you were able to build it with LTO. I have not been able to get Basilisk to successfully build on Linux with LTO.

[stefan11111]

I'm very surprised you were able to build it with LTO. I have not been able to get Basilisk to successfully build on Linux with LTO.

I didn't. The optimize line is commented out.
With lto, it fails like so:

Code: Select all

25:47.45 libxul.so
40:53.30 NSModules are not ordered appropriately
40:53.34 gmake[5]: *** [/home/stefan/Downloads/Basilisk.bak/platform/config/rules.mk:773: libxul.so] Error 1
40:53.34 gmake[5]: *** Deleting file 'libxul.so'
40:53.34 gmake[4]: *** [/home/stefan/Downloads/Basilisk.bak/platform/config/recurse.mk:71: toolkit/library/target] Error 2
40:53.37 gmake[3]: *** [/home/stefan/Downloads/Basilisk.bak/platform/config/recurse.mk:33: compile] Error 2
40:53.39 gmake[2]: *** [/home/stefan/Downloads/Basilisk.bak/platform/config/rules.mk:493: default] Error 2
40:53.42 gmake[1]: *** [/home/stefan/Downloads/Basilisk.bak/client.mk:407: realbuild] Error 2
40:53.43 gmake: *** [client.mk:165: build] Error 2
40:53.49 836 compiler warnings present.

It seems to be a basilisk issue, as palemoon builds file with lto.

[q160765803]

Maybe some code changes are missed?
Downstream seems to have a fix for this.
https://github.com/roytam1/UXP/commit/d ... 17861c0f4a

and now downstream reverted all related commits and stated that it breaks e10s usage(double-free) unless related IPDL generator changes are ported.

[Moonchild]

reverted all related commits and stated that it breaks e10s usage

downstream should realize that I have consistently NOT been porting e10s related sec bugs since e10s is not supported by us. If they use e10s, they are missing a few hundred sec fixes. The vast majority of Mozilla's sec bugs are directly or indirectly related to e10s.