TabMixPlus tab title problems

Board for discussions around the Basilisk web browser.

Moderator: Basilisk-Dev

User avatar
axben
New to the forum
New to the forum
Posts: 1
Joined: 2023-03-06, 17:53

TabMixPlus tab title problems

Unread post by axben » 2023-03-06, 18:16

Although I know that you (@basilisk) are not responsible for addons, I would like to report that TabMixPlus (0.5.8.4), which used to work until the recent update to 2023.03.05, has started to have issues with displaying tabs:

a) tabs overlay each other, and
b) tabs length limits (as imposed by TMP's settings) are no longer respected.

Maybe there's sth you can do about it...

User avatar
ag0044
Moonbather
Moonbather
Posts: 55
Joined: 2012-04-28, 16:29
Location: Australia

Re: TabMixPlus tab title problems

Unread post by ag0044 » 2023-03-07, 09:27

I use Tab Mix Plus (0.5.8.4), and have Photonic (4.3.0) as my preferred theme. I was having the same problems as the OP. I reverted to the Default theme, restarted Basilisk (2023.03.04-2), and all seemed well ... for the few minutes that I stayed there. I then enabled the Photonic theme, restarted Basilisk, and the overlaying tabs problem came back almost immediately.

I then went back to Basilisk 2023.01.26, with both Photonic and Tab Mix Plus enabled, and the problem did not recur.

I hope that is of some help to ... someone?
Usually, I'm wrong. But, sometimes, I'm right.
Usually, I'm Left. But, sometimes, I'm Right.
Usually, I'm left-handed. But, sometimes, I'm right-handed.

User avatar
Basilisk-Dev
Lunatic
Lunatic
Posts: 316
Joined: 2022-03-23, 16:41
Location: Chamber of Secrets
Contact:

Re: TabMixPlus tab title problems

Unread post by Basilisk-Dev » 2023-03-07, 13:47

Hmm, I am able to replicate this. I think I know what is causing this and might be able to fix it on our end.
Basilisk Project Owner

viewtopic.php?f=61&p=230756

User avatar
Basilisk-Dev
Lunatic
Lunatic
Posts: 316
Joined: 2022-03-23, 16:41
Location: Chamber of Secrets
Contact:

Re: TabMixPlus tab title problems

Unread post by Basilisk-Dev » 2023-03-07, 18:27

I am not able to fix this on our end but I have determined the cause. We made some changes in this commit to the styling for tabs https://repo.palemoon.org/Basilisk-Dev/ ... 853d8ef922

The developer of the Tab Mix Plus addon will need to update their addon to account for the changes in that commit.
Basilisk Project Owner

viewtopic.php?f=61&p=230756

User avatar
Basilisk-Dev
Lunatic
Lunatic
Posts: 316
Joined: 2022-03-23, 16:41
Location: Chamber of Secrets
Contact:

Re: TabMixPlus tab title problems

Unread post by Basilisk-Dev » 2023-03-07, 19:55

I am going to revert the commit linked in my previous post.
Basilisk Project Owner

viewtopic.php?f=61&p=230756

User avatar
FranklinDM
Add-ons Team
Add-ons Team
Posts: 575
Joined: 2017-01-14, 02:40
Location: Philippines
Contact:

Re: TabMixPlus tab title problems

Unread post by FranklinDM » 2023-03-07, 23:36

@Basilisk-Dev rather than porting Mozilla's implementation which we avoided at Pale Moon because it changes the tab structure, you might want to follow what I did here instead. This utilizes the new crop:clip property and disabling it is just a pref toggle away if it does cause any issues.

User avatar
Basilisk-Dev
Lunatic
Lunatic
Posts: 316
Joined: 2022-03-23, 16:41
Location: Chamber of Secrets
Contact:

Re: TabMixPlus tab title problems

Unread post by Basilisk-Dev » 2023-03-08, 01:06

FranklinDM wrote:
2023-03-07, 23:36
@Basilisk-Dev rather than porting Mozilla's implementation which we avoided at Pale Moon because it changes the tab structure, you might want to follow what I did here instead. This utilizes the new crop:clip property and disabling it is just a pref toggle away if it does cause any issues.
Good idea, I do plan to implement that in the future so I'll give that a shot. Thanks!
Basilisk Project Owner

viewtopic.php?f=61&p=230756

Locked