AV1 video codec support

[UCyborg]

Changelog mentions experimental support for this codec was added at some point.

At the quick glance, it seems the browser is compiled without --enable-av1 build option, so the AV1 functionality is missing, but adding the option would enable AV1 support in the compiled binaries and add the media.av1.enabled setting in about:config.

Pale Moon has AV1 code enabled. Was it just forgotten for Basilisk?

[trava90]

Yes, this was apparently an oversight. AV1 support will be enabled in Basilisk with the next release.

[UCyborg]

Basilisk 2020.04.15 still doesn't have AV1 enabled, at least the Win32 version doesn't. I haven't tried Win64 nor any of the Linux builds.

[Moonchild]

Huh... that's weird. It -should- be enabled according to the configuration variables defined. We'll investigate.

[New Tobin Paradigm]

Yeah, I didn't know the logic for MOZ_AV1 was in mozconfigure and not ac configure and that is why confvars didn't work.

[Moonchild]

Yeah, I didn't know the logic for MOZ_AV1 was in mozconfigure and not ac configure and that is why confvars didn't work.

I didn't either

I've moved the logic to ac configure (where it belongs) so the confvars setting works. We'll probably have another build soon to enable it "for real this time"

[Fedor2]

https://tools.woolyss.com/html5-audio-video-tester/
First one freezes but sounds continue, what is possible wrong be?

[Moonchild]

what is possible wrong be?

Not powerful enough hardware to keep up with decoding?

[Fedor2]

Its powerful enough i think, i have checked on the latest firefox nightly, it plays perfectly.

[Moonchild]

Its powerful enough i think, i have checked on the latest firefox nightly, it plays perfectly.

Well if I enable AV1 here it plays just fine too.

[Fedor2]

I also have checked on linux amd e450 laptop,сertainly its not powerful at all, and video plays fine.
Huh, where to find hardware requriements, what does it loads cpu or videocard.

[Moonchild]

I think libaom is a reference implementation that will primarily use CPU to decode.

[Fedor2]

This is weird, i recently built my mingw version on winxp with old core2duo - the video plays perfect there!

[Fedor2]

More test for thought
win8 x64
Basilisk 32 - video freezes
Basilisk 64 - normal
My build of Basilisk with microsoft cl compiler - same as original basilisk
And my build with mingw compiler - video fine on x32 too, also i noticed that cl x32 only compiler eats all free memory
on files media\libaom\src\av1\common\cdef_block*, system freeze until compiled all cdef_block files, i have 6-7gb memory free.

[Moonchild]

Are you using VS2015 Update 3?

[Fedor2]

Uh sorry, i do not use VS2015 at all, i shall install it and check further.

[Moonchild]

i do not use VS2015 at all

... well, then. I'm surprised you haven't run into issues other than this before in that case.