UnMHT broken in new Basilisk update 2019.02.11

Board for discussions around the Basilisk web browser.

Moderator: Basilisk-Dev

Hoopy

UnMHT broken in new Basilisk update 2019.02.11

Unread post by Hoopy » 2019-02-13, 16:44

Hello,

Thanks for a great browser.
The new update broke UnMHT extension (sill available thru Classic Add-ons Archive).
Can you please consider a way to fix that.

Alternatively it would be great of support for MHTML is included with the browser similar to the classic Opera browser.
https://en.wikipedia.org/wiki/MHTML

Thanks

User avatar
Lootyhoof
Themeist
Themeist
Posts: 1568
Joined: 2012-02-09, 23:35
Location: United Kingdom

Re: UnMHT broken in new Basilisk update 2019.02.11

Unread post by Lootyhoof » 2019-02-13, 16:50

Does MozArchiver work for you?

http://addons.palemoon.org/addon/mozarchiver/

keuser

Re: UnMHT broken in new Basilisk update 2019.02.11

Unread post by keuser » 2019-02-26, 12:01

I'm not the OP but I'm having the same problem: after installing the latest update, any attempt to save an MHT file using unMHT results in the error "Failed to retrieve file.
TypeError: targetWindow.CSSGroupingRule is not a function".

Given that retaining access to UnMHT is one of the main reasons I'm using Basilisk rather than Firefox, I'd consider this a major problem.

I did try MozArchiver, which sometimes works but sometimes fails, requiring me to use the retry button in the downloads panel to redo it.

Even if MozArchiver consistently worked without issue, however, it seems to be missing some of UnMHT's functionality/configurability, making it a less than ideal replacement.

Given that compatibility with existing Firefox extensions is a major part of the whole point of Basilisk, I hope someone will look into this and revert whatever part of the update broke this extension.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: UnMHT broken in new Basilisk update 2019.02.11

Unread post by Moonchild » 2019-03-02, 11:58

keuser wrote:Given that compatibility with existing Firefox extensions is a major part of the whole point of Basilisk
Please point out where on the basilisk website it says this.
, I hope someone will look into this and revert whatever part of the update broke this extension.
Changes to Basilisk and UXP are unlikely to be reverted to cater to extensions. As per usual, it's the extension that will have to adapt to changes in what it extends.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Ultradrom

Re: UnMHT broken in new Basilisk update 2019.02.11

Unread post by Ultradrom » 2019-03-03, 23:33

Here is a fix for latest UnMHT 8.3.2 to work with Pale Moon 28.4:

1. Download and save latest UnMHT "unmht-8.3.2-an+fx+sm+tb.xpi"
( Very useful addon for search old addons and download any versions : "Classic Add-ons Archive" )

2. Unpack via any zip_unpacker downloaded xpi-file "unmht-8.3.2-an+fx+sm+tb.xpi" to empty new_dir
( For some zip-unpackers, before unpack, need to change "xpi" file extension to "zip" )

3. Inside new_dir open file "..../res/modules/UnMHTSave.jsm" in text editor
search for text line:

Code: Select all

if (rule instanceof targetWindow.CSSGroupingRule) {
replace with this line:

Code: Select all

if (rule.cssRules) { //// FIX FOR PALEMOON_28_4 ////  Old code:// if (rule instanceof targetWindow.CSSGroupingRule) {
4. Save and close file "..../res/modules/UnMHTSave.jsm"

5. Inside new_dir, pack to new_zip-file all content (files and folders)

6. Change new_zip-file extension from "zip" to "xpi". ( Example: "UnMHT_8_3_2_FIXED.xpi" )

7. If UnMHT addon already installed : remove it ( Menu : Tools/Addons/UnMHT = Remove )

8. Install fixed UnMHT via drag-and-drop new_xpi-file to Palemoon window

Thats all.


P.S. List of useful addons for me. Tested in Pale Moon 28.4.0:
Classic Add-ons Archive 1.2.3
Abduction! - FIXED 4.0.2 (Saving page selection to image. Can be replaced by : Shift+F2, "screenshot --fullpage" )
Addons Memory Usage - Intika MoD 12.9
Dismiss The Overlay 1.0.3
Greasemonkey for Pale Moon 3.31.4
Hide Caption Titlebar Plus 4.1.0
Menu Wizard 5.10
NoScript 5.1.9
Open With 6.8.6
PopVideo 0.6.8.1
Self-Destructing Cookies for Pale Moon 1.0.4.13
Stylem 2.2.4
Tile Tabs 14.12
Tree Style Tabs for Pale Moon 0.0.5
uBlock Origin 1.16.4.8
UnMHT 8.3.2
User Agent Switcher 0.7.3.1
??MozArchiver 2.0.1 (replaced with UnMHT)
??YouTube Video Player Pop Out 49.0 (buggy but work, replaced with PopVideo 0.6.8.1)
Attachments
Pale Moon for Linux.png

Hoopy

Re: UnMHT broken in new Basilisk update 2019.02.11

Unread post by Hoopy » 2019-03-06, 06:51

@Ultradrom,

Thank you for the info.
It seems to work now.

If possible, adding MHTML support to the browser would be great, and it will avoid any of these issues in the future.

Thanks again
Attachments
unmht-8.3.2-fixed-an+fx+sm+tb.xpi
UnMHT 8.3.2 FIXED.
SHA1: f1ef93a44574d062d5131fbd4bbe8b7a3be5c574
(499.7 KiB) Downloaded 436 times

Locked