Question about installing addons

Board for discussions around the Basilisk web browser.

Moderator: satrow

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Question about installing addons

Unread postby thosrtanner » Thu, 03 Jan 2019, 22:06

I have an addon for palemoon (inforss) and I thought I'd try adding it to basilisk to see what happened.

I dropped the xpi into basilisk and nothing appeared to happen. So I went to about:addons. The addon icon is there, it has a title of null, and there is a small blue bar at the left and the text downloaded. And the xpi file is still open, as I cant delete it till i quit basilisk.

I'm at a bit of a loss as to how to proceed from here.

NotWorthKnowing
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat, 26 May 2018, 18:13

Re: Question about installing addons

Unread postby NotWorthKnowing » Fri, 04 Jan 2019, 00:26

Install fails with no visible feedback. In Error Console:
1546561313898 addons.xpi WARN Add-on inforss-reloaded@addons.palemoon.org is not compatible with application version.
1546561313902 addons.repository DEBUG cacheAddons: enabled false IDs ["inforss-reloaded@addons.palemoon.org"]
EDIT: I did find 2 "Null" entries for it down among the disabled extensions (one for each attempt). They disappeared when I canceled the download (and that was from local install).
Win10ho 64 1709 4GBram AMD A6 :: Pale Moon 28.2.0 Po :coffee:++

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Fri, 04 Jan 2019, 23:19

Yes, i've tweaked my copy to put the firefox identifier back into install.rdf. I get this in the error console (thanks for reminding me to look there!):

Code: Select all

Timestamp: 04/01/2019 23:16:05
Error: A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Fri Jan 04 2019 23:15:17 GMT+0000 (GMT Standard Time)
Full Message: TypeError: (new TypeError("this.addon._repositoryAddon is null", "resource://gre/modules/addons/XPIProvider.jsm", 5683)) is not iterable
Full Stack: init/<@resource://gre/modules/addons/XPIProvider.jsm:6033:1
TaskImpl_run@resource://gre/modules/Task.jsm:320:42
process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:935:21
walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11

Source File: resource://gre/modules/addons/XPIProvider.jsm
Line: 6033
Source Code:
6033

NotWorthKnowing
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat, 26 May 2018, 18:13

Re: Question about installing addons

Unread postby NotWorthKnowing » Sat, 05 Jan 2019, 02:47

Changing max Fx version to 56.* (and TB to 59.*) seemed to help, sort of (eliminated one error). But still doesn't install.
Win10ho 64 1709 4GBram AMD A6 :: Pale Moon 28.2.0 Po :coffee:++

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Sat, 05 Jan 2019, 07:30

So what is different between palemoon and basilisk?

yami_
Lunatic
Lunatic
Posts: 283
Joined: Thu, 26 Apr 2018, 11:05

Re: Question about installing addons

Unread postby yami_ » Sat, 05 Jan 2019, 11:41

User interface, add-on manager, search service, target user base and probably a few other things.
cat came back from Berkeley waving flags -- rob pike

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1626
Joined: Thu, 03 Sep 2015, 19:47
Location: UA
Contact:

Re: Question about installing addons

Unread postby JustOff » Sat, 05 Jan 2019, 11:49

thosrtanner wrote:Yes, i've tweaked my copy to put the firefox identifier back into install.rdf. I get this in the error console

[..]

So what is different between palemoon and basilisk?

In Firefox (and Basilisk) you must provide `em:name` for every locale listed in install.rdf. This superfluous requirement was removed from Pale Moon in Issue #945 (Pale-Moon).
Here are the add-ons I made in a spare time. That was fun!

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Sat, 05 Jan 2019, 12:30

JustOff wrote:
thosrtanner wrote:Yes, i've tweaked my copy to put the firefox identifier back into install.rdf. I get this in the error console

[..]

So what is different between palemoon and basilisk?

In Firefox (and Basilisk) you must provide `em:name` for every locale listed in install.rdf. This superfluous requirement was removed from Pale Moon in Issue #945 (Pale-Moon).


Could the same change be done for basilisk?

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Sat, 05 Jan 2019, 16:17

Further note - after giving the extension a fake name in my *current locale* (so the problem is actually slightly worse than mentioned in your original pull request - if you don't provide a name in the currently selected locale, the install will hang. not just in the us locale)), I get a bit further. However, it appears to be not loading up parts of the overlay - it is clearly running the code in the <script> tag but doesn't appear to have loaded any of the other elements into the document so that document.getElementById is returning null values

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1626
Joined: Thu, 03 Sep 2015, 19:47
Location: UA
Contact:

Re: Question about installing addons

Unread postby JustOff » Sat, 05 Jan 2019, 20:50

thosrtanner wrote:Could the same change be done for basilisk?

Theoretically yes, although I’m not sure that this edge case is really worth the attention, considering that all Firefox extensions that are compatible with Basilisk already satisfy the requirement to specify a name in each locale. I think it will be easier if you simply do the same.

thosrtanner wrote:However, it appears to be not loading up parts of the overlay - it is clearly running the code in the <script> tag but doesn't appear to have loaded any of the other elements into the document so that document.getElementById is returning null values

You should not forget that Basilisk does not have an addon bar, and even if you install Status-4-Evar, you can't expect it to be created before your add-on is initialized. However, if you add the Inforss panel to the main toolbar and restart the browser, then everything seems to work fine.
Here are the add-ons I made in a spare time. That was fun!

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Sun, 06 Jan 2019, 08:00

JustOff wrote:
thosrtanner wrote:Could the same change be done for basilisk?

Theoretically yes, although I’m not sure that this edge case is really worth the attention, considering that all Firefox extensions that are compatible with Basilisk already satisfy the requirement to specify a name in each locale. I think it will be easier if you simply do the same.

Well I do have 25 localisations in there

JustOff wrote:
thosrtanner wrote:However, it appears to be not loading up parts of the overlay - it is clearly running the code in the <script> tag but doesn't appear to have loaded any of the other elements into the document so that document.getElementById is returning null values

You should not forget that Basilisk does not have an addon bar, and even if you install Status-4-Evar, you can't expect it to be created before your add-on is initialized. However, if you add the Inforss panel to the main toolbar and restart the browser, then everything seems to work fine.


I'll have a play with doing that automatically then

User avatar
JustOff
Localization Coordinator
Localization Coordinator
Posts: 1626
Joined: Thu, 03 Sep 2015, 19:47
Location: UA
Contact:

Re: Question about installing addons

Unread postby JustOff » Sun, 06 Jan 2019, 11:59

thosrtanner wrote:Well I do have 25 localisations in there

Well, see Issue #925 (UXP).
Here are the add-ons I made in a spare time. That was fun!

thosrtanner
Fanatic
Fanatic
Posts: 159
Joined: Sat, 10 May 2014, 18:19
Location: UK

Re: Question about installing addons

Unread postby thosrtanner » Sun, 06 Jan 2019, 18:49

JustOff wrote:
thosrtanner wrote:Well I do have 25 localisations in there

Well, see Issue #925 (UXP).


You de man! Thank you!


Return to “Basilisk”

Who is online

Users browsing this forum: No registered users and 1 guest