When flex-box full support is planned?

Board for discussions around the Basilisk web browser.

Moderator: satrow

bitairy
Moongazer
Moongazer
Posts: 9
Joined: Sun, 31 Dec 2017, 06:37

When flex-box full support is planned?

Unread postby bitairy » Wed, 26 Sep 2018, 19:41

Hello,
I found that the latest 2018.09.05 (64-bit) Basilisk browser does not show the part of the html page in which the flex-box is used. (flex-wrap: wrap;)
I would like to know when you plan to do support flex-box in the browser
Thanks.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22420
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: When flex-box full support is planned?

Unread postby Moonchild » Wed, 26 Sep 2018, 21:25

Flexboxes are (and have been) fully supported in Basilisk.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

bitairy
Moongazer
Moongazer
Posts: 9
Joined: Sun, 31 Dec 2017, 06:37

Re: When flex-box full support is planned?

Unread postby bitairy » Thu, 27 Sep 2018, 04:27

Please compare how the same code is displayed by different browsers https://jsfiddle.net/to73wyfs/
Chrome and the latest Firefox show the flexboxes on the page under the text "Flexbox below" and Basilisk no.
Thanks.

adisib
Lunatic
Lunatic
Posts: 367
Joined: Sat, 13 Jun 2015, 03:34
Location: KY

Re: When flex-box full support is planned?

Unread postby adisib » Thu, 27 Sep 2018, 05:08

It isn't a flexbox issue. It is a javascript issue with that website.

The website throws a syntax error for the following snippet:

Code: Select all

ChoosedPlan.prototype.emit = function({title, ...data}) {
        this.title.innerHTML = `<span style="color: #2196f3">You chose </span>${title}`;
        this.data = data;
        this.render(data);
    }


UXP doesn't support spread properties for object literals, which is part of a proposal. See:
https://github.com/tc39/proposal-object-rest-spread
(Edit: This was added in Firefox 55)
Last edited by adisib on Thu, 27 Sep 2018, 05:11, edited 3 times in total.

bitairy
Moongazer
Moongazer
Posts: 9
Joined: Sun, 31 Dec 2017, 06:37

Re: When flex-box full support is planned?

Unread postby bitairy » Thu, 27 Sep 2018, 05:26

Most likely this is the problem of only one site, but still I would like Basilisk to remain the best and show any pages if this possible.
Perhaps in the next Basilisk builds, there will not be such a problem.

Thank you for your explanations. :thumbup:

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22420
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: When flex-box full support is planned?

Unread postby Moonchild » Thu, 27 Sep 2018, 06:17

It is a draft proposal. We will stick to standards first, and so should websites.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

User avatar
Sajadi
Keeps coming back
Keeps coming back
Posts: 944
Joined: Fri, 19 Apr 2013, 00:46

Re: When flex-box full support is planned?

Unread postby Sajadi » Thu, 27 Sep 2018, 08:45

bitairy wrote:Most likely this is the problem of only one site, but still I would like Basilisk to remain the best and show any pages if this possible.
Perhaps in the next Basilisk builds, there will not be such a problem.

Thank you for your explanations. :thumbup:


Something which should not be forgotten - As this is partly a community based browser project, i am pretty sure Moonchild would be happy about people who submit patches for features they want. So, if you want to have that in Basilisk - either create a pach on your own or find someone who can implement it for you!

For example - you could visit some coding related boards on the web and get some help/hints there which pushes you on the right track for where to start :)
Last edited by Sajadi on Thu, 27 Sep 2018, 08:57, edited 6 times in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22420
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: When flex-box full support is planned?

Unread postby Moonchild » Mon, 01 Oct 2018, 08:38

Created Issue #802 (UXP) to track this enhancement. Patches are indeed welcome; it doesn't seem to have too many dependencies on other code so should be fairly straightforward to implement.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne


Return to “Basilisk”

Who is online

Users browsing this forum: Google [Bot] and 2 guests