Page 1 of 1

Page crashes Basilisk

Posted: 2018-05-16, 02:36
by SpockFan02
This page: http://brawlhalla.wikia.com/wiki/Yumiko
crashes Basilisk ("Serpent," my build from today, last commit c9d1a79bd076f39e11d0bf9ca7f543ec910cf2b2 "Don't linkify data: or javascript: URLs in the web console." by Moonchild Tue May 15 21:52:48 2018 +0200, on macOS 10.12.6) immediately when loading it. Restarting allows the session to be restored but not with the tab that this page was in.

Interestingly, the Tobigator (my loving name for Tobin's Borealis navigator, but it's not really Borealis because Borealis does not support macOS) is not crashed by this page. This leads me to believe that either it's something Basilsik-specific or some change to UXP made between when I built the navigator and today when I built Basilisk most recently that causes the crash. I will investigate by building the navigator on a more recent version of UXP and report back. I guess see if y'all get the same crash on other OSs or what have you.

Please move this to the UXP development board if it fits better there than here in Basilisk.

Re: Page crashes Basilisk

Posted: 2018-05-16, 02:49
by kelendral
Basilisk 2018.05.15 64bit page loaded successfully here.

Re: Page crashes Basilisk

Posted: 2018-05-16, 02:50
by SpockFan02
What Operating System?

Re: Page crashes Basilisk

Posted: 2018-05-16, 02:55
by kelendral
Windows 10 64bit. Sorry I should have had that in the reply as well.

Re: Page crashes Basilisk

Posted: 2018-05-16, 03:14
by SpockFan02
I just built binoc-central/navigator (with a modified app.mozbuild) on the same UXP as Basilisk, and now it crashes when loading http://brawlhalla.wikia.com/wiki/Yumiko. There's some problem with UXP on macOS, introduced somewhat recently. Other than building from different UXP commits to narrow down the timeframe, what's the best advice on how to find the cause of the crash? It's reproducible every time as far as I can tell.

Re: Page crashes Basilisk

Posted: 2018-05-16, 03:32
by roytam1
SpockMan02 wrote:I just built binoc-central/navigator (with a modified app.mozbuild) on the same UXP as Basilisk, and now it crashes when loading http://brawlhalla.wikia.com/wiki/Yumiko. There's some problem with UXP on macOS, introduced somewhat recently. Other than building from different UXP commits to narrow down the timeframe, what's the best advice on how to find the cause of the crash? It's reproducible every time as far as I can tell.
You may need revision bisecting to find out if there is a commit that breaks:

try building an older revision (for example, 1 month ago) to see if it crash or not?
if it still crashes, try something "more" old revision
if it doesn't crash, try newer revision (for example, 2 weeks ago from now)

Re: Page crashes Basilisk

Posted: 2018-05-16, 19:09
by Moonchild
Spockman: what OS are you on?

Unable to reproduce the crash on x86/Win7 -- so it seems Windows isn't affected.

Assuming linux: see if flipping gfx.xrender.enabled to "false" improves things.

Re: Page crashes Basilisk

Posted: 2018-05-17, 13:37
by Latitude
SpockMan02 wrote:Tobigator
What the heck is this?

Is this name of a browser made by NewTobinParadigm?

Re: Page crashes Basilisk

Posted: 2018-05-17, 14:53
by Isengrim
Off-topic:
Latitude wrote:What the heck is this?

Is this name of a browser made by NewTobinParadigm?
SpockMan02 wrote:Tobigator (my loving name for Tobin's Borealis navigator, but it's not really Borealis because Borealis does not support macOS)
https://github.com/binoc-central/navigator

Re: Page crashes Basilisk

Posted: 2018-05-18, 23:04
by SpockFan02
Off-topic:
What Isengrim linked is indeed what I was talking about. I modified app.mozbuild to allow building for Darwin, and it works like a charm, but given how Tobin reminds me that Pale Moon on macOS isn't really Pale Moon (and he has a point since it's different internally in many ways), I figured I'd be respectful and not call it Borealis, since its creator did not intend for Borealis to be used on macOS. Also, 'the Tobi[n]gator' sounds cool. Which is better, with or without the 'n?' (Although maybe I shouldn't use Tobin's name.)
Moonchild: MacOS 10.12.6 "Sierra." I cannot find the pref you suggested flipping in about:config.

The crash still occurs in Basilisk built from commit b3ebf5ea2fc031edaf5e2a006fd3c33d95caadb8 "Fix missing include in Skia SafeMath."

Does

Code: Select all

###!!! [Parent][MessageChannel] Error: (msgtype=0x2C0081,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
mean anything to anyone? I just noticed that that is output in Terminal when the crash occurs (the application was running from

Code: Select all

./mach run
).

Re: Page crashes Basilisk

Posted: 2018-05-18, 23:06
by Moonchild
The setting I indicated is Linux/X11 only.
I can't help your with Mac.

Re: Page crashes Basilisk

Posted: 2018-05-18, 23:09
by SpockFan02
I understand. Hopefully this afternoon/tonight/this weekend I'll be able to figure out which commit introduced this crash.

Re: Page crashes Basilisk

Posted: 2018-05-18, 23:16
by roytam1
SpockMan02 wrote:I understand. Hopefully this afternoon/tonight/this weekend I'll be able to figure out which commit introduced this crash.
you may need to bisect revisions to find out problematic revision:
https://forum.palemoon.org/viewtopic.ph ... 64#p141364

Re: Page crashes Basilisk

Posted: 2018-05-18, 23:18
by SpockFan02
Yes, that is what I plan on doing, thank you.

Re: Page crashes Basilisk

Posted: 2018-05-19, 04:42
by SpockFan02
I built Basilisk from commit 626419cbe2a789760d45dc87fcff1a7ad221d04d by New Tobin Paradigm Mon May 14 18:29:41 2018 -0400 "Merge pull request #356 from JustOff/PR_ssuao_revert_1148544 / Revert incorrect UAO optimization that broke SSUAO," and it does not crash when loading the page.

Re: Page crashes Basilisk

Posted: 2018-05-19, 05:26
by SpockFan02
I cannot reproduce the crash in Basilisk built from commit 7bd7473702918934b4f5751a583c3f459bb06c7b by wolfbeast on Tue May 15 17:48:16 2018 +0200 "Add omitted Skia "Safe Math" includes."

Re: Page crashes Basilisk

Posted: 2018-05-19, 06:36
by SpockFan02
No crash on 0c994ed0963e1552b95708495d58ef193c48fc3c ("Consistently use PR memory functions.").

Re: Page crashes Basilisk

Posted: 2018-05-19, 08:36
by SpockFan02
I found it. Commit 41cbe2d931d2742bb8dd6240eae9599e3bf3a512
Author: wolfbeast <mcwerewolf@gmail.com>
Date: Tue May 15 21:37:22 2018 +0200

Merge libhyphen fix from upstream.

Basilisk, Pale Moon (28), and Borealis* all crash when loading http://brawlhalla.wikia.com/wiki/Yumiko on that commit or later on macOS 10.12.6 (and I assume other versions of macOS).
Off-topic:
By the way, I'm no longer seeing that error at the command line, so it's likely unrelated.
Edit: I opened UXP issue #374.

Re: Page crashes Basilisk

Posted: 2018-05-21, 08:38
by Latitude

Re: Page crashes Basilisk

Posted: 2018-05-21, 09:57
by Moonchild
The UXP issue has been resolved and verified to fix these crashes.