28.8.0 (build error --with-system-libevent)

The place to report Pale Moon specific bugs on Linux and other operating systems.
Locked
User avatar
biopsin
Moon lover
Moon lover
Posts: 89
Joined: 2016-02-07, 17:15

28.8.0 (build error --with-system-libevent)

Post by biopsin » 2019-12-17, 10:56

Heya,
just what to report Pale Moon 28.8.0 fail if --with-system-libevent is set.
before line 148 a missing elif in ../ipc/chromium/moz.build

Code: Select all

elif not CONFIG['MOZ_SYSTEM_LIBEVENT']:
    LOCAL_INCLUDES += ['src/third_party/libevent/linux']
and also a missing indent (space) @ the line 142 infront SOURCES +=

Code: Select all

if os_solaris:
    SOURCES += [
Thank you again for all the hard work you have put into this !!
A token of my appreciation is on it's way :thumbup:
voidlinux_x64 glibc-2.32 / Palemoon_latest release (gcc-10.2.1)

vannilla
Board Warrior
Board Warrior
Posts: 1482
Joined: 2018-05-05, 13:29

Re: 28.8.0 (build error --with-system-libevent)

Post by vannilla » 2019-12-17, 18:45

Well, building with system libraries is not supported, so you shouldn't really do that.
Of course it's not wrong to report this bug, just know that if you are going to use a build compiled with system libraries, you will not receive any support in case of issues.

User avatar
athenian200
Contributing developer
Contributing developer
Posts: 382
Joined: 2018-10-28, 19:56
Location: Texas
Contact:

Re: 28.8.0 (build error --with-system-libevent)

Post by athenian200 » 2019-12-17, 23:31

Well, this is embarrassing. I didn't notice that missing fourth space because it still builds fine and includes the sources for me even without it. It's uneven and looks wrong, though. All the humans finding my typos months after the fact is a little awkward. I must look like the sloppiest programmer alive. Oh, well...

As for that LOCAL_INCLUDES thing, that oversight is because I never bothered testing it with system libraries since it was my understanding that we would never need to use those. I definitely need to add that fourth space, but I'm not sure whether I need to fix building with system libraries or not.
"The rising sun will eventually set / A newborn's life will fade. / From sun to moon, moon to sun... / Give peaceful rest to the living dead." — The Legend of Zelda: Ocarina of Time

Image

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8961
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: 28.8.0 (build error --with-system-libevent)

Post by New Tobin Paradigm » 2019-12-17, 23:36

Fix the indent error. As for the systemlib bit, put that in the category of if you care enough to then do it if not, then don't.
As a young boy, I dreamed of being a baseball.
But tonight I say, we must move forward, not backward; upward, not forward; and always twirling, twirling, twirling towards freedom!

Image

Tony0945
Fanatic
Fanatic
Posts: 100
Joined: 2015-08-22, 23:59
Location: Chicago suburbs

Re: 28.8.0 (build error --with-system-libevent)

Post by Tony0945 » 2019-12-19, 18:20

Thanks biopsin!
I came here to find out what version of libevent was bundled because I couldn't build unbundled and came across this thread.

For anyone else using portage (Gentoo, Funtoo, Void...) here's the patch for your ebuild:
--- a/ipc/chromium/moz.build 2019-12-19 10:55:37.981447770 -0600
+++ b/ipc/chromium/moz.build 2019-12-19 10:58:33.281447322 -0600
@@ -143,9 +143,9 @@
'src/base/atomicops_internals_x86_gcc.cc',
'src/base/process_util_linux.cc',
'src/base/time_posix.cc',
-]
-
-LOCAL_INCLUDES += ['src/third_party/libevent/linux']
+ ]
+elif not CONFIG['MOZ_SYSTEM_LIBEVENT']:
+ LOCAL_INCLUDES += ['src/third_party/libevent/linux']

ost = CONFIG['OS_TEST']
if '86' not in ost and 'arm' not in ost and 'aarch64' != ost and 'mips' not in ost:
Not sure if "elif" is correct vs "if", but since I'm not running solaris, it doesn't matter to me.

Locked