28.5.0 broken on Mac OS X

The place to report Pale Moon specific bugs on Linux and other operating systems.

Moderator: satrow

User avatar
wicknix
Fanatic
Fanatic
Posts: 118
Joined: 2018-03-26, 04:47
Location: Wisconsin, USA

28.5.0 broken on Mac OS X

Unread post by wicknix » 2019-05-02, 04:50

I would like another person who can build on OS X to verify, but i've tried building on 10.7, 10.9 and 10.11 and all the builds fail in the same place. As you know i haven't had issues with any previous releases. Here is the error:

Code: Select all

14:13.76 libintl_uconv.a.desc
16:10.14 /Users/matt/Development/UXP-PM28.5.0_Release/accessible/base/NotificationController.cpp:878:21: error: unknown type name 'TabChild'; did you mean 'dom::TabChild'?
16:10.14         static_cast<TabChild*>(tabChild.get())->
16:10.14                     ^~~~~~~~
16:10.14                     dom::TabChild
16:10.14 /Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/dist/include/mozilla/dom/TabChild.h:243:7: note: 'dom::TabChild' declared here
16:10.14 class TabChild final : public TabChildBase,
16:10.14       ^
16:10.98 1 error generated.
16:11.05 
16:11.05 In the directory  /Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/accessible/base
16:11.05 The following command failed to execute properly:
16:11.06 /opt/local/bin/clang++-mp-6.0 -std=gnu++11 -o NotificationController.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/base -I/Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/accessible/base -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/generic -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/html -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/ipc -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/ipc/other -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/xpcom -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/xul -I/Users/matt/Development/UXP-PM28.5.0_Release/dom/base -I/Users/matt/Development/UXP-PM28.5.0_Release/dom/xbl -I/Users/matt/Development/UXP-PM28.5.0_Release/ipc/chromium/src -I/Users/matt/Development/UXP-PM28.5.0_Release/layout/generic -I/Users/matt/Development/UXP-PM28.5.0_Release/layout/style -I/Users/matt/Development/UXP-PM28.5.0_Release/layout/svg -I/Users/matt/Development/UXP-PM28.5.0_Release/layout/xul -I/Users/matt/Development/UXP-PM28.5.0_Release/layout/xul/tree -I/Users/matt/Development/UXP-PM28.5.0_Release/accessible/mac -I/Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/_ipdlheaders -I/Users/matt/Development/UXP-PM28.5.0_Release/ipc/chromium/src -I/Users/matt/Development/UXP-PM28.5.0_Release/ipc/glue -I/Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/dist/include -I/Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/dist/include/nspr -I/Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /Users/matt/Development/UXP-PM28.5.0_Release/obj-x86_64-apple-darwin15.6.0/mozilla-config.h -MD -MP -MF .deps/NotificationController.o.pp -Qunused-arguments -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wthread-safety -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-unknown-warning-option -Wno-return-type-c-linkage -isysroot /Developer/SDKs/MacOSX10.8.sdk -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -msse2 -mfpmath=sse -pthread -pipe -g -O2 -fomit-frame-pointer -Wno-error=shadow /Users/matt/Development/UXP-PM28.5.0_Release/accessible/base/NotificationController.cpp
16:11.07 make[5]: *** [NotificationController.o] Error 1
16:11.07 make[4]: *** [accessible/base/target] Error 2
16:11.07 make[4]: *** Waiting for unfinished jobs....
16:57.00 liblayout_generic.a.desc
16:57.80 make[3]: *** [compile] Error 2
16:57.80 make[2]: *** [default] Error 2
16:57.80 make[1]: *** [realbuild] Error 2
16:57.80 make: *** [build] Error 2
16:57.85 48 compiler warnings present.
Any Ideas?
Silence is golden, but duct tape is silver...

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24459
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: 28.5.0 broken on Mac OS X

Unread post by Moonchild » 2019-05-02, 05:18

First off, don't build Pale Moon with accessibility enabled. It's not supposed to have it.
Secondly, this probably need s "using namespace mozilla::dom" somewhere; it's some deprot from no longer building it unified.
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

User avatar
wicknix
Fanatic
Fanatic
Posts: 118
Joined: 2018-03-26, 04:47
Location: Wisconsin, USA

Re: 28.5.0 broken on Mac OS X

Unread post by wicknix » 2019-05-02, 05:28

Ok, but i'm curious. I've been using the same mozconfig ever since pm28 was released. Never had this happen before. I don't have accessibility enabled in my mozconfig, nor have i had to disable it in the past. I'll keep trying, but nothing changed on my end to warrant the build failures.

Cheers
Silence is golden, but duct tape is silver...

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24459
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: 28.5.0 broken on Mac OS X

Unread post by Moonchild » 2019-05-02, 05:35

wicknix wrote:
2019-05-02, 05:28
Ok, but i'm curious. I've been using the same mozconfig ever since pm28 was released.
Then you've built it incorrectly all this time ;)
wicknix wrote:
2019-05-02, 05:28
Never had this happen before.
That's because building Accessibility on OS X wasn't broken before. It is at the moment.
wicknix wrote:
2019-05-02, 05:28
I don't have accessibility enabled in my mozconfig, nor have i had to disable it in the past.
It's enabled by default and you have to explicitly disable it for Pale Moon. Wasn't your mozconfig looked over for proper component selection?
wicknix wrote:
2019-05-02, 05:28
but nothing changed on my end to warrant the build failures
No, as said, you've done it incorrectly all this time. That fact is just now exposed because you're trying to include a component that is not in the intended build and happened to have build bustage. (Linux suffers from the same issue if you're trying to build with accessibility)
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

User avatar
adesh
Astronaut
Astronaut
Posts: 721
Joined: 2017-06-06, 07:38

Re: 28.5.0 broken on Mac OS X

Unread post by adesh » 2019-05-02, 13:29

I build Pale Moon with official-like config - accessibility disabled and it compiles just fine here.

User avatar
wicknix
Fanatic
Fanatic
Posts: 118
Joined: 2018-03-26, 04:47
Location: Wisconsin, USA

Re: 28.5.0 broken on Mac OS X

Unread post by wicknix » 2019-05-03, 00:38

Wasn't your mozconfig looked over for proper component selection?
Yes. When we updated the Mac developer wiki. That was never mentioned. Anyway, no biggy. Simple solution. Thanks.

Cheers
Silence is golden, but duct tape is silver...

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 5890
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: 28.5.0 broken on Mac OS X

Unread post by New Tobin Paradigm » 2019-05-03, 02:59

When accessibility was taken out of unified building, the mac bits weren't dealt with but it was mentioned. I'd be solving the build issues if I were you wicknix..

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24459
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: 28.5.0 broken on Mac OS X

Unread post by Moonchild » 2019-05-03, 08:09

It'll have to be solved either way because of other application building on UXP.
Please check the file that errors and add a using namespace clause near the top, see if that fixes it
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

User avatar
adesh
Astronaut
Astronaut
Posts: 721
Joined: 2017-06-06, 07:38

Re: 28.5.0 broken on Mac OS X

Unread post by adesh » 2019-05-04, 11:06

@wicknix,

I've managed to fix the accessibility build on Mac. Can you please verify it builds fine for you with this patch applied?
Attachments
deunify-accessibility.patch
(6.99 KiB) Downloaded 9 times

Goodydino
Astronaut
Astronaut
Posts: 512
Joined: 2017-10-10, 21:20

Re: 28.5.0 broken on Mac OS X

Unread post by Goodydino » 2019-05-04, 19:22

What does this bug do? I have not seen any problems with this version of Pale Moon. Does its effect depend on a certain setting in about:config?

User avatar
Nigaikaze
Board Warrior
Board Warrior
Posts: 1096
Joined: 2014-02-02, 22:15
Location: Chicago, IL, USA

Re: 28.5.0 broken on Mac OS X

Unread post by Nigaikaze » 2019-05-04, 20:29

Goodydino wrote:
2019-05-04, 19:22
What does this bug do?
For people who are compiling Pale Moon from source, it prevents PM from being built properly when accessibility is not disabled. If you are already running a compiled executable, you won't encounter this problem.
Nichi nichi kore ko jitsu = Every day is a good day.

User avatar
wicknix
Fanatic
Fanatic
Posts: 118
Joined: 2018-03-26, 04:47
Location: Wisconsin, USA

Re: 28.5.0 broken on Mac OS X

Unread post by wicknix » 2019-05-05, 19:47

adesh wrote:
2019-05-04, 11:06
@wicknix,

I've managed to fix the accessibility build on Mac. Can you please verify it builds fine for you with this patch applied?
Working well here. :thumbup:

Cheers
Silence is golden, but duct tape is silver...

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 5890
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: 28.5.0 broken on Mac OS X

Unread post by New Tobin Paradigm » 2019-05-05, 19:57

Of course accessibility should be disabled on mac for Pale Moon so you could say practically it doesn't matter for building Pale Moon, Basilisk and anything else wanting the features however...

Post Reply