Color grabber tool shows colors from the closed tab

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
Locked
User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Color grabber tool shows colors from the closed tab

Unread post by adesh » 2017-09-06, 15:10

  1. Select "grab color" from devtools
  2. You will get magnifying circle. Put it over some area of the webpage. Behold the colors!
  3. Close the current tab (Ctrl+W) so that another tab becomes active.
  4. Move the circle around. Now it will not make sense because you are seeing magnified contents of the closed tab.
  5. Click anywhere on the page to close the tool.
Attachments
zzzzz.png
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35576
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Color grabber tool shows colors from the closed tab

Unread post by Moonchild » 2017-09-06, 16:08

Devtools are linked to the tab they are opened in. That is why by default they are docked. The color picker will not refresh to an unknown tab (and the rendered page is cached in a "viewer" for performance reasons, obviously)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Re: Color grabber tool shows colors from the closed tab

Unread post by adesh » 2017-09-06, 16:41

When I closed the tab I was expecting the magnifier to go away since the docked devtools were also closed. Issue will be no more if that is done.
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35576
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Color grabber tool shows colors from the closed tab

Unread post by Moonchild » 2017-09-06, 17:00

Yeah I get it. it's a defect. But it's also very much a corner case and low priority.

EDIT: If anyone wants to work on this, create a github issue. Some background information: the eyedropper uses a XUL window as the dropper overlay, which is why it does not get closed with the tab (it's autonomous). It will need some signalling to close with the tab.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
GMforker

Re: Color grabber tool shows colors from the closed tab

Unread post by GMforker » 2017-09-06, 19:40

See also bug #1262439.
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35576
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Color grabber tool shows colors from the closed tab

Unread post by Moonchild » 2017-09-06, 20:05

GMforker wrote:See also bug #1262439.
Yeah, but there's absolutely no point in rewriting it for our use as html. That bug has as side effect that it no longer displays this behavior, but that wasn't the reason for its existence and I'd prefer not to convert it to some slow-as-tar html thing.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
Locked

Return to “Browser Development”