build error with gold: elfhack assertion failed Topic is solved

[Agent Orange]

Firefox bug 1233963 (solved) affects Pale Moon.

Attempting to build with --enable-gold gives the following error:

Code: Select all

31:07.49 ===
31:07.49 === If you get failures below, please file a bug describing the error
31:07.49 === and your environment (compiler and linker versions), and use
31:07.49 ===
31:07.49 === --disable-elf-hack until this is fixed.
31:07.49 === If you get failures below, please file a bug describing the error
31:07.49 ===
31:07.49 === and your environment (compiler and linker versions), and use
31:07.49 === --disable-elf-hack until this is fixed.
31:07.49 ===
31:07.50  0x0000000000000019 (INIT_ARRAY)         0x8440
31:07.50  0x000000000000000c (INIT)               0x4040
31:07.51 elfhack: /tmp/Pale-Moon-27.2.1_Release/build/unix/elfhack/elf.cpp:261: Elf::Elf(std::ifstream&): Assertion `segment->getFileSize() == phdr.p_filesz' failed.
31:07.51 elfhack: /tmp/Pale-Moon-27.2.1_Release/build/unix/elfhack/elf.cpp:261: Elf::Elf(std::ifstream&): Assertion `segment->getFileSize() == phdr.p_filesz' failed.
31:07.51 gmake[5]: *** [Makefile:29: test-array.so] Aborted
31:07.51 gmake[5]: *** Waiting for unfinished jobs....
31:07.51 gmake[5]: *** [Makefile:29: test-ctors.so] Aborted
31:07.51 gmake[4]: *** [/tmp/Pale-Moon-27.2.1_Release/config/recurse.mk:82: build/unix/elfhack/libs] Error 2
31:07.51 gmake[3]: *** [/tmp/Pale-Moon-27.2.1_Release/config/recurse.mk:37: libs] Error 2
31:07.51 gmake[2]: *** [/tmp/Pale-Moon-27.2.1_Release/config/rules.mk:541: default] Error 2
31:07.51 gmake[1]: *** [/tmp/Pale-Moon-27.2.1_Release/client.mk:398: realbuild] Error 2
31:07.51 gmake: *** [client.mk:171: build] Error 2
31:07.52 230 compiler warnings present.
31:08.71 Notification center failed: Install the python dbus module to get a notification when the build finishes.

Trying out their patch now; will report back in ~21 mins to see if it's a one-shot fix.

[Agent Orange]

dis fix it!

[Moonchild]

Unfortunately the .patch attached was not a valid patch file, but I applied the change manually.

Thanks!