userChrome.js/addbookmarkhere

This board is for discussions, bug reports, etc. for pre-releases of the v27 milestone codenamed "Tycho".

Since the beta phase is over, this board is closed for new posts/topics.
User avatar
Doelli
Moonbather
Moonbather
Posts: 55
Joined: 2014-10-11, 15:25
Location: Germany

userChrome.js/addbookmarkhere

Unread post by Doelli » 2016-10-07, 22:07

I noticed that the AddBookmarkHere.uc.js for the AddOn userChrome.JS doesn´t work in PM 27 Beta 1.
Is this the known issue #554?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35648
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: userChrome.js/addbookmarkhere

Unread post by Moonchild » 2016-10-09, 11:26

Issue #554 relates to RSS/Atom feeds. Unless that script tries to hook into that to create a bookmark (which would be strange...) it is completely irrelevant.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Doelli
Moonbather
Moonbather
Posts: 55
Joined: 2014-10-11, 15:25
Location: Germany

Re: userChrome.js/addbookmarkhere

Unread post by Doelli » 2016-10-10, 07:55

Hi Moonchild,

thank you for your quick answer!
Is it possible to fix this issue with the userChrome.js by yourself or should i contact the Developer of the script?

User avatar
Doelli
Moonbather
Moonbather
Posts: 55
Joined: 2014-10-11, 15:25
Location: Germany

Re: userChrome.js/addbookmarkhere

Unread post by Doelli » 2016-10-10, 13:51

Hi Moonchild,

i´d fixed the Scrip byself by removing this Lines in the "AddBookmarkHere.uc.js":

Code: Select all

            if (selectedNode) {
                if (PlacesUtils.nodeIsFolder(selectedNode) /* Firefox 21+ 不兼容 && !PlacesUtils.nodeIsLivemarkContainer(selectedNode) */ && !PlacesUtils.isReadonlyFolder(selectedNode)) {
                } else {
                    iid = bookmarks.getFolderIdForItem(selectedNode.itemId);
                    var id = bookmarks.getItemIndex(selectedNode.itemId);
                    aid = e.shiftKey ? id : id + 1;
                }
            } else {
                iid = view.result.root.folderItemId;
                aid = e.shiftKey ? 0 : bookmarks.DEFAULT_INDEX;
            }
No the script works fine!
Maybe you can tell me the reason why and what´s different to PM 26.x

Thanks!

User avatar
Doelli
Moonbather
Moonbather
Posts: 55
Joined: 2014-10-11, 15:25
Location: Germany

Re: userChrome.js/addbookmarkhere

Unread post by Doelli » 2016-10-10, 19:08

Unfortunately, the script works only unreliable.
I will make a request under the "Browser extensions".

Thank you!