MozArchiver blocks saving images Topic is solved

[WouterK]

Under Tycho Alpha 2, the MozArchiver extension blocks saving images.

Procedure:
1. Start Tycho Alpha 2, using a new profile created via command line option -p.
2. Open any web page containing a JPEG image.
3. Right-click on the image and execute "Save Image As". Result: the image gets saved.
4. Install MozArchiver 1.0.0 and restart the browser.
5. Execute "Save Image As" on a different image. Result: this image does not get saved, and the download window keeps saying "Unknown time remaining - o bytes (0 bytes/sec)". (Under Pale Moon 26.4.0 in the same situation, this image does get saved too.)

I don't know whether this is related to the problems reported in the "Classic Downloads Window does not seem to work" thread (https://forum.palemoon.org/viewtopic.php?f=56&t=12586).
If not, this may be something the MozArchiver maintainers will have to address in due course.

[GMforker]

Pale Moon throws an errors in the Error Console:

Code: Select all

Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIWebBrowserPersist.saveURI]
Source File: chrome://mza/content/integration/contentAreaUtils.js
Line: 456

Error: [Exception... "Not enough arguments [nsIWebBrowserPersist.saveURI]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://mza/content/integration/contentAreaUtils.js :: internalPersist :: line 456"  data: no]
Source File: resource://gre/modules/ContentPrefUtils.jsm
Line: 50

See bug #704320
(https://hg.mozilla.org/mozilla-central/ ... ersist.cpp)

I suggest you try to contact the author:
https://github.com/Lootyhoof/mozarchiver/issues

I sent him (Lootyhoof) a private message - here on the forum...

[WouterK]

Thanks very much for the analysis.
(I hadn't realized that the Error Console is already functional, unlike most of the other devtools. Not that the output would have made much sense to me...)

I'll see if I can report the problem at github. I'll have to register at github first

[Lootyhoof]

Thanks, I'll take a look at this. Sorry for the late reply - I was on vacation.

[Lootyhoof]

Please can you try version 1.0.1 (should update via add-ons manager) and see if the issue persists?

[coffeebreak]

The issue does persist for me with v1.0.1 (Tycho, W7 x86), same behavior described by OP, same errors (barring a line number). Images download fine though when version 1.0.1 is used on PM 26.4.1.

Errors:

Code: Select all

Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIWebBrowserPersist.saveURI]
Source File: chrome://mza/content/integration/contentAreaUtils.js Line: 462

Error: [Exception... "Not enough arguments [nsIWebBrowserPersist.saveURI]"  nsresult: "0x80570001 
(NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://mza/content/integration/contentAreaUtils.js :: 
internalPersist :: line 462"  data: no] Source File: resource://gre/modules/ContentPrefUtils.jsm Line: 50

Library:

mozArch-img-DLd.png

[GMforker]

Ad https://github.com/Lootyhoof/mozarchive ... dd3606R461

Code: Select all

3.0.0 < 3.*

See also:
https://github.com/MoonchildProductions ... ator.js#L1

https://github.com/MoonchildProductions ... ator.js#L7
vs.
https://github.com/MoonchildProductions ... tor.js#L17

e.g.

Code: Select all

3.0.0 > 3.0pre

[Lootyhoof]

Ah heh, whoops. Can you try this XPI and see if the issue is resolved?

[coffeebreak]

Sorry, Lootyhoof. The same problem occurs with v1.0.2pre.


Just on off chance that it will be helpful, here's a little more detail on what happens...
(And also happened with v1.0.1)

After an image download has been started, it cannot be cancelled / cleared within the library (shown in earlier posted image.) However it can be cleared after a restart. So (using a restart extension) I click the restart button, get a dialog asking whether to cancel the download:

cancelDLdDialog.png

Click it, restart, and...

On page load, this error:

Code: Select all

Error: TypeError: ownerDocument.defaultView is null Source File: jar:file:///C:/*********/User/Palemoon/Profiles/Default/extensions/mozarchiver@lootyhoof-pm.xpi!/components/ContentPolicy.js Line: 75

The Library now displays a completed download -- which can be cleared normally. And the image has, in fact, sucessfully downloaded:.

Library after restart:

mozArch-DLd-afterRestart.png

[Lootyhoof]

This should do it, I'd say - do let me know otherwise though, just to be sure.

[coffeebreak]

Version 1.0.2pre2 solves it. Works fine.

[Lootyhoof]

Good to know! I'll start getting it released soon.