Problem with icon fonts if downloadable fonts disabled Topic is solved

[superA]

Both alfa versions treat fonts differently here than the stable one.
If I uncheck '' allow pages to choose their own fonts..'' ( browser.display.use_document_fonts= 0 ), I have a lot of missing fonts.

[Moonchild]

Kindly provide:

• A better thread title than "Fonts"
• Standard support information (OS etc.)
• Examples and steps to reproduce

[superA]

Pale Moon "Tycho" alpha/beta 2 x32, Win7 x32,64, Vista x32, clean profile, no other addons installed than ublockO, just to use its pop up UI
as an example to reproduse among others.

Options/Content/Fonts/Advanced/ ''Allow pages to choose their own fonts,..'' Unchecked.

http://prntscr.com/c3h38m (symbols on the left)

http://prntscr.com/c3h3rl

http://prntscr.com/c3h5lx

[GMforker]

Off-topic:

Options/Content/Fonts/Advanced/

See also attachment.

[Moonchild]

Ah, I guess I need to re-implement the change to allow icon fonts even in that situation.

Also, please use one topic for one issue, unless you want to make things harder for us

[GMforker]

See bug #789788 (https://github.com/MoonchildProductions ... 8dfb66baf8). But... see also bug #1228799.

[Moonchild]

This was already fixed in Tycho. The additional bug mentioned is an enhancement to deal with bad fonts.

If anyone feels the calling, the enhancement is relatively self-contained and not very high risk.

https://hg.mozilla.org/releases/mozilla ... 2036786a92
https://hg.mozilla.org/releases/mozilla ... 7de631a38c

[gpower2]

Saw the mozilla changesets and I thought I'd give it a try. Just made a pull request, hope I didn't break anything.
Since this is my first pull request on GitHub, please don't be too judgemental...

[Moonchild]

Saw the mozilla changesets and I thought I'd give it a try. Just made a pull request, hope I didn't break anything.
Since this is my first pull request on GitHub, please don't be too judgemental...

Thanks for making the PR.
Did you also make sure to build and test your code changes?

[gpower2]

Unfortunately I don't have a working building environment, since this was my first take with Palemoon's code...
I surely checked for syntax errors and the code should build 100%, however I don't have a way to test if the changes actually work.
If you could provide me with some links for how to set up a building environment I will test it, since I am interested in "playing" some more with the current codebase.

[New Tobin Paradigm]

Which codebase is this for? 26.x or Tycho because there are some differences in compilers and build toolchain requirements.

[gpower2]

It's for Tycho codebase (branch master AFTER the big merge).

[New Tobin Paradigm]

Follow this: http://developer.palemoon.org/Developer_Guide:Build_Instructions/Pale_Moon/Windows

Just replace with MozillaBuild 2.0 or 2.1 and VS 2013.

Also add the following to the mozconfig there..

Code: Select all

ac_add_options --disable-shared-js
ac_add_options --disable-sandbox

making sure not to include..

Code: Select all

ac_add_options --enable-shared-js

as I just told you to disable it

THAT SHOULD be enough to get you building Tycho.. If not post back.

[gpower2]

I currently use VS2015 Update 3, would that be a problem/is it tested?
Because VS2015 contains the new Roslyn compiler...

[New Tobin Paradigm]

No it MUST be 2013.

Roslyn is irrelevant for Pale Moon since we are not a .net application.

[gpower2]

Since I don't remember if I have VS2013 installed on my dev PC, would it be allright to try and build Palemoon with VS2015?
Also, I see that MozillaBuild has release v2.2, is it compatible or should I stick with v2.1?

[New Tobin Paradigm]

It will not build with 2015.. And it is unknown if the newer MozillaBuild toolchain has what our codebase requires.. Please follow my instructions precisely. I did type them for a reason.

[Moonchild]

Since I don't remember if I have VS2013 installed on my dev PC, would it be allright to try and build Palemoon with VS2015?
Also, I see that MozillaBuild has release v2.2, is it compatible or should I stick with v2.1?

MozillaBuild v2.2 might work, but there's no guarantee.

As for compiler versions: unfortunately, MSVC has made breaking changes with each recent release at the code level. Code that compiles in VS2012 will not in VS2013, and code that compiles in VS2013 will not compile in VS2015. With the exception of small/simple programs that don't use the code that got broken with these transitions.

So, to be clear: the master (trunk) branch after the Tycho merge MUST be built with EXACTLY VS2013 (MSVC 12.0)

Also, sorry that you're having this little bump trying to contribute, but you have to understand that we simply can't accept code to our tree that hasn't at least been tested to build and do what it is supposed to be doing. It's just a logical extension of wanting to contribute to a live project that requires a certain level of code quality and shouldn't ultimately create more work for our very small team.

[gpower2]

Thank you both for your help!
I managed to make a successful working Tycho build, including my changes.
I used VS2013 Ultimate with Update 5 with MozillaBuild v2.1 and it took approximately 1hour.

However I had to make some changes in order to get the build to work:

1. I had to change .mozconfig line "WIN32_REDIST_DIR=$VCINSTALLDIR/redist/x64/Microsoft.VC110.CRT" to "WIN32_REDIST_DIR=$VCINSTALLDIR/redist/x64/Microsoft.VC120.CRT" (since the old line refers to VS2012)
2. I had to change the file dom\media\gtest\moz.build and remove the "/dom/media/eme" directory from the LOCAL_INCLUDES array, since this path does not exist in current codebase.

While the build completed succesfully and the resulted binary works like a charm, the bug in question still remains. The Fallback Character Encoding list is still empty...
The changes I imported from Mozilla are supposed to deal with bad fonts, so I guess they have nothing to do with the character endocing list, but I still don't have a test case in order to see if they fixed what they were supposed to...

[New Tobin Paradigm]

Sorry.. I missed --disable-eme flag in mozconfig..

Revert the change you made to the moz.build file.. and use

Code: Select all

ac_add_options --disable-eme

and of course keep your WIN32_REDIST_DIR change.

I should really duplicate and update the build instructions for windows for those getting a head start with Tycho..

Again, sorry about the oversight.

As an aside, should really make those changed options the default.