Problem with icon fonts if downloadable fonts disabled Topic is solved

This board is for discussions, bug reports, etc. for pre-releases of the v27 milestone codenamed "Tycho".

Since the beta phase is over, this board is closed for new posts/topics.
gpower2

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by gpower2 » 2016-09-11, 12:30

Ah, I figured there would be an option disabling that, I just couldn't find it...

Thanks again! :thumbup:

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35650
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by Moonchild » 2016-09-11, 12:46

Matt A Tobin wrote:Sorry.. I missed --disable-eme flag in mozconfig..
hmm. I thought I completely removed all that already, but I guess I missed something being too tired.
I'll double-check.

Yup, all of this was removed in the Tycho repo on August 12th.
I don't know what source you're using to build from, but it doesn't seem to be a current one?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

gpower2

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by gpower2 » 2016-09-11, 13:25

I'm currently building from latest master branch in MoonchildProductions/Pale-Moon, which I believe is the current branch for Tycho?

EDIT:
Using ac_add_options --disable-eme doesn't solve the build problem. Editing moz.build in gtest directory is still required...

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35650
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by Moonchild » 2016-09-11, 13:39

gpower2 wrote:I'm currently building from latest master branch in MoonchildProductions/Pale-Moon, which I believe is the current branch for Tycho?

EDIT:
Using ac_add_options --disable-eme doesn't solve the build problem. Editing moz.build in gtest directory is still required...
Yes, it would be, because I didn't see that line when removing EME code because it wasn't #ifdef'ed with MOZ_EME by Mozilla... And it wouldn't error out as long as the dir wasn't physically removed.
As a side note, you shouldn't have to build tests... --disable-tests will make your builds quite a bit faster ;)

EDIT: Pushed the appropriate change to the trunk.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

gpower2

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by gpower2 » 2016-09-11, 18:41

Just to summarize, I successfully compiled latest version (master branch of repository MoonchildProductions/Palemoon, commit 47bfb2f215c9e3375243a24c608fc3d517e75e04) with my changes (Pull Request #509) using:
  1. MozillaBuild v2.1
  2. DirectX 9.0 SDK
  3. VS 2013 with Update 5
  4. .mozconfig file contents:

    Code: Select all

    ac_add_options --target=x86_64-pc-mingw32
    ac_add_options --host=x86_64-pc-mingw32
    mk_add_options MOZ_CO_PROJECT=browser
    ac_add_options --enable-application=browser
    ac_add_options --enable-optimize="-O2"
    ac_add_options --enable-jemalloc
    ac_add_options --disable-shared-js
    ac_add_options --disable-sandbox
    ac_add_options --disable-eme
    ac_add_options --disable-tests
    
    WIN32_REDIST_DIR=$VCINSTALLDIR/redist/x64/Microsoft.VC120.CRT
It seems that everything works as it should, without any breakage at all.
However, the Fallback Character Encodings list is still empty.

New Tobin Paradigm

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by New Tobin Paradigm » 2016-09-11, 20:54

Code: Select all

### Mozilla Build Options
mk_add_options MOZ_CO_PROJECT=browser
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-dir/vnextTycho
mk_add_options MOZ_MAKE_FLAGS=-j4
WIN32_REDIST_DIR=$VCINSTALLDIR/redist/x86/Microsoft.VC120.CRT
ac_add_options --enable-application=browser

### Compiler Options
ac_add_options --enable-optimize="-O2 -GTs -GS- -fp:precise -Qfast_transcendentals -Qpar"

### Branding Options
export MOZILLA_OFFICIAL=1
ac_add_options --enable-official-branding

### Packaging
ac_add_options --with-distribution-id=Palemoon
ac_add_options --enable-chrome-format=omni

### Update Packaging
ac_add_options --enable-update-packaging

### Enabled Features

### Disabled Features
ac_add_options --enable-jemalloc
ac_add_options --disable-crashreporter
ac_add_options --disable-accessibility
ac_add_options --disable-parental-controls
ac_add_options --disable-maintenance-service
ac_add_options --disable-webrtc
ac_add_options --disable-websms-backend
ac_add_options --disable-metro
ac_add_options --disable-windows-mobile-components
ac_add_options --disable-shared-js
ac_add_options --disable-sandbox

### Other Options
ac_add_options --disable-debug
ac_add_options --disable-tests
ac_add_options --disable-mochitests
ac_add_options --enable-strip
ac_add_options --enable-strip-libs
That is what I use though, I don't really need a few of them but they don't hurt...

GMforker

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by GMforker » 2016-10-19, 07:20

I propose to add the attribute "Topic is solved".

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35650
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by Moonchild » 2016-10-19, 09:53

Was this solved/verified? I forget XD
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

GMforker

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by GMforker » 2016-10-19, 12:30

Off-topic:
Ad viewtopic.php?f=56&t=13297#p95378
Matt A Tobin wrote:GMforker please stop this blanket posting of what is fixed and what isn't.
Yes, it is a mistake. You can reopen it. And you can cancel confirmation.
Perhaps it's not a big problem...

But... Because if sorting doesn't work, it doesn't really clear for a few pages.
See also https://www.phpbb.com/customise/db/exte ... pic/149296

gpower2

Re: Problem with icon fonts if downloadable fonts disabled

Unread post by gpower2 » 2016-10-19, 17:37

I think that both issues addressed here were fixed with this GitHub issue:

https://github.com/MoonchildProductions ... issues/613

and this pull request:

https://github.com/MoonchildProductions ... n/pull/509

Now if there is any other issue addressed here that remains unsolved, I suggest to open a new issue in GitHub, rather than leaving this old thread as unsolved, with a misleading title (since the issue in title is indeed solved).