The Guardian crashes 27a2 Topic is solved

[Terryphi]

Soon after going to The Guardian http://www.theguardian.com/uk PM 27a2 crashes. (Tested on Linux.) This is what the error console shows:

Code: Select all

Timestamp: 29/07/16 15:01:08
Error: Error sanitizing downloads: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIDownloadManager.cleanUp]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/sanitize.js :: Sanitizer.prototype.items.downloads.clear :: line 312"  data: no]

Source File: chrome://browser/content/sanitize.js
Line: 81

Timestamp: 29/07/16 15:01:10
Error: A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Fri Jul 29 2016 15:01:08 GMT+0100 (BST)
Full Message: undefined
Full Stack: JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: PendingErrors.register :: line 162
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.completePromise :: line 675
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 903
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 746
JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.scheduleWalkerLoop/< :: line 688
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Source Code:
0

[dark_moon]

Site render fine under windows 7 x64 with 27a2 x64

[Moonchild]

No problem with the site either on Windows 7, a2 x86 -- displays fine even the half-vertical advertisement that pushes the content down and gets priority over the page header even ;P

[GMforker]

Soon after going to The Guardian http://www.theguardian.com/uk PM 27a2 crashes. (Tested on Linux.)

Confirmed (also on version alpha1) on Ubuntu 16.04 x64 - the Terminal: "palemoon --jsconsole"):

Code: Select all

Vector smash protection is enabled.
[NPAPI 4722] ###!!! ABORT: Aborting on channel error.: file /home/trava90/PaleMoon/Tycho/Tycho/ipc/glue/MessageChannel.cpp, line 1584
[NPAPI 4722] ###!!! ABORT: Aborting on channel error.: file /home/trava90/PaleMoon/Tycho/Tycho/ipc/glue/MessageChannel.cpp, line 1584
Segmentation fault (core dumped)

apport.log:

Code: Select all

ERROR: apport (pid ...) executable: /home/.../plugin-container (command line "/home/.../plugin-container /usr/lib/flashplugin-installer/libflashplayer.so -greomni /home/.../omni.ja -appomni /home/.../browser/omni.ja -appdir /home/.../browser 5716 plugin")

[Moonchild]

The line indicated is a deliberate program exit when mAbortOnError is set (in the ctor it's set to false, but the initialization for the Chrome set it)
So, there's a problem with inter-process messaging with flash on Linux... somewhere.

PluginModuleChild::InitForChrome has the line GetIPCChannel()->SetAbortOnError(true); in it. This causes any messaging channel channel that throws an error and is not closing at the time to cause a runtime abort (and forcefully exit the browser). I think that's quite drastic of a result and should just toss back the error and pass it up the chain instead (which it would if not set to abort)

[Moonchild]

I've made a change to make this non-fatal on Linux. Next pre-release should be able to handle this without this particular crash.

[Terryphi]

Moonchild: Thanks for that.

[GMforker]

See also https://github.com/MoonchildProductions ... 67a85325ae