Lightweight themes broken Topic is solved

[adisib]

It isn't mentioned in the known issues, so I'll just mention it here so it can get added.

Platform: Windows 10 x64
Lightweight theme used in example: http://www.palemoon.org/persona/

Screenshot of the issue:


Issues:
1. The ' X ' close button does not appear while the other titlebar buttons do.
2. The buttons do not highlight when hovered over.
3. Extra space is now generated when the persona is active; e.g. the bottom of the active tab does not seamlessly connect to the navigator-toolbox with the URL bar.

[Moonchild]

Created https://github.com/MoonchildProductions/Tycho/issues/80

Probably needs some DOMi work to see what the hell is going on.

[Moonchild]

Was a combination of several issues - all should be fixed now.

[adisib]

While the mentioned issues have been fixed, I've noticed another. The lightweight themes are not applied to private-browsing windows.

[New Tobin Paradigm]

I know there is a bug about this somewhere on Bugzilla.. But I have to ask.. Did they in Pale Moon 26? Because it isn't broken if it was never there to begin with.. Allowing them in private windows would be merely an enhancement if that is the case.

[adisib]

Yes, lightweight themes were applied in private browsing for Pale Moon 26

[New Tobin Paradigm]

Welp.. guess it is a regression.. Likely from e10s refactoring.. We will take a gander see what can be done.

[Moonchild]

This is a regression because it hasn't been re-implemented yet (Mozilla has always done it this way because they wanted to make PB windows stand out as different -- to a fault). This was a Pale Moon change waaay back in the BE, I'll have to check.

EDIT: aaaand.. fixed
https://github.com/MoonchildProductions/Tycho/issues/95

I guess that wraps it up so marking solved. Please make a new thread for any other LWT issues you come across.