Request: Please don't degrade "unofficial" build

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
Walter Dnes
Astronaut
Astronaut
Posts: 714
Joined: 2015-07-30, 20:29
Location: Vaughan, ON, Canada

Request: Please don't degrade "unofficial" build

Post by Walter Dnes » 2024-11-01, 07:20

I'm not redistributing my own custom build (especially not with "-march=native"), But my build is far enough "off the beaten path" that I prefer it labelled as "unofficial". The problem is that the "unofficial" build has some changes that don't make sense.

I understand disabling updates, changing the logo, changing "Help ==> About", etc. But as I found out ( "the hard way" ) in viewtopic.php?f=5&t=31736

1) The usual User Agent over-rides are not supplied.

2) Compatibility Mode is different for "unofficial" versus "official".

I assume the User Agent and Compatability Mode settings in "official" are made to improve Pale Moon usability for users of that build. What is the rationale for not including them in "unofficial"? IANAPP (I Am Not A Proffesional Programmer) but I believe the following changes should suffice to make "unofficial" more usable...

1) In the source code at the top of the file
palemoon/branding/unofficial/pref/palemoon-branding.js
add the lines

#filter substitution
#filter emptyLines
#include ../../shared/pref/uaoverrides.inc


2) In that same file, append the lines

// Enable Firefox compatmode by default.
pref("general.useragent.compatMode", 2);
pref("general.useragent.compatMode.gecko", true);
pref("general.useragent.compatMode.firefox", true);
pref("general.useragent.compatMode.version", "102.0");


While we're at it, are there any other changes I missed?
There are 2 kinds of people in this world...
1) Those who can extrapolate from incomplete data

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 38378
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Request: Please don't degrade "unofficial" build

Post by Moonchild » 2024-11-01, 11:07

You can blame the New Moon people for having made this decision at the time to make unofficial totally bare bones.
I'll think about improving this when not busy with other things.
"There is no point in arguing with an idiot, because then you're both idiots." - Anonymous
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite