SunOS build failure with 32.5.0

[ptribble]

Building 32.5.0 on illumos fails with:

19:23.30 Text relocation remains referenced
19:23.30 against symbol offset in file
19:23.30 ff_cos_1024 0xcf7 x86/fft.o
...
[lots more ff_cos_XXXX]
...
19:23.32 ff_cos_2048 0x1817 x86/fft.o
19:23.32 ld: fatal: relocations remain against allocatable but non-writable sections
19:23.32 collect2: error: ld returned 1 exit status
19:23.32 gmake[5]: *** [/export/home/ptribble/ud/palemoon-source/platform/config/rules.mk:772: libmozavcodec.so] Error 1

This seems to be yasm, but my yasm is current.

A working fix (as I'm posting this from a 32.5.0 built with this patch) to platform is:

Code: Select all

diff --git a/old-configure.in b/old-configure.in
index aa1750ec90..840554a541 100644
--- a/old-configure.in
+++ b/old-configure.in
@@ -3267,6 +3267,9 @@ case "$OS_ARCH:$CPU_ARCH" in
   WINNT:x86)
       MOZ_LIBAV_FFT=1
   ;;
+  SunOS:x86_64)
+      MOZ_LIBAV_FFT=
+  ;;
   *:x86_64)
       MOZ_LIBAV_FFT=1
   ;;
@@ -3334,6 +3337,9 @@ case "$OS_ARCH:$CPU_ARCH" in
   WINNT:x86)
       MOZ_FFVPX=1
   ;;
+  SunOS:x86_64)
+      MOZ_FFVPX=
+  ;;
   *:x86_64)
       MOZ_FFVPX=1
   ;;

Thanks!

-Peter

[athenian200]

I wound up fixing the same issue here:

https://repo.palemoon.org/MoonchildProd ... f4843ac7ef

But unfortunately, I didn't catch it before 32.5.0 released, so this won't actually ship until 32.5.1. I was at school all week, and couldn't really get home to look into why 32.5.0 was having issues until this weekend.

Basically, for whatever reason, it requires the creation of some kind of linker mapfile that is compatible with the illumos linker, and I implemented code that does generate code you can feed that linker (The mapfile it generates is probably far from ideal and basically just uses an arbitrary symbol version from an old Solaris tutorial, though that would be hard to do better when dealing with auto-generated mapfiles that are this limited anyway).

[ptribble]

That sounds great, thanks!

[athenian200]

Oh, and by the way... looks like we have permission from MC to use that patch with 32.5.0 without using a different version number.

https://repo.palemoon.org/MoonchildProd ... ease-SunOS

He created this for us when he found out I added the mapfile support in because of build bustage. Which I probably should have mentioned in my PR, but I got so engrossed in seeing if I could get a SunOS-style mapfile to work with our build system that I forgot why I was doing it, and wound up pushing it forward with a bunch of other fixes.